From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qHWDNg+DrGFiOAEAgWs5BA (envelope-from ) for ; Sun, 05 Dec 2021 10:14:55 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id yBYmMg+DrGGiYQAAB5/wlQ (envelope-from ) for ; Sun, 05 Dec 2021 09:14:55 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 844CE2F877 for ; Sun, 5 Dec 2021 10:14:55 +0100 (CET) Received: from localhost ([::1]:51672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mtnbh-0000r1-TS for larch@yhetil.org; Sun, 05 Dec 2021 04:14:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38614) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtnb7-0000qs-Va for emacs-orgmode@gnu.org; Sun, 05 Dec 2021 04:14:17 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:35787) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtnb5-0000MS-Qi for emacs-orgmode@gnu.org; Sun, 05 Dec 2021 04:14:17 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 32534240009; Sun, 5 Dec 2021 09:14:11 +0000 (UTC) From: Nicolas Goaziou To: Kaushal Modi Subject: Re: [PATCH] Fix org-comment-line-break-function References: <87lf18fue9.fsf@aquinas.i-did-not-set--mail-host-address--so-tickle-me> <87v90cpcdx.fsf@yandex.com> <87ilwcf31l.fsf@aquinas.i-did-not-set--mail-host-address--so-tickle-me> <87pmqjkai3.fsf@gmail.com> <87fsrffknl.fsf@aquinas.i-did-not-set--mail-host-address--so-tickle-me> <87czmijtrp.fsf@gmail.com> <87o861o9sh.fsf@aquinas.i-did-not-set--mail-host-address--so-tickle-me> <87h7btpfbt.fsf@gmail.com> <87zgpli5nc.fsf@gmail.com> <871r2suhw2.fsf@gmail.com> Date: Sun, 05 Dec 2021 10:14:11 +0100 In-Reply-To: (Kaushal Modi's message of "Sat, 4 Dec 2021 22:36:07 -0500") Message-ID: <874k7nmn18.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.193; envelope-from=mail@nicolasgoaziou.fr; helo=relay1-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Lawrence , Marco Wahl , Tim Cross , emacs-org list Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638695695; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=vpO0xnvbsMpcuAI1zcMVm4KLjRbbjy7dAQqmIcOQigU=; b=CSm2QgMCcLN3MaiQKcVI6qcYffXER8YOYsdhe0HNw6OFmQ1+i/vtBn8lB6Dinq7APJLkVP zfb7I+G5V4uINXhuOeXV2uSpNzP8av5ccwc/oxgedvaJhpM0XNdal9ndPFA/zmlYQnzy/h xMZ2vp8xPnS1E6zhURV1S2ELZJHQsmyHx7nALasifp2o/OZkNswuz63OT9sPSoa/5lztaG XbY88nwU0Ub+GnZDIC91z8lGubFYuUmBBe5TwBxPjx/ffXS340FnlY8BM7tD/z5LrnjF5u E72I7U2T3lsjegzsfeUuTK06eEk1LZq0xXEGLlDh0gLef39JuWNXQGXtWChgnA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638695695; a=rsa-sha256; cv=none; b=rtHt1JxYzM4XOSrsW/NbFBJqXMKR9g7cy6jmAq6tAnV11q71vDIEidvURc9mw5RCeXi0ZY Mufxv2xlUnmj9waW6asiQZFxXY7dk/mG59RxxmvGILc/g4zNJvMjf50BDtmKglE2oygiT6 TcL3QcIDO3Ut6Xe3XMUMhvxq5gVKRzNaHsqyxEDvdco2c2XHvZaB9q5kYpS/OlVknAvXhJ soznK17Phc2WpWU7mIS3CnMtjBM4R1EBMXJbsXtTokQUbUtH3ZR0d/Ht4XRKUo641oZl02 I1DM2U4F+a3hvorDqxTyOb4Wu561mdfK6+S52y77kgWkPPf8hrcsVHsDctGa9A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.53 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 844CE2F877 X-Spam-Score: -1.53 X-Migadu-Scanner: scn0.migadu.com X-TUID: XW18qIb2j1W2 Hello, Kaushal Modi writes: > Thanks. Nicolas asked me to add tests for this patch. But I need to look > into how to add tests for behavior of bindings. Need to add tests for M-j > binding behavior when cursor is within a comment or outside. I don't think you need to test the binding. You could test (call-interactively o-c-l-b-f) instead. Besides, tests are not a blocker. Regards, -- Nicolas Goaziou