From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kASmKTab7GGoVQAAgWs5BA (envelope-from ) for ; Sun, 23 Jan 2022 01:03:02 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id +OxJJjab7GGXXwEAauVa8A (envelope-from ) for ; Sun, 23 Jan 2022 01:03:02 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4EE2340585 for ; Sun, 23 Jan 2022 01:03:02 +0100 (CET) Received: from localhost ([::1]:47672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nBQLV-0006jz-3i for larch@yhetil.org; Sat, 22 Jan 2022 19:03:01 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54818) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nBQKz-0006jp-JP for emacs-orgmode@gnu.org; Sat, 22 Jan 2022 19:02:29 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:46061) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nBQKl-0001v9-L9 for emacs-orgmode@gnu.org; Sat, 22 Jan 2022 19:02:18 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id CD99CFF802; Sun, 23 Jan 2022 00:02:11 +0000 (UTC) From: Nicolas Goaziou To: Jonas Bernoulli Subject: Re: [PATCH v3 3/3] ox-texinfo: Define definition commands using description lists References: <20211218214038.9459-1-jonas@bernoul.li> <20220118151129.19646-1-jonas@bernoul.li> <20220118151129.19646-4-jonas@bernoul.li> Date: Sun, 23 Jan 2022 01:02:10 +0100 Message-ID: <874k5vfhfh.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.199; envelope-from=mail@nicolasgoaziou.fr; helo=relay9-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642896182; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=olp45iNhBKCJWvOVMloZBilZ1kYHVo1RYUsAanY8tPY=; b=p9yRibUGQUSAVV1fzE63sQ4YaChsl7ZglOTJFrQIKCu1/fNIE7Ze6UypMIQ8cPrU0y/zid TVDPmHeKJ2sH5i545wFhSWsvKz9my6zN+VY8mWP9uzehtSi0eHDUTm8kU+GZMbYJpjBc8O sqZRvQKOsQ0fAyKbQWvvQfPFLp7GXOFP1pcJZdbSD8fpZ7ZeQVaP5g/b+6cvZO+dzZTnUQ fbASgoRN8A6+AWlVLfCqlfOc+uJWWd8MvY/iQOAyTYV8je/Qh6BnXmcvfarFG6uoCcS7lE peAqWvprYbg05UpGZh69ynTKyLYVy94SCiF7HQLqWyetmd86YaZ3RLwYVGJrKg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642896182; a=rsa-sha256; cv=none; b=rWxJfLFmlhJz3AaZZNjTwTNeB5Sv3kgSqFkLw4BP/wdRatUkxZvA30Q2i7vNH/0IG/ANuN PN03FFvW9BWh1GqCs/Ex1dNJzUlIm8ruH5FYcIZ1DNu17XqYfJ0UIk1ZYIG6QgkIOVRKpL 82IPLihtvNg62vuZ8kguln6YCxCOjZb67K92zyuWnH7YJ8wlUF9EWnhleE/HVXI5QttU6s kvViL0xZElLiAMd+bv7I/0USdEanx/s50f3gDACc/SHZYVJZgD9beF1p9VFE4qf2e5Icf1 LpWvMg3BJ6GRQjoGgPByw0IiCrnjvMjBufZWy4F/rsTWwqkpge6fwzARhJWWMQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.23 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4EE2340585 X-Spam-Score: -3.23 X-Migadu-Scanner: scn1.migadu.com X-TUID: mbNEhU7JoHBI Hello, Jonas Bernoulli writes: > +The Texinfo export back-end supports two approaches to writing Texinfo > +definition commands. One of them is describe here, the other in > +[[*Plain lists in Texinfo export]]. Typo: one of them is described here > +(defvar org-texinfo--quoted-keys-regexp > + (regexp-opt '("BS" "TAB" "RET" "ESC" "SPC" "DEL" > + "LFD" "DELETE" "SHIFT" "Ctrl" "Meta" "Alt" > + "Cmd" "Super" "UP" "LEFT" "RIGHT" "DOWN") > + 'words) > + "Regexp matching keys that have to be quoted using @key{KEY}.") OK. This is the one missing from first patch. > +(defun org-texinfo--massage-key-item (plain-list item args) > + "In PLAIN-LIST modify ITEM based on ARGS. > +Reformat ITEM's tag property and add findex and kindex entries to > +its content. If the bullet is \"+\" then use \"@itemx\" and deal with > +data from preceeding siblings that use such a bullet." The last sentence is a left-over from the previous prototype. > + (t > + (org-element-set-contents > + item (nconc > + (mapcar (lambda (key) `(keyword (:key "KINDEX" :value ,key))) kindex) > + (mapcar (lambda (cmd) `(keyword (:key "FINDEX" :value ,cmd))) findex) > + (org-element-contents item)))))))) Indentation seems a bit off, otherwise, LGTM. Regards, -- Nicolas Goaziou