From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id TnU4B1WTd2IiCwAAbAwnHQ (envelope-from ) for ; Sun, 08 May 2022 11:54:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id wCsOBlWTd2JsYgEAauVa8A (envelope-from ) for ; Sun, 08 May 2022 11:54:29 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C740021726 for ; Sun, 8 May 2022 11:54:28 +0200 (CEST) Received: from localhost ([::1]:44104 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nndcQ-0004QK-Vf for larch@yhetil.org; Sun, 08 May 2022 05:54:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35418) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nndbI-0004Q4-5c for emacs-orgmode@gnu.org; Sun, 08 May 2022 05:53:16 -0400 Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]:42999) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nndbG-0002hi-Kr for emacs-orgmode@gnu.org; Sun, 08 May 2022 05:53:15 -0400 Received: by mail-pf1-x430.google.com with SMTP id x23so9879824pff.9 for ; Sun, 08 May 2022 02:53:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=P9/zhD30BuFkVBAaddEjt0UuzofC+Ef37AuFAhqQQS4=; b=awkaH0AA22+1mx5xxAGsWD3SPtH2emIZOVhLSsPJlcvwPLf55ueyW9kblG1lBZWcav FMgAQIJcJWrhmK0tAoFFoUTgRUi2FheyTOUDST301ZEVqBCnW386YnrrF2sLgYAJqYsN VnPWobxXmaTkl/xvxiNK5gTwTXubdNe7ZWXib8fnV/OKL06gAZjAHiy/DFjtV/hDVrMk H7UjEZcAw61Escz2z5BVLIuuc+nWz3/UIZpdN5lgoyJMBGpD5ZPY8ZFFZUaBfo9T+9BH NMu8QiLcy1sLrz0koMvsbovEO4y6FgjOsLd9AKOx4B3pvuwFMSPHtsOwnDDlcRHzutce kwiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=P9/zhD30BuFkVBAaddEjt0UuzofC+Ef37AuFAhqQQS4=; b=g9dfWrzqA42qyp7Tj/TUY9/OcvQC4EUflapghfdBRpACKaIcdSNvw2j0gVIj7114OV qx4H8NRN+uAzNvQtux2CLg5bHmBAJM5FOY4xgPqxXLN/bU7vNatggN8JZxRPv1AhACsv X/6h0LycBhWbFg7k4WNYrfYYruBk1hwKV8cUCt5tJKdtsF2nYqvJh3A3ks55TMOF7upb DNeMt+LSj5xRIgeF2j8FpF2yPLsc4ATXhsdfXBF+VY9npc9wE2IgvmXTE0EdxMUt8kXC 9+P/62iryfU9cqp7qMKM70EF9WrE5df5Q4CH7y5U+RQIVPrVOi8SPAIEnnuu5iZcefpI sqAg== X-Gm-Message-State: AOAM530BCsMKgODf0lEGa7i1S6exGiO8L0Z+AHVQ+gD4tK/c7nJO8LsI xqa2wbXfxgDXxoipIqOWi+A= X-Google-Smtp-Source: ABdhPJwIRSx8cg+pZFUlwJ2oZg5B01KIY/NrCFcsR453Dr3XVjbbZ/BLThY41yA61Ukacy/5vVY8+w== X-Received: by 2002:a05:6a00:24c1:b0:50d:33cf:811f with SMTP id d1-20020a056a0024c100b0050d33cf811fmr10836086pfv.78.1652003592732; Sun, 08 May 2022 02:53:12 -0700 (PDT) Received: from localhost ([66.154.104.4]) by smtp.gmail.com with ESMTPSA id s7-20020a170902a50700b0015e8d4eb206sm4883692plq.80.2022.05.08.02.53.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 May 2022 02:53:12 -0700 (PDT) From: Ihor Radchenko To: Daniel Fleischer Cc: emacs-orgmode@gnu.org Subject: Re: Recent changes in org-fold regarding emphasize visibility In-Reply-To: References: <87a6bxicj9.fsf@localhost> <87ilqiynt1.fsf@localhost> Date: Sun, 08 May 2022 17:53:54 +0800 Message-ID: <874k20s631.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::430; envelope-from=yantar92@gmail.com; helo=mail-pf1-x430.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1652003668; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=P9/zhD30BuFkVBAaddEjt0UuzofC+Ef37AuFAhqQQS4=; b=NSV9LWVaXd+XedlpiQeMXmbIgm3ci9dO4cKJOIxaMBSQkhbqKF10KVxXy8FZd8plQDHNx5 kCWg1SOURzmr7KeKDVd+816vNuzfO29flJ/2zc9WbCkLBTs2E1NK2B3vmzBaDJr1T2KMcD adN1PWYHB076zzgMA+zN/2uszYQVzRseJcl9bAWgrXVHtR40oJxAyzPx11YsYfjWAZ9+W+ 4zFuRWG3uu3sERyi/tm9OB9FtvCHmtEx57S6hJ1bd48UA7S/WqKl61+rc8WXoqxBz/KbYJ 5qijyQGodITs/9w0E2/QvHMkFVeWZDX9ngXzkjqs2dWLdTyM0Qt3dgGwPO0kdQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1652003668; a=rsa-sha256; cv=none; b=LG94C4Q9A/jPE1imF75bwdqKiFadPZh6EedyBTXPrMH3lMgIBPzCo/NKzU6RwU0tuQsnyS qi94xReifUtIgWM2c7IGRii0L3Hwd4KMHFJ7D+P+eLA5ewyZ7LlDg1RNNFbxpeqBIIaXx3 RNLHTXfcjo25GOsS5u1xZP/N1mZvhs680Wb1rxPu438bnJpbmeEw8av4FVGXSqxB5Hocm4 YjTS1exgGchV+Q/iyWwvodashhCw2D+bVkoFM0bO5nk18gMK0Y9s8o9nMbgYIynSCTtmNs ut3ff3vunnhTGftTMwsyB739TckJ3z1+su9hFmiSUMtGM4ycvKcNf57/cyCMgw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=awkaH0AA; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -9.30 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=awkaH0AA; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C740021726 X-Spam-Score: -9.30 X-Migadu-Scanner: scn0.migadu.com X-TUID: hnZqUpSQX8yV Daniel Fleischer writes: >> The question is what should be the logical behaviour of Org when editing >> text inside or at the border of these hidden text types? How should we >> interpret the values of org-catch-invisible-edits (nil error show >> show-and-error smart)? > > Not sure we need to reinterpret the settings; roughly they cover the > different options of what to do when you edit a hidden text: edit > anyways, throw an error, unfold but do nothing, unfold and do what you > wanted to do and the only thing I don't have an intuition about is the > smart option. > > BTW, there are no issues when the folding core style is "overlays". So > why not follow what happens in that case, even formalize it into tests? Reasonable. I have made changes in invisible edit handling. Now, when using 'text-properties style, org-fold-check-before-invisible-edits ignores folded links just like it does with overlays style. The commit is 2e4ed52b1. Let me know if you are getting the expected behaviour now. Best, Ihor