From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>
Received: from mp10.migadu.com ([2001:41d0:2:bcc0::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms5.migadu.com with LMTPS
	id UBlAAb5hqGIDtAAAbAwnHQ
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Tue, 14 Jun 2022 12:23:58 +0200
Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp10.migadu.com with LMTPS
	id CAg2AL5hqGIjdwEAG6o9tA
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Tue, 14 Jun 2022 12:23:58 +0200
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id A74638F34
	for <larch@yhetil.org>; Tue, 14 Jun 2022 12:23:57 +0200 (CEST)
Received: from localhost ([::1]:49410 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	id 1o13iG-0006vU-Pt
	for larch@yhetil.org; Tue, 14 Jun 2022 06:23:56 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:60974)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <rpluim@gmail.com>) id 1o13hl-0006vK-0b
 for emacs-orgmode@gnu.org; Tue, 14 Jun 2022 06:23:25 -0400
Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:44804)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <rpluim@gmail.com>) id 1o13hf-00082X-KZ
 for emacs-orgmode@gnu.org; Tue, 14 Jun 2022 06:23:24 -0400
Received: by mail-wr1-x42e.google.com with SMTP id q15so10570043wrc.11
 for <emacs-orgmode@gnu.org>; Tue, 14 Jun 2022 03:23:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :mime-version; bh=g65EEQjdNttt9+STRCLE4KjPcLw41ubDynYXdwRuJuA=;
 b=iJ5RvUXg9ZbEgYcI7OAPQq9MQD4eQO3tA3Rb8Cj+DiaziJo8uoQS+kxjSUBJ/tnAL3
 ofIVhtxhM+ggZDCJ+GcrY0BUukqwkDID7Pub+wreRjBUXx90MgvsfJsVE8N5VAoKTa00
 SFKAd+t+kEPbROb+VtvzhWweQX1/iIK9mQO3cH2X5xxFNGAevJzXgObjb8b1umB0wdyJ
 rvx/R3zTo0zTr13LYz8CJHjJdbMqo2HvEKWFsHeFRGZxy8PgcQ3k/JsEmivFxBrUkd6E
 tOC8uPUAWhgg9w1m239nhg4dDleblNPZcgTQX8lEtKqgdSeFrh+dsEuy387uK1D5mU39
 G2gg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:mime-version;
 bh=g65EEQjdNttt9+STRCLE4KjPcLw41ubDynYXdwRuJuA=;
 b=2OrK4QI+mE+oHTEW4GESginqTyiZ4lzFspSBl1p3lT/usjxw4uBgHmrw9TYDjXaL3C
 tE/KXMEUxKAWgjjWFgH6uzIotvm5r+AgqGRFhoYelFdzdyYfGVoNPO8QrzZi4daegamR
 RlwD/Zw72bh6lWUTLSfUMsbOVqFmoSuGxKjfNHK3cBo0JLQqqSltUlLnA6PDXgvBf7wt
 t+67srXkD7Exvr+qcqpucI7LNORJQqAlp1xpiZnBDnnNuLnAuzN7fgWDDzGD+z3Lhisv
 +2rMREfUCVBZoJxiHxZOW6byFPSGtjS4OuI+2NrXdro1Gfw7QthGfHTscmBU+rDNw155
 Kulg==
X-Gm-Message-State: AJIora8UfpFtMPr28oI4DRF8Yirsz0GMsOFknFkwUb5t3jqPCu+FI6sf
 nTp0WSfXcD2O5QTjnbhbOlocEhIjSws=
X-Google-Smtp-Source: AGRyM1tkhzJc8Is+KdO6K6jhJGjEhGdxHbN5OY5ETzEI+rMFgpA7NGx82v/QKgxWWKoAb7CUhMbbGw==
X-Received: by 2002:a05:6000:1866:b0:218:40cc:a26e with SMTP id
 d6-20020a056000186600b0021840cca26emr4194614wri.678.1655202197340; 
 Tue, 14 Jun 2022 03:23:17 -0700 (PDT)
Received: from rltb ([2a01:e0a:3f3:fb50:c43e:652:64b6:8eb])
 by smtp.gmail.com with ESMTPSA id
 e10-20020a5d4e8a000000b00210320d9fbfsm13482189wru.18.2022.06.14.03.23.16
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 14 Jun 2022 03:23:16 -0700 (PDT)
From: Robert Pluim <rpluim@gmail.com>
To: Daniel Fleischer <danflscr@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Don't quote symbols in defcustom types
References: <87h74nzj90.fsf@gmail.com> <m2h74no8nt.fsf@gmail.com>
Date: Tue, 14 Jun 2022 12:23:15 +0200
In-Reply-To: <m2h74no8nt.fsf@gmail.com> (Daniel Fleischer's message of "Tue,
 14 Jun 2022 13:12:54 +0300")
Message-ID: <874k0nzgq4.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=2a00:1450:4864:20::42e;
 envelope-from=rpluim@gmail.com; helo=mail-wr1-x42e.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: emacs-orgmode@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org
Sender: "Emacs-orgmode" <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>
X-Migadu-Flow: FLOW_IN
X-Migadu-To: larch@yhetil.org
X-Migadu-Country: US
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1655202237;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:in-reply-to:in-reply-to:
	 references:references:list-id:list-help:list-unsubscribe:
	 list-subscribe:list-post:dkim-signature;
	bh=g65EEQjdNttt9+STRCLE4KjPcLw41ubDynYXdwRuJuA=;
	b=HlFHVkjGSf4p/u+dIiPhb1V61JWqlvcbaYSlnjFodLoGQ6VPw+YVEUYJ8TqoEHPgYx83J0
	IVOklqmSaj7gKMZWp61cgWMIo4/JRQfsGEMtf+Id1MfiqPPbYeE7fwDv3SjEc6y7fZfel4
	wmgFNci0DPN3xiPUJOFUYG7ZWy+b3r/S98wkw32DmtFTDZwhfKF+t6N115s9P7z4c/Ndh6
	vREJVptAs0k9QBReTTCUoFFDr99YMbeLjFFU8mD6zeHRec8Hu4rbaXhkRsy8WrtPSPJhVN
	BJl1j2WoFyaHDDewZglworydUck7k0Sxl4mc97mXTvnumKyjaJaHA+08igZ5Dg==
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655202237; a=rsa-sha256; cv=none;
	b=HNLxubeTy8u9kkdBlxGX8WXEbIfqLgMLsLrgV5QRY7io4JvIPg0rDFhSu8R93gYk2lVZ3b
	EZdlZAn1D1K5HS9cgbcVDGzxcFN+9QDGFuU4plPoeQvVuz9qF8yG0gT+vlW0zYY7ewtkn8
	14xq/2OIU9/djJo6OrthgZv8A5rVG/yE+ngigm8+wRqorWCDY/wBOsRkewFSzHzGrfUdvM
	GggEbsiAmK4SEv17NMc2VYihSAgGQh8eNInezPp/dx8YNCMI8eNvZAPJqWx8dNrMTow/Ji
	ZjPRqUNQcRdhUXQxvIgIcPUOzVO73zYSbUXIo/Af1qrZRAMtnBVkI99hdDL5yQ==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=pass header.d=gmail.com header.s=20210112 header.b=iJ5RvUXg;
	dmarc=pass (policy=none) header.from=gmail.com;
	spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"
X-Migadu-Spam-Score: -3.99
Authentication-Results: aspmx1.migadu.com;
	dkim=pass header.d=gmail.com header.s=20210112 header.b=iJ5RvUXg;
	dmarc=pass (policy=none) header.from=gmail.com;
	spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"
X-Migadu-Queue-Id: A74638F34
X-Spam-Score: -3.99
X-Migadu-Scanner: scn1.migadu.com
X-TUID: WJZJG/A/jwoQ

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

>>>>> On Tue, 14 Jun 2022 13:12:54 +0300, Daniel Fleischer <danflscr@gmail.=
com> said:

    Daniel> Robert Pluim [2022-06-14 Tue 11:28] wrote:
    >> A couple of places in org main quoted symbols in defcustom types, but
    >> the type itself is already quoted, so that=CA=BCs not necessary.

    Daniel> Is it harmful though?

There=CA=BCs the absolutist argument of "it=CA=BCs wrong!", or the practical
argument of "it causes warnings when byte compiling". Take your pick.

    >> -          (const :tag "Overlays" 'overlays)
    >> -          (const :tag "Text properties" 'text-properties)))
    >> +          (const :tag "Overlays" overlays)
    >> +          (cnost :tag "Text properties" text-properties)))

    Daniel> Typo here `cnost`.

Of course there is. Murphy and all that. Updated patch attached

Robert
--=20



--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment;
 filename=0001-Don-t-quote-symbols-in-defcustom-types.patch

>From 2c75a28bff8842f731611ebd7838c5f13122ac4d Mon Sep 17 00:00:00 2001
From: Robert Pluim <rpluim@gmail.com>
Date: Mon, 13 Jun 2022 16:15:10 +0200
Subject: [PATCH] Don't quote symbols in defcustom types

* lisp/org-fold-core.el (org-fold-core-style):
* lisp/org-persist.el (org-persist-remote-files):
(org-persist-default-expiry):
Don't quote the symbol given as value for a const.
---
 lisp/org-fold-core.el | 4 ++--
 lisp/org-persist.el   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/lisp/org-fold-core.el b/lisp/org-fold-core.el
index 5dda133fb..3ba63b725 100644
--- a/lisp/org-fold-core.el
+++ b/lisp/org-fold-core.el
@@ -302,8 +302,8 @@ (defcustom org-fold-core-style 'text-properties
   :group 'org
   :package-version '(Org . "9.6")
   :type '(choice
-          (const :tag "Overlays" 'overlays)
-          (const :tag "Text properties" 'text-properties)))
+          (const :tag "Overlays" overlays)
+          (const :tag "Text properties" text-properties)))
 
 (defvar-local org-fold-core-isearch-open-function #'org-fold-core--isearch-reveal
   "Function used to reveal hidden text found by isearch.
diff --git a/lisp/org-persist.el b/lisp/org-persist.el
index 068f58cec..ab1365220 100644
--- a/lisp/org-persist.el
+++ b/lisp/org-persist.el
@@ -196,7 +196,7 @@ (defcustom org-persist-remote-files 100
   :type '(choice (const :tag "Never" nil)
                  (const :tag "Always" t)
                  (number :tag "Keep not more than X files")
-                 (const :tag "Check if exist on remote" 'check-existence)))
+                 (const :tag "Check if exist on remote" check-existence)))
 
 (defcustom org-persist-default-expiry 30
   "Default expiry condition for persistent data.
@@ -207,7 +207,7 @@ (defcustom org-persist-default-expiry 30
 it should be a function returning non-nil when the data is expired.  The
 function will be called with a single argument - collection."
   :group 'org-persist
-  :type '(choice (const :tag "Never" 'never)
+  :type '(choice (const :tag "Never" never)
                  (const :tag "Always" nil)
                  (number :tag "Keep N days")
                  (function :tag "Function")))
-- 
2.35.1.607.gf01e51a7cf


--=-=-=--