emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Daniel Fleischer <danflscr@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Don't quote symbols in defcustom types
Date: Tue, 14 Jun 2022 12:23:15 +0200	[thread overview]
Message-ID: <874k0nzgq4.fsf@gmail.com> (raw)
In-Reply-To: <m2h74no8nt.fsf@gmail.com> (Daniel Fleischer's message of "Tue, 14 Jun 2022 13:12:54 +0300")

[-- Attachment #1: Type: text/plain, Size: 836 bytes --]

>>>>> On Tue, 14 Jun 2022 13:12:54 +0300, Daniel Fleischer <danflscr@gmail.com> said:

    Daniel> Robert Pluim [2022-06-14 Tue 11:28] wrote:
    >> A couple of places in org main quoted symbols in defcustom types, but
    >> the type itself is already quoted, so thatʼs not necessary.

    Daniel> Is it harmful though?

Thereʼs the absolutist argument of "itʼs wrong!", or the practical
argument of "it causes warnings when byte compiling". Take your pick.

    >> -          (const :tag "Overlays" 'overlays)
    >> -          (const :tag "Text properties" 'text-properties)))
    >> +          (const :tag "Overlays" overlays)
    >> +          (cnost :tag "Text properties" text-properties)))

    Daniel> Typo here `cnost`.

Of course there is. Murphy and all that. Updated patch attached


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Don-t-quote-symbols-in-defcustom-types.patch --]
[-- Type: text/x-diff, Size: 2210 bytes --]

From 2c75a28bff8842f731611ebd7838c5f13122ac4d Mon Sep 17 00:00:00 2001
From: Robert Pluim <rpluim@gmail.com>
Date: Mon, 13 Jun 2022 16:15:10 +0200
Subject: [PATCH] Don't quote symbols in defcustom types

* lisp/org-fold-core.el (org-fold-core-style):
* lisp/org-persist.el (org-persist-remote-files):
Don't quote the symbol given as value for a const.
 lisp/org-fold-core.el | 4 ++--
 lisp/org-persist.el   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/lisp/org-fold-core.el b/lisp/org-fold-core.el
index 5dda133fb..3ba63b725 100644
--- a/lisp/org-fold-core.el
+++ b/lisp/org-fold-core.el
@@ -302,8 +302,8 @@ (defcustom org-fold-core-style 'text-properties
   :group 'org
   :package-version '(Org . "9.6")
   :type '(choice
-          (const :tag "Overlays" 'overlays)
-          (const :tag "Text properties" 'text-properties)))
+          (const :tag "Overlays" overlays)
+          (const :tag "Text properties" text-properties)))
 (defvar-local org-fold-core-isearch-open-function #'org-fold-core--isearch-reveal
   "Function used to reveal hidden text found by isearch.
diff --git a/lisp/org-persist.el b/lisp/org-persist.el
index 068f58cec..ab1365220 100644
--- a/lisp/org-persist.el
+++ b/lisp/org-persist.el
@@ -196,7 +196,7 @@ (defcustom org-persist-remote-files 100
   :type '(choice (const :tag "Never" nil)
                  (const :tag "Always" t)
                  (number :tag "Keep not more than X files")
-                 (const :tag "Check if exist on remote" 'check-existence)))
+                 (const :tag "Check if exist on remote" check-existence)))
 (defcustom org-persist-default-expiry 30
   "Default expiry condition for persistent data.
@@ -207,7 +207,7 @@ (defcustom org-persist-default-expiry 30
 it should be a function returning non-nil when the data is expired.  The
 function will be called with a single argument - collection."
   :group 'org-persist
-  :type '(choice (const :tag "Never" 'never)
+  :type '(choice (const :tag "Never" never)
                  (const :tag "Always" nil)
                  (number :tag "Keep N days")
                  (function :tag "Function")))

  reply	other threads:[~2022-06-14 10:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14  9:28 [PATCH] Don't quote symbols in defcustom types Robert Pluim
2022-06-14 10:12 ` Daniel Fleischer
2022-06-14 10:23   ` Robert Pluim [this message]
2022-06-14 13:06     ` Daniel Fleischer
2022-06-14 14:04       ` Ihor Radchenko
2022-06-14 14:13         ` Robert Pluim
2022-06-14 14:19           ` Ihor Radchenko
2022-06-14 14:21             ` Robert Pluim
2022-06-14 14:27               ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874k0nzgq4.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=danflscr@gmail.com \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).