From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 8JeJEba14GKaWwEAbAwnHQ (envelope-from ) for ; Wed, 27 Jul 2022 05:49:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id ABpsELa14GLYVQAAG6o9tA (envelope-from ) for ; Wed, 27 Jul 2022 05:49:10 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 082B9DBF7 for ; Wed, 27 Jul 2022 05:49:10 +0200 (CEST) Received: from localhost ([::1]:55214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGY2m-0000NJ-Oy for larch@yhetil.org; Tue, 26 Jul 2022 23:49:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43972) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGY2N-0000N8-9w for emacs-orgmode@gnu.org; Tue, 26 Jul 2022 23:48:43 -0400 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]:55245) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oGY2L-0006zB-R9 for emacs-orgmode@gnu.org; Tue, 26 Jul 2022 23:48:43 -0400 Received: by mail-pj1-x1033.google.com with SMTP id y1so7080215pja.4 for ; Tue, 26 Jul 2022 20:48:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=/oIP9ZsLkYj8PrUQYCfMprfqB1NG+j9AMXpIzJXQStg=; b=MTfYeIICvAFJFCPV2IV0cMV4vSj9A1Kl38n30qZp24YUcwNpm/ST2sYcMSgh7epw7G t7lIaxdDgRtcH509TThLqk2B/twQRpXi6NWBeWIHZBnN4FeKr/007gWh1YCBJ8KPoImb tv2pYy/1pYpwaKCxFe/ArzsT/2dKcdbWcx1lD+vW/QOI3LSYNevUvUzmYr67GMBBc+cB 8blC8/Jo1W4Kgm0+vMqEh+Hl2VY1PfOTCzd6oMk9J7ZmryvsnbZcLbcTO6xpAAC8crAH ts0R1fpnjg3LJ0dicT3h5CawcU1K6ZF9cUe+xgaISwOHpx0zPaaFT977w+IDuJCfFdoJ JV0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=/oIP9ZsLkYj8PrUQYCfMprfqB1NG+j9AMXpIzJXQStg=; b=MhwHeSrsMcb9fACowqUtBDDR08/HFEwcBwGAtUJEvX+ikKlZnsks/ZsieLJdMB0KRg k73LthCJ71hCWIruVr89ZxPO8XGUo1Bri6TnVCktWllE1sRNdhKEOpTOiPDfCihRbsFY BcKSOHglSvfq79NmLj1kz/d02CwhxMarB69YY3cuqV8LIltCQr9nf1EIUbV+6JQZW2xw UEDItvWXSRJytgfgwiGWTT6CfTCHvgrwm6LLY4sOROxNS96x+Mb3AvpcaOo5OUh6qWLd mlquc0I/WhVJqyRDgA3aZfiTOqkp7BL5qIYsqsIif2X5GxEwBoPTJkfnEMOJ1CKgmHck LiHg== X-Gm-Message-State: AJIora/hbIEOkrRqjeIRvvEF3uFFLRc3Cx2zdmyjlOg8nNC9v8sKAyEC SKGzOscGODk7PnL6j7WR+QA= X-Google-Smtp-Source: AGRyM1uBAq5Jyp9PBDWme0F2qvK6i3DPc6w6OshvbVIg6zadPuZpG685d2INh4wlljct0S1vJlb8Xw== X-Received: by 2002:a17:90b:3504:b0:1f3:3e1:fc5c with SMTP id ls4-20020a17090b350400b001f303e1fc5cmr2266078pjb.181.1658893720250; Tue, 26 Jul 2022 20:48:40 -0700 (PDT) Received: from localhost ([115.154.175.57]) by smtp.gmail.com with ESMTPSA id x27-20020aa7941b000000b005251f4596f0sm12468897pfo.107.2022.07.26.20.48.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jul 2022 20:48:39 -0700 (PDT) From: Ihor Radchenko To: Max Nikulin Cc: emacs-orgmode@gnu.org, Hugo Heagren Subject: Re: [PATCH] org-test: Run all ol tests on make test In-Reply-To: <218fded4-485e-d34e-4f9e-68f4eff8ae81@gmail.com> References: <218fded4-485e-d34e-4f9e-68f4eff8ae81@gmail.com> Date: Wed, 27 Jul 2022 11:49:44 +0800 Message-ID: <874jz3b4fb.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::1033; envelope-from=yantar92@gmail.com; helo=mail-pj1-x1033.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1658893750; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=/oIP9ZsLkYj8PrUQYCfMprfqB1NG+j9AMXpIzJXQStg=; b=lqBPUHjRKvQnjRxAe9tw/Gfn/qzz58xSrA0kWfObiU0vx39/piNMzYkq3PHhzxOX9PKu4B 9PfIzk/MlQkPWku5mhkue2BcP7112N26O1MA709rfm+pkzrb2l6S/fm+jAVoE8FewT9FLK vp/GnnwICyuiJGpzhv3FnLfBCnGHfC/cMCv3RH1xz2Dy2Jn+Ri+mluSnKlDEG5jBjWJz7L +j3fUHnSSUPmpYAVAtNM9RbCrzrYBWOh/+bPf52fR86vih4tSv1zJvHt+pPMg2fS2jFzF5 LyXDDgaX65yX/0fuJMV8wELE26jJfTmKFlCJceFn4kuGWLm4ImIslsbO2kzWyA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1658893750; a=rsa-sha256; cv=none; b=fwmc49UoFVxtXbBQY/fjAsEf3cuO2e7wcTZlofbWuq+DlGSibzj3x+rpNeG2lOADoVShky vXARCHCr7aMfy1rLOE44KheUg7T7d9TmtXhW9cOthrPXXSNQXxUxhxBhFmbpeiiLypA4PS k/8ZHbb5iMGWjjMaoRLyPIhdbRkTMWQGkEXCAMbGAiCSwLD6aHXkpvlJPCS7CQQqGDPJdL m+J43R0kdr/CLjdKG+CyhB1NEayKU9r1B7AA83wjWecC4sWGEl2nlIRLSsJ7CVfFjVGgxP tdQTB31EjzYenSUL77DSu79flGQ00LXr/gF/tgjj7RFXpTG5ZUZIVII8xdXmww== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=MTfYeIIC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.93 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=MTfYeIIC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 082B9DBF7 X-Spam-Score: -1.93 X-Migadu-Scanner: scn1.migadu.com X-TUID: 3CwjYsB2TGtg Max Nikulin writes: > Hi, > > I figured out why "make test" is passing successfully while the same > with BTEST_RE="test-ol/insert-link-insert-description" is failing for a > proposed patch. Default selection pattern is ignoring most test-ol > cases. See the attachment. Thanks a lot for narrowing this down! > --- a/testing/org-test.el > +++ b/testing/org-test.el > @@ -424,7 +424,7 @@ setting `pp-escape-newlines' to nil manually." > "^\\([^.]\\|\\.\\([^.]\\|\\..\\)\\).*\\.org$"))) > > (defun org-test-run-batch-tests (&optional org-test-selector) > - "Run all tests matching an optional regex which defaults to \"\\(org\\|ob\\)\". > + "Run all tests matching an optional regex which defaults to \"\\(org\\|ob\\|-ol\\)\". > Load all test files first." > (interactive) > (let ((org-id-track-globally t) You missed the (org-test-selector (if org-test-selector org-test-selector "\\(org\\|ob\\)")) inside org-test-run-batch-tests Also, org-test-run-all-tests Best, Ihor