From: Ihor Radchenko <yantar92@gmail.com>
To: Daniel Ortmann <daniel.ortmann@oracle.com>, Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [External] : Re: strange errors with org-element-cache-reset and jit-lock-function void-variable org-element-citation-prefix-re
Date: Fri, 23 Sep 2022 10:07:10 +0800 [thread overview]
Message-ID: <874jwyalo1.fsf@localhost> (raw)
In-Reply-To: <293cb6bc-db03-3c4f-125f-96a84b4d2e8d@oracle.com>
Daniel Ortmann <daniel.ortmann@oracle.com> writes:
> Was Eli Z's observation the key? Of code not autoloading when
> eval-buffer is running?
Yes, it is.
Bastien,
In f36b19eef, you introduced the following code into org.el:
(or (eq this-command 'eval-buffer)
(condition-case nil
(load (concat (file-name-directory load-file-name)
"org-loaddefs.el")
nil t t t)
(error
(message "WARNING: No org-loaddefs.el file could be found from where org.el is loaded.")
(sit-for 3)
(message "You need to run \"make\" or \"make autoloads\" from Org lisp directory")
(sit-for 3))))
The commit message explains why we display warning, but it is unclear
why (eq this-command ...) check is performed.
This check is causing the issue herein. Also, see
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57972
I am leaning towards removing `this-command' check, unless there are
important reasons to keep it.
--
Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92
next prev parent reply other threads:[~2022-09-23 2:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 19:17 strange errors with org-element-cache-reset and jit-lock-function void-variable org-element-citation-prefix-re Daniel Ortmann
2022-09-21 8:37 ` Ihor Radchenko
2022-09-22 18:05 ` [External] : " Daniel Ortmann
2022-09-23 2:07 ` Ihor Radchenko [this message]
2022-09-25 2:44 ` Bastien Guerry
2022-09-25 6:03 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jwyalo1.fsf@localhost \
--to=yantar92@gmail.com \
--cc=bzg@gnu.org \
--cc=daniel.ortmann@oracle.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).