From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id IBo3G/zHL2Ng/AAAbAwnHQ (envelope-from ) for ; Sun, 25 Sep 2022 05:16:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id UFJcGvzHL2NaywAAG6o9tA (envelope-from ) for ; Sun, 25 Sep 2022 05:16:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 15FC7138C0 for ; Sun, 25 Sep 2022 05:16:12 +0200 (CEST) Received: from localhost ([::1]:51644 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ocI7n-0004Jc-2w for larch@yhetil.org; Sat, 24 Sep 2022 23:16:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46960) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocI6d-0004JU-9u for emacs-orgmode@gnu.org; Sat, 24 Sep 2022 23:14:59 -0400 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]:33677) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ocI6b-0006Im-Ji; Sat, 24 Sep 2022 23:14:59 -0400 Received: by mail-pg1-x534.google.com with SMTP id f193so3739445pgc.0; Sat, 24 Sep 2022 20:14:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date; bh=URcwyHnH/NbFvtcS3HK/dKwqHgZ/8dnCs284PWToZ78=; b=NXgvMU15DvKqB5EcwV0Dd/FQhfPFC20q7oGWu+OIRacXC7z0UN/HIHuXHTjyPPTv4K SaOCcQmUzDdhTHRvQHwjsp2weOA/6wtKhOT9KO7A4TVWdeX3nCJaAhA7OT0dtSxnN5uD xEHO3RrwrhMKvaXteg0R+W8mCUvN2WzqtWMpE0YeObuEt3/mlvpJD1NWt+MezutR6W8D 35Xjay0mXPwN3eS9l2sgDxVyPerGhVIXt8jHaCeEuD8/L4aFJ3m0hOXBwgb66Aiz4TBl wZLJhZrWdy7Vnd5WbYrcz0jeUBHKKSCBU+V45DpjBiS1PL4Cl8gVzHylCBFieHb3T2zu oY6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date; bh=URcwyHnH/NbFvtcS3HK/dKwqHgZ/8dnCs284PWToZ78=; b=zgJE1+Pkl8UTN8OZ1UCdydG72Ftvc+mZ8ML+SvjY8xULKdESPSEy21NtLVMip9Wfii 4OG3yCLsmIeVn4si64NQOpLXIYtYK6+g30jXbQhT2VaJiwWkalErPRh8m76CRFa6Jw8V zRWWOkGEvG/T4MbP5fvqzfj5sVlMmhatL9CqNgfFC+vRI+X3WBruty7r1PXt+iFDKkng L+P2AlO6JiSnYBl+Tqdh+6wzr+U+fzojg28RtjEgfU9tT15/hmkIf7spqobEadPeOIyT c9Rswb9CErVfL53wcIicDEBw3/TD/G6s050GcxhMQJaG2WbWMqYhEgFPbpIx46fF4IE4 xHww== X-Gm-Message-State: ACrzQf1WKoi7XjtKoXUqNOuFPWzlX5dGw5cVqJ9HEcu+WZMx3cW8G2Zm 3JxUgAkIeTErwg4CEBTlJt15RfYFnSA= X-Google-Smtp-Source: AMsMyM7HIhpIuyc+gLxbDHhvi4Xi8vbyKrlWCk5gvGuetCB8NNDmiajKBdsVZivIA0cVXF5I24t7Wg== X-Received: by 2002:aa7:8c4f:0:b0:54d:14d5:d0c9 with SMTP id e15-20020aa78c4f000000b0054d14d5d0c9mr16757748pfd.13.1664075695345; Sat, 24 Sep 2022 20:14:55 -0700 (PDT) Received: from localhost ([2409:8970:a80:3a4:8ec6:81ff:fe70:339d]) by smtp.gmail.com with ESMTPSA id l23-20020a17090a071700b002005fcd2cb4sm4085112pjl.2.2022.09.24.20.14.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Sep 2022 20:14:54 -0700 (PDT) From: Ihor Radchenko To: Bastien Cc: Stefan Monnier , emacs-orgmode@gnu.org Subject: Re: org-assert-version considered harmful In-Reply-To: <87o7v4dvon.fsf@gnu.org> References: <875yhsujkq.fsf@localhost> <87h71ct10n.fsf@localhost> <87tu5bbajh.fsf@localhost> <87r10ey8ov.fsf@localhost> <87o7v4dvon.fsf@gnu.org> Date: Sun, 25 Sep 2022 11:15:40 +0800 Message-ID: <874jww16w3.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::534; envelope-from=yantar92@gmail.com; helo=mail-pg1-x534.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1664075772; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=URcwyHnH/NbFvtcS3HK/dKwqHgZ/8dnCs284PWToZ78=; b=dNgOJGLkaTbZ7gLfqbkYITXqy1XzrTHCv0WD8/0qjL1NDgKGp+5BFnGTHsZoVbeSe4jZYi QIitZTiDXEDGNE33SWkmcjtfv6Z9cqD+kArEL5bZUsDTQ9bCuRJP2K6nRUJnZ+UjqD+m6O BLDMm2ggLrvXRgE934AkDMx73PxUCx9iz6Tcx9pbWN8KodSlhYumvCvf17LhZXEr71Nw+6 z750FtpzeAT/7fmFFzXOtrAYe+fNDJlI85yEEALgtxJDFCvIiyRH8PtJ7Y+Ip00+r6vZei IEn4B8KhuSbyCUpqhNK8WR/c0SA6H8sA8X/3JwiZ3p9DKa2Pf9B9j7ai0scZFw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664075772; a=rsa-sha256; cv=none; b=E1uIZo6uY8VkDdnr5lA18S5RWhFIH8k/FfT3FN4dV8p0qdGjSwdd5+OSHXhl+BsHVTjgo5 Oc6UOdUF5FGSqQcOiAP+bWT9O+jfeY6AqyL8MVH9RNPUAXwExWjo/fA4ZiBS7YBGhSeNZt t89rBekVoxSJvhmDSQsOXs5j3OG4C5xBEBVUckW1ywOIntu3wg63hAhkRDYF/NwuuEHVEY hoY67/qMsrFsKBDaYVNJolgh3gTFsrfQzU0ekJCH1CgRZ14LzjUff4AxCojoFmoNk2t0+6 +UWMDmXIuPJeBZiXQ3ZwkgDLz+vFCVz8iZ0NUmLKfXaZj5s8MEj2PgMbJRhyNA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=NXgvMU15; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.85 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=NXgvMU15; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 15FC7138C0 X-Spam-Score: -1.85 X-Migadu-Scanner: scn1.migadu.com X-TUID: LhHjfO9KFM8R Bastien writes: > Ihor Radchenko writes: > >> Then, I am inclined towards easing the version check to (org-version) >> instead of (org-git-version). > > FWIW strong +1 here. There is one more concern we may need to solve prior to changing org-git-version to org-version. Currently, main and bugfix branches both have (org-version) ; => "9.5.5" As a result, the assertion will not catch the important case when users mix Org version installed via package.el and Org version installed from git. Should we use the next planned release version number on main branch as a convention? -- Ihor Radchenko, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https://liberapay.com/org-mode, or support my work at https://liberapay.com/yantar92