From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yLFkEga3XGPoEgAAbAwnHQ (envelope-from ) for ; Sat, 29 Oct 2022 07:15:50 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id WK1MEga3XGO98AAAauVa8A (envelope-from ) for ; Sat, 29 Oct 2022 07:15:50 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1E6CC7DCC for ; Sat, 29 Oct 2022 07:15:50 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooeBE-0005GQ-Nk; Sat, 29 Oct 2022 01:14:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooeBD-0005GE-BD for emacs-orgmode@gnu.org; Sat, 29 Oct 2022 01:14:47 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooeBB-0005nM-CR for emacs-orgmode@gnu.org; Sat, 29 Oct 2022 01:14:47 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id EF588240026 for ; Sat, 29 Oct 2022 07:14:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1667020483; bh=lMFvyB0JaLXnls99HSj8BC7naeQksmArr3U3USms7Nc=; h=From:To:Cc:Subject:Date:From; b=lfSIVDtFxKNjUgWccBI4BMTeTJkLYTXbAA44tY3+4SaVbBxhphOQGvKx7RNphWJPE STnIgyQu3nE3KvNSqRK0uDO/TO68AXbLGMZw2KPLvV18pP6FZKHx6xvUY5pXNraRSl jao2O9wERGff9FYTB2hroS3Y3+ygUDxDv1dTcGnCAmwrHEi3XlGUyjiS0a9IkV3W/S 1d+beaj0MmD8qpNa6x46y5J7bfpYVVklCuJ6wnO1KJb4/5va+RCDd3MSMVJnIHtDS5 DzUR1Ue9eDeOAfvnXdUwoNS9zq2rF9Had/I6BpSLL+Bl4uUNI0yBBgG76acpTMp/+A sO/CRL3a190Xg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Mznf73KY6z6tmR; Sat, 29 Oct 2022 07:14:39 +0200 (CEST) From: Ihor Radchenko To: Alex Giorev Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] two small fixes for org-fast-tag-selection In-Reply-To: References: Date: Sat, 29 Oct 2022 05:15:22 +0000 Message-ID: <874jvnjjmd.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Emacs-orgmode" Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1667020550; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=cCZOMdmkF554U0QF2p9TF2O9U+EOS6jdtQk3P4QyQRw=; b=tmZ4UtemTC33jjA5sPjAIsbhtvUwlRohlGphFqWcQQYDaE3VghnAiDBUiRvgAaLGTMc1vL EnTOcoLbeOJjXuJPBvCtP/SnTvxRtUsFY5BzO4A4HXXLlNWQCrbG3AM3kU6bu2rZ4bBXVW wUNxTTNaBCPTy0VXOqW9DpSiWzm0DPQ4RRCFBqTFmE/wsZpIXfR64MZzfmjH2E+W9UG6Lx q8Gy/M+3h1/1JrKCRQdEzocVfXgfBin7Eet0TdJdNssaO9ApVNkeyXGTXeLXZBXZiTYxjV 44m65fMxhr1K3IPNRCr40hqhyeDOVvA0Zu0gy+cH7ViB+tm2zTaPZELEhiIWYg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1667020550; a=rsa-sha256; cv=none; b=eWSl0/dUSZJ8D3G5uLhVrCnMcmcZ2cjVvW1WBUmEas7keNPRjOx+bSIgIWlP4q+B3sfk6C zJ6f0XqjxM9wMsD2Jko15oHPE+Wct39xGILktTcMm2hNbAAlrtby3QGe76DgLMXVpM7Lpi NSkwBgTP36J6UD/BUNCihMwMoGzr+mkwM9jTbnSjBLe25t5G5qnqMUlVRxFC+438hQWPm+ PRDpYSv3zv2WbonHV6/x7XuM/0cctCwDGweI0rB6TXdA/e2RoufXOFS4U12TRnIGiv+cjs 12bnR8AI6utJgP/B4PkKSoQhIsWZYwzbSQ0aZskeFZfL0Y9DshuGjTuawn/xiw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=lfSIVDtF; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.63 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=lfSIVDtF; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 1E6CC7DCC X-Spam-Score: -3.63 X-Migadu-Scanner: scn1.migadu.com X-TUID: ycuCN2xsSBgP Thanks for the patches, and sorry for the late reply. Alex Giorev writes: > - The first patch fixes the problem of TODO keywords and tags sharing keys > when they are automatically generated and when > `org-fast-tag-selection-include-todo' is set. Could you please show minimal examples that demonstrate the problem you are trying to fix? > - The problem solved by the second patch is the following: when invoking > the fast selection interface, and pressing the key of a tag, the tag is > highlighted to indicate it has been selected, but pressing the key again > doesn't unhighlight it. On my side, the tag does get unenlightened even without the patch (on the latest main). -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at