From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 4KLaEAYEpGRqYAAASxT56A (envelope-from ) for ; Tue, 04 Jul 2023 13:35:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id uD7QEAYEpGQYeAAA9RJhRA (envelope-from ) for ; Tue, 04 Jul 2023 13:35:34 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1280145E3C for ; Tue, 4 Jul 2023 13:35:34 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qGeIs-00085E-MU; Tue, 04 Jul 2023 07:34:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGeIq-00084v-PU for emacs-orgmode@gnu.org; Tue, 04 Jul 2023 07:34:40 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGeIo-00043k-Kz for emacs-orgmode@gnu.org; Tue, 04 Jul 2023 07:34:40 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 97313240028 for ; Tue, 4 Jul 2023 13:34:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1688470476; bh=EZxJO0f+Xpp1LOB/HGeCt5ZPHxwB7KxaeXDJMYOSSik=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=sAOXEAf9B0ZDWh1paUBmGfDoWKZo8Awig6wZOZZRAmEs4gKA5mxtucL7/06ObRhPp iwbmaxHczgZLAwbeqNHNuYV4F4DRBLuUS5qJ74DRDitMSam3qDoUYqLGRZCaRp0A9K woXrvkrg2tvAjZgV47Zr/f42EBk5e5OOSZ3wXIEWUgsFlxMRsWjeQIx5vl0Ah5iWTu 6kZLdt3yXKoKhzz05EWv3You04FZDShBZJm+aVRIz7RCNqIia+tkdxatEmMWB1risq HPXPssN5eXNZ4N/LN7TN9xOC1bftKspHPxbW7UvyQdrbyzY5Mf2gEpzZG0QOJufJh7 6F8ThmFl37GHg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QwLL40zp9z9rxN; Tue, 4 Jul 2023 13:34:36 +0200 (CEST) From: Ihor Radchenko To: Evgenii Klimov Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH v2] lisp/org.el: Add final hooks to S-/M-/S-M-cursor commands In-Reply-To: <877crgwy82.fsf@lipklim.org> References: <873527q5iw.fsf@localhost> <20230701131902.1679-1-eugene.dev@lipklim.org> <87ilb1go5p.fsf@localhost> <877crgwy82.fsf@lipklim.org> Date: Tue, 04 Jul 2023 11:34:35 +0000 Message-ID: <874jmjvrjo.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: 1280145E3C X-Spam-Score: -4.00 X-TUID: 9be/b4spvfrh Evgenii Klimov writes: > Maybe I got it wrong, but I tried to follow the docstring for > `org-metaleft'. And I don't see here the use of the return value either: > > #+begin_example > (defun org-metaleft (&optional _arg) > "... > This function runs the hook `org-metaleft-hook' as a first step, > and returns at first non-nil value." > ...) > #+end_example > Should I keep it like this? > This function runs the hook `org-shiftmetaleft-hook' as a first > step, and `org-shiftmetaleft-final-hook' as the penultimate step. Apparently the original wording is quite confusing. What it is supposed to say is: This function runs the functions in `org-metaleft-hook' one by one as a first step, and exits immediately if a function from the hook returns non-nil. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at