emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kenny Ballou <kb@devnulllabs.io>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: yantar92@gmail.com, emacs-orgmode@gnu.org
Subject: Re: [PATCH] lisp/org-capture.el: use link ID's for %K
Date: Fri, 08 Dec 2023 11:47:29 -0700	[thread overview]
Message-ID: <874jgsa5nh.fsf@devnulllabs.io> (raw)
In-Reply-To: <87a5qkssq6.fsf@localhost>

On 2023-12-08 13:56 GMT, Ihor Radchenko wrote:
> Kenny Ballou <kb@devnulllabs.io> writes:
>> +                  (if org-id-link-to-org-use-id
>> +                      (org-link-make-string
>> +                       (format "id:%s" (org-id-get org-clock-marker))
>> +                       v-k)
> `org-id-link-to-org-use-id' may have a number of non-nil values with
> slightly different behaviour: t, create-if-interactive,
> create-if-interactive-and-no-custom-id, use-existing, nil.
> Your patch will only work as expected for t and nil values, but not for
> others. You may consider leveraging `org-store-link' to account for all
> the possibilities.

This worked for the value of `use-existing', which is how I tested it.
But I see your point, the behavior should be more flexible to the other
values of `org-id-link-to-org-use-id'.

I'm currently struggling through modifying it to work with
`org-store-link'.  Something, save-excursion -> org-clock-goto ->
org-store-link -> org-insert-link is what I'm trying for now, but that's
not quite working.  I'll come back to this in a few hours.

If you have any other specific suggestions I'm missing, please let me
know.  Otherwise, look for a new patch, hopefully soon!


  reply	other threads:[~2023-12-10 15:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-19 13:26 Org-capture %K "Link to the currently clocked task" link with id? Nathaniel W Griswold
2021-05-19 17:29 ` Nathaniel W Griswold
2021-05-24 12:25   ` Nathaniel W Griswold
2021-05-29  8:10     ` Ihor Radchenko
2023-12-07 18:53       ` [PATCH] lisp/org-capture.el: use link ID's for %K Kenny Ballou
2023-12-08 13:56         ` Ihor Radchenko
2023-12-08 18:47           ` Kenny Ballou [this message]
2023-12-08 19:01             ` Ihor Radchenko
2023-12-09 22:53               ` Kenny Ballou
2023-12-10 12:19                 ` Ihor Radchenko
2023-12-11 15:33                   ` Kenny Ballou
2023-12-11 15:46                   ` Kenny Ballou
     [not found]                   ` <20231211154357.23020-1-kb@devnulllabs.io>
     [not found]                     ` <87ttoo7dna.fsf@localhost>
2023-12-11 21:21                       ` Kenny Ballou
2023-12-12  4:13                         ` [PATCH] lisp/org-capture.el: use `org-store-link' for %K values Kenny Ballou
2023-12-12  4:32                           ` Kenny Ballou
2023-12-12  4:32                             ` [PATCH] lisp/org-capture.el: use `org-store-link' for %K values Kenny Ballou
2023-12-12 12:46                               ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874jgsa5nh.fsf@devnulllabs.io \
    --to=kb@devnulllabs.io \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@gmail.com \
    --cc=yantar92@posteo.net \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).