From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:700:3204::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id ID81Am+6lmWVNwAAkFu2QA (envelope-from ) for ; Thu, 04 Jan 2024 15:02:23 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 8JyzN266lmW+YQAAe85BDQ (envelope-from ) for ; Thu, 04 Jan 2024 15:02:23 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=b+BYq4yX; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1704376942; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=EDtoXXfe4yDnt62y9NpGG9ZNZhlVOEPZtf0VXAtESRQ=; b=jgyjkEvAw4jPAnZMyETNBtbIOy4p5Tdd/ivZSgSYRrIvtVCskFcvhNwz+42oRQcnik1yuQ 1H55wLEUr3t6u8xCc/8jhQJwUD1C2VFQeUQbprK4ihXRjT9jozIIONX6Qz7nX7MgxpHGvD vQi10l78RsAEgUXFXC3uZbLe+qNfwavBIFlSuT6imdCe7ihvrWAmC99mOCSdc1/tt6NTE8 brnbpA91DHqAqibW3P5Fa5k331YFz3qf1teg0Llf2xE5VdXQulJNMqjZHTuLthPIyWD0lC gytC5VmL1NYAuQba72jVjeuuhI0duxnUHBk73oHXHsZxDbW1SgFl/VbxyC+lpQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=b+BYq4yX; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1704376942; a=rsa-sha256; cv=none; b=ON/0HGhIaI43qVH3aGbpTcUyxr/lTyVATCbBGmvRBO/n7TiKSAT/cAM9bz9hx/g40d0+dM eHq3YP+HhBs9gtZab54oluelHCJUYQRRKtduVL4hkmKcdq2SltPO6wApQCB0wOsL/cTNGk wTFFSzhN3Udg2Ie5YdjmknkBm+SN/codT+xOFfRVDc/lbfWCnAbjjF6glP6KkXMc2wIAMk XitsbGi07OTTNX2W/lmM54W4BDCih5NQ9lqW0EJobwPFtzeeOiyOv7TRGZf+2wUW6k6ei3 Iz2NHBhgyERmjXspmBLpDuU/rMfIYOixSP0HDJC0GDrPgbDATB5J1uWi2ha5Ew== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 845E957CA8 for ; Thu, 4 Jan 2024 15:02:22 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rLOHz-0007yk-V1; Thu, 04 Jan 2024 09:01:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLOHx-0007sq-2h for emacs-orgmode@gnu.org; Thu, 04 Jan 2024 09:01:37 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLOHu-0003WX-Ra for emacs-orgmode@gnu.org; Thu, 04 Jan 2024 09:01:36 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 1B136240029 for ; Thu, 4 Jan 2024 15:01:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1704376889; bh=zPeGz9C7HbFufMmpbeeoaSwugFU92ASBPGC6nA2DkPk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=b+BYq4yXMjBb6NBMPGOg294zATHhjW1lqHqJB1Si1YppZ6DxCJmfazo6OZg4W3KNy 4SaWMq0eZx2Ijfz90OqQ87vB2lMc2ermExFgcBEFalGjllf9dDptIxkb1o2IlzZ0pZ xgcWhNnhAqWmcfkuzIJerY8ybwxJA6ltk77+zrvUQDsHUYtzAyYs2v0NdRc07bFUTj UC3tywjXpoYQZzGkL7JgOmsFd3kYEdGg/cd+ZT8j1SaRlVLSZmqeL/0Srp41+KAPBN sD+Df2/Lk5xeBFvlRVBzyAffGUk/zmtskGS+LB3wS44wNKWNcAZm3KEVi3mCmRua8k pAHFjAnaWAOZw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4T5Stb6qdFz9rxQ; Thu, 4 Jan 2024 15:01:27 +0100 (CET) From: Ihor Radchenko To: Morgan Smith , Bastien Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] Fix org-agenda-skip-scheduled-if-deadline-is-shown bug In-Reply-To: References: <87wmsu788v.fsf@localhost> <87sf3e77v4.fsf@localhost> Date: Thu, 04 Jan 2024 14:04:40 +0000 Message-ID: <874jft6vpj.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -4.17 X-Spam-Score: -4.17 X-Migadu-Queue-Id: 845E957CA8 X-TUID: 2vI0FxAT7dO3 [CCing Bastien] Morgan Smith writes: >> I think that you misunderstand the purpose of 'repeated-after-deadline >> value. Let me provide an example: >> >> 'repeated-after-deadline allows this task >> >> * Do me every day before March, 16th (included) >> SCHEDULED: <2013-03-12 mar. +1d> DEADLINE: <2013-03-16 sam.> >> >> to step being displayed after March, 16th. > > In my above example I have a task with a deadline of March 10th. > My test shows that it will continue to be scheduled after March 10th, on > the 12th. That is wrong. It is still scheduled on the 10th which is > good. Being scheduled on the 12th is wrong. Right. This is because after 72c3f5e8e refactoring, `org-agenda-skip-scheduled-if-deadline-is-shown' is only respected when the deadline is actually shown. However, judging from the discussion of the original feature request (https://list.orgmode.org/CAC10T-n8F+Evxf7vGcMT48R5ovoDy030AV1Cj3XyX02piF0tEQ@mail.gmail.com/T/#u), it looks like the purpose of 'repeated-after-deadline value is broader than just hiding scheduled record when the deadline record is actually in agenda. AFAIU, the purpose is hiding the scheduled information completely and unconditionally once the agenda day is beyond the deadline. But then `org-agenda-skip-scheduled-if-deadline-is-shown' does not look like the right place for this customization. It would make more sense to have a dedicated custom variable for this. WDYT? I am adding Bastien to the loop - he authored the original feature implementation. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at