From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id mPr3EDKkbWYgFwEAe85BDQ:P1 (envelope-from ) for ; Sat, 15 Jun 2024 14:24:50 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id mPr3EDKkbWYgFwEAe85BDQ (envelope-from ) for ; Sat, 15 Jun 2024 16:24:50 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=co9hzW7U; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1718461490; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Oi+4nGeoJVfEFsu0YOX3LoPog29UuuS4yzMJDwEHHXY=; b=Fk9DQWWof3ZQQ80fpDekqpFs1eO/k3K9CI6qOYY7whPRopvHoJQ9/Rgyij/fb7cJCZIHeR 0Fo+GomPlkETefP+7tLnybDH4b688tPO+92WBVSmmP4FZP9kSqJf2SFi2sAW1QDjO7NWzv k3PBa5KXB5x+NFzDG4IvyUR5xEV04FjjKAVq7cFFj+NoLmagliuczZ7TjIrJaBn7o++Q00 pzyaSNwGyfsVTgC15qv6UwL4dbtaEKxM4DMHrpYS/gj7skChGlYWv2zZcwywZxl1zD9nex bkdx/nmiO9SA3gRX9UJAJH1dthDEHeNOxQzDsI3FMQDD7NBt0yIhkB8sR4uhOw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=co9hzW7U; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1718461490; a=rsa-sha256; cv=none; b=JEqQVedDtJTy1nBUHkhdoaUK9ifEmXPgI0Mvft+Yn3Rdwn5KHncHsAw02rpsa02rv4RgAV NTsYMOCm0DswKqA9f1mWOfLB6cJ8M8scqpOCc8F0DuUaVtANOLaXGKh4CBhn3LbvQkiwdc /toPK6dkI6t5U6mLnUuBwFbSftXG6uwy6Gu2IfGhgk541v3dhycbtZDzlkfje9qq9+3SPe 8EvF3sbpGRKwJDoqMXOjWtwpPo6nTSHWJCiCllKUDOgkqAJk0gB49eldJ3ZJoyBO8fqZuH aYfg8SXDYDSI8bosK1u7ofnAG2LESuK9r0eaHz0hZMbzlXDEu+I41xBn4ZTXJg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2E746D584 for ; Sat, 15 Jun 2024 16:24:49 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sIUK5-0008Ho-7k; Sat, 15 Jun 2024 10:24:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIUK2-0008H5-TF for emacs-orgmode@gnu.org; Sat, 15 Jun 2024 10:24:02 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIUK0-0007xq-Nk for emacs-orgmode@gnu.org; Sat, 15 Jun 2024 10:24:02 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 49564240029 for ; Sat, 15 Jun 2024 16:23:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1718461438; bh=im5vkq+xt8RhE2WiNH6vTVWKk9uDWvLc+dIQFgKFQCE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=co9hzW7UOIubzAxYmO9UCHqSy0aVtszxNge1Ae2rRQw6nLHIyQOXWib6bIvqMS6tm 8ejhfT2TLDFIM2kEIYtXuPRCvtItDWU44CRg7JUCcfBazYTZ4WfdF69izxpxivu+M4 j8a4/B0uGP8q3DQ1JEN/Qdj1Ad/FXDaKFNTXwFWf28/TlUar+VUXwnzPp6FkmG9dSZ HjDRAxD8fqdIeE2lOotWnvXcOZiLhJVn+PccsCei9o88CU5VgdKoxa9XWO4UCTc9Ax ERd2N/iofIpxcnGN5KGZV3F/yxXLHtceH0YREJl8zIamzcLRvjRfZVfL3PNxrvxPYl MNno2XMwVu7xw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4W1dgK69fqz9rxB; Sat, 15 Jun 2024 16:23:57 +0200 (CEST) From: Ihor Radchenko To: Morgan Smith Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] lisp/org.el: Add ability to sort tags by hierarchy In-Reply-To: References: Date: Sat, 15 Jun 2024 14:25:40 +0000 Message-ID: <874j9ugu57.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -9.57 X-Migadu-Queue-Id: 2E746D584 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -9.57 X-TUID: nYlDe0YHjz5Q Morgan Smith writes: > * lisp/org.el (org-tags-sort-hierarchy): New function. > (org-tags-sort-function): Add new function to type. > * testing/lisp/test-org.el (test-org/tags-sort-hierarchy): New test > --- > > This is one of those things that I thought would be easy but then ended up > hard. > > I wrote this so that items in my agenda would sort nicely. Items tagged in the > same hierarchy would end up next to each other. > + "Sort tags TAG1 and TAG2 by the tag hierarchy. > +Sorting is done alphabetically. This function is intended to be a value > +of `org-tags-sort-function'." Thanks for the patch, but may you please elaborate what kind of sorting order does your function imply? In particular, I am wondering about the ordering of tags from different groups? Also, what happens when there are no tag groups defined? (These questions should be answered in the docstring and the etc/ORG-NEWS entry you need to add, announcing the new feature) Also, sorting may not be alphabetical, depending on the value of `org-sort-function'. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at