From: Ihor Radchenko <yantar92@posteo.net>
To: Joseph Turner <joseph@breatheoutbreathe.in>
Cc: Org Mode Mailing List <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] lisp/org.el: Fix removing timestamp overlays
Date: Sun, 01 Sep 2024 14:55:55 +0000 [thread overview]
Message-ID: <874j6zqv7o.fsf@localhost> (raw)
In-Reply-To: <87y14j7u51.fsf@breatheoutbreathe.in>
Joseph Turner <joseph@breatheoutbreathe.in> writes:
> Subject: [PATCH] lisp/org.el: Fix removing timestamp overlays
Thanks, although I believe that we can fix things even better.
(If I understand the problem you are trying to solve correctly; just in
case, please explain what you are trying to solve ;])
> (when (and (get-text-property p 'display)
> - (eq (get-text-property p 'face) 'org-date))
> + (memq 'org-date (ensure-list (get-text-property p 'face))))
Rather than relying upon fontification settings, we may modify
`org-display-custom-time' to put a special text property to mark the
overlayed timestamps. Then, searching for that property will give
reliable info on what is and what is not a time overlay.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
prev parent reply other threads:[~2024-09-01 14:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 4:22 [PATCH] lisp/org.el: Fix removing timestamp overlays Joseph Turner
2024-08-26 5:03 ` Joseph Turner
2024-09-01 14:55 ` Ihor Radchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874j6zqv7o.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=joseph@breatheoutbreathe.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).