From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id SJ2dMWfI6WaRTgEAqHPOHw:P1 (envelope-from ) for ; Tue, 17 Sep 2024 18:20:23 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id SJ2dMWfI6WaRTgEAqHPOHw (envelope-from ) for ; Tue, 17 Sep 2024 20:20:23 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=ice9.digital header.s=gm1 header.b=kR+VTc1I; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1726597223; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Hf+//pnERCJpSMJY3TPTiBcdTsBJWvZU/x/zUy0jsUs=; b=s0lN4o5tnxvZyDuywAlaJrQuqPB4mrZHw4g2OQL+OfuplJ/wjuBZPVDGdQTx4J2XesKO9l G9lRezrwW+7HZ38KVLofRaIIjqpNfUKTAfDQvVmq8dH5CWbipA8T7Wisk16ym9IfywRJgN c1BGs/TS4c6f9jSRcidYoICEI5zeW9oUe531SMf+3f79e8kdYWvWhSrdOHZl1RzJRNznxe P8OycPiLhn0HSgs9aLC5lA3q23tLXgDvyjTPksSE+dZBF+DLeR66D2/HTiMqtbxOfeRnK7 JyQXfInqe1TZ8ARK6+IiWW4jFADE9xM4yByTjz3R7SDIc42IQDnfCuJAAQUszQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=ice9.digital header.s=gm1 header.b=kR+VTc1I; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1726597223; a=rsa-sha256; cv=none; b=W+CWoQpGPuS8EhvnM30CLb2IHUrSyN5cum4H8IvIqZPslswUC6cIkgf0hJAhMMLzv5AMPt EOgeI62QR7a8o3aIj26T2zC7D/eFycb7/j2mvvc3FWsutw0T1RzloinTzohytdkpeGMpLN dUX/NrCRj+1DZ+pd834sQUd2XDapc+SSy0t31YAXMdCAyUnsdB5vngKDhKDexU72TtGbqQ acPwcXFMqfyGonhShCi0OiWDUV8NpnfR4SjSCd3/vNZlVB+2HLgSJo8fRgIJJtzigMAfHk yLexLv4I/ZfKFCTvYfI0v7JWZusLmL/HoITQbqroVY2uO6bOcv+RUEIFJ1fByQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6A1E9868E for ; Tue, 17 Sep 2024 20:20:23 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqcjx-0007T4-CX; Tue, 17 Sep 2024 14:15:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqciA-0006z0-ET for emacs-orgmode@gnu.org; Tue, 17 Sep 2024 14:14:05 -0400 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqci8-0002zN-7z for emacs-orgmode@gnu.org; Tue, 17 Sep 2024 14:14:02 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 731991C0003; Tue, 17 Sep 2024 18:13:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ice9.digital; s=gm1; t=1726596834; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Hf+//pnERCJpSMJY3TPTiBcdTsBJWvZU/x/zUy0jsUs=; b=kR+VTc1IswzyhQUkFGwU87T4eVYi3Op32YiBLtX5UgsK/MInuKQICymsN1ls9b11r7VLIe RT4fyHZbav9DM6Ey8Q6xQqZhK/20WqlS0uHomWL+xbbwQxKhuX89OxTlqnj+TT0i6Wgl5A LigM0LWqLGQtfxRSH6S4biwyCZdNI/0VNQ58XKbMYxwK51vHpKbfffskjG+QmTZl9nV3c9 BjeO1oK2g222UV/V3W/hnAA0C9/NlAxv9lCTrfL/xfZdRP6XSTZh9SRt65sQH+wi0yE5nX E6ub0xFHMEh6AUCf54Y8ZUNwSpEX2JjUNVJGvCYFcrndPc0JsNiXEQ3wc4q8Ng== From: Morgan Willcock To: Ihor Radchenko Cc: Lin Jian , emacs-orgmode@gnu.org Subject: Re: [BUG] What about excluding .dir-locals.el from GNU ELPA tarball? In-Reply-To: <87zfo7mmjb.fsf@localhost> (Ihor Radchenko's message of "Mon, 16 Sep 2024 19:22:16 +0000") References: <87bk0p72bi.fsf@localhost> <87tteg26rs.fsf@ice9.digital> <87zfo7mmjb.fsf@localhost> Date: Tue, 17 Sep 2024 19:13:52 +0100 Message-ID: <874j6e87xb.fsf@ice9.digital> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-GND-Sasl: morgan@ice9.digital Received-SPF: pass client-ip=2001:4b98:dc4:8::225; envelope-from=morgan@ice9.digital; helo=relay5-d.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -4.21 X-Spam-Score: -4.21 X-Migadu-Queue-Id: 6A1E9868E X-Migadu-Scanner: mx10.migadu.com X-TUID: uyIzz7DLeBPq --=-=-= Content-Type: text/plain Ihor Radchenko writes: >> I believe it is up to the file to opt-out of compilation. > > That's true, but .dir-locals is a special file. So, I expected Emacs to > treat it specially during compilation as well. To not break old, > no-longer-maintained packages, if nothing. I guess the counter argument would be that, if this file doesn't need to compiled, and the error is that compilation of this file fails, then it isn't a critical error. >> If the file is created with add-dir-local-variable there is a boiler >> plate header inserted which opts out: >> >> ;;; Directory Local Variables -*- no-byte-compile: t -*- >> ;;; For more information see (info "(emacs) Directory Variables") >> ... >> ... The solution would be to add >> the missing header to the .dir-locals.el file. > > I do not see any downside of adding this to .dir-locals.el file. > Would you mind submitting a patch? I've attached a patch. (To be fully transparent, I have not verified that applying the patch will prevent errors during native compilation of the ELPA package, but I am pretty confident that the change is a correct one.) -- Morgan Willcock --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-.dir-locals.el-Disable-compilation-of-.dir-locals.el.patch >From 18e55680191e2c803b731750643d3e854134f1a5 Mon Sep 17 00:00:00 2001 From: Morgan Willcock Date: Tue, 17 Sep 2024 18:09:08 +0100 Subject: [PATCH] .dir-locals.el: Disable compilation of .dir-locals.el * .dir-locals.el (org-mode): Add 'no-byte-compile'. --- .dir-locals.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.dir-locals.el b/.dir-locals.el index 9df10dfed..551a831f7 100644 --- a/.dir-locals.el +++ b/.dir-locals.el @@ -1,4 +1,4 @@ -;;; Directory Local Variables +;;; Directory Local Variables -*- no-byte-compile: t -*- ;;; For more information see (info "(emacs) Directory Variables") ((nil -- 2.39.5 --=-=-=--