Feedback about the usage of org-store-link-props

Feedback about the usage of org-store-link-props

[Sébastien Gendre]

[-- Attachment #1: Type: text/plain, Size: 533 bytes --]

Hello,

Recently, I have written a modification on Elfeed to fix it's usage of
`org-store-link-props`.

https://github.com/skeeto/elfeed/pull/533

Christopher Wellons, the author of Elfeed, would like to have some
feedback about how I used `org-store-link-props`. As Christopher have never used
Org-mode, he don't know if my code is correct.

The first message of the Pull Request describe the full problem I tried
to fix and how I fixed it.


What do you think ?


Best regards

-------
Gendre Sébastien


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 849 bytes --]

Re: Feedback about the usage of org-store-link-props

[Ihor Radchenko]

Sébastien Gendre <seb@k-7.ch> writes:

> Recently, I have written a modification on Elfeed to fix it's usage of
> `org-store-link-props`.
>
> https://github.com/skeeto/elfeed/pull/533
>
> Christopher Wellons, the author of Elfeed, would like to have some
> feedback about how I used `org-store-link-props`. As Christopher have never used
> Org-mode, he don't know if my code is correct.

LGTM other than a couple of typos (see my comments on github).

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>