emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: "Sébastien Gendre" <seb@k-7.ch>
Cc: org-mode-email <emacs-orgmode@gnu.org>
Subject: Re: Feedback about the usage of org-store-link-props
Date: Wed, 25 Dec 2024 12:30:18 +0000	[thread overview]
Message-ID: <874j2s0wth.fsf@localhost> (raw)
In-Reply-To: <87frn99i6w.fsf@k-7.ch>

Sébastien Gendre <seb@k-7.ch> writes:

> Recently, I have written a modification on Elfeed to fix it's usage of
> `org-store-link-props`.
>
> https://github.com/skeeto/elfeed/pull/533
>
> Christopher Wellons, the author of Elfeed, would like to have some
> feedback about how I used `org-store-link-props`. As Christopher have never used
> Org-mode, he don't know if my code is correct.

LGTM other than a couple of typos (see my comments on github).

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


      reply	other threads:[~2024-12-25 12:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-30  9:36 Feedback about the usage of org-store-link-props Sébastien Gendre
2024-12-25 12:30 ` Ihor Radchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874j2s0wth.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=seb@k-7.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).