From mboxrd@z Thu Jan 1 00:00:00 1970 From: Phil Jackson Subject: Re: org-bookmark.el Date: Thu, 28 Feb 2008 20:53:46 +0000 Message-ID: <873arciyzp.fsf@shellarchive.co.uk> References: <87ir0ajrol.fsf@bzg.ath.cx> <87fxvdi0kq.fsf@bzg.ath.cx> <87ejaxhxwl.fsf@shellarchive.co.uk> <87y794n9fy.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JUplK-0004yL-SA for emacs-orgmode@gnu.org; Thu, 28 Feb 2008 15:53:54 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JUplI-0004x5-9W for emacs-orgmode@gnu.org; Thu, 28 Feb 2008 15:53:54 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JUplI-0004wr-2Z for emacs-orgmode@gnu.org; Thu, 28 Feb 2008 15:53:52 -0500 Received: from a.painless.aaisp.net.uk ([81.187.30.51]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JUplH-0003aV-TM for emacs-orgmode@gnu.org; Thu, 28 Feb 2008 15:53:52 -0500 In-Reply-To: <87y794n9fy.fsf@bzg.ath.cx> (Bastien's message of "Thu, 28 Feb 2008 19:54:25 +0000") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: Tokuya Kameshima , emacs-orgmode@gnu.org Bastien writes: >> I don't think it needs to go into org.el does it? When org-bookmark gets >> it's turn upon `org-store-link' it should check a variable called, for >> example, `org-bookmark-check-bookmarks-first' and then if that's non-nil >> check major-mode and act accordingly. This will keep `org-store-link' >> nice and clean. > Of course, you're right. > > But I doubt whether `org-bookmark-check-bookmarks-first' would be > useful here. People using `org-bookmark.el' are likely to use it in > dired-mode and in buffer visiting files as well. Actually, I would > use it just for that (not really for creating links from the bookmarks > list.) I don't think that just through the act of loading a module the unrelated default behaviour should change. I would put a vote in for this behaviour to be off by default (but then I don't use bookmarks). Cheers, Phil -- Phil Jackson http://www.shellarchive.co.uk