emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Sebastian Rose <sebastian_rose@gmx.de>
To: Rustom Mody <rustompmody@gmail.com>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: Some css issues in org-export
Date: Mon, 02 Feb 2009 10:33:14 +0100	[thread overview]
Message-ID: <873aexnpyd.fsf@kassiopeya.MSHEIMNETZ> (raw)
In-Reply-To: <f46c52560902020020i1ea8ee8dgf902b6d2adf2207d@mail.gmail.com> (Rustom Mody's message of "Mon, 2 Feb 2009 13:50:00 +0530")

[-- Attachment #1: Type: text/plain, Size: 156 bytes --]

Hi,



This solves the problem with the <div> inside a <p>. That <div> is only
created when images are included using `org-export-html-format-image'. 






[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 4299 bytes --]

diff --git a/lisp/org-exp.el b/lisp/org-exp.el
index 760c83f..4f035a4 100644
--- a/lisp/org-exp.el
+++ b/lisp/org-exp.el
@@ -3638,8 +3638,10 @@ lang=\"%s\" xml:lang=\"%s\">
                           (and org-export-html-inline-images (not descp)))
                       (org-file-image-p
                        path org-export-html-inline-image-extensions))
+                       (progn
+                       (org-close-par-maybe)
                  (setq rpl (org-export-html-format-image
-                            (concat type ":" path)))
+                            (concat type ":" path))))
                (setq link (concat type ":" path))
                (setq rpl (concat "<a href=\""
                                  (org-export-html-format-href link)
@@ -3706,7 +3708,9 @@ lang=\"%s\" xml:lang=\"%s\">
                                   (or (eq t org-export-html-inline-images)
                                       (and org-export-html-inline-images
                                            (not descp))))
-                             (org-export-html-format-image thefile)
+                             (progn
+                               (org-close-par-maybe)
+                             (org-export-html-format-image thefile))
                            (concat "<a href=\"" thefile "\"" attr ">"
                                    (org-export-html-format-desc desc)
                                    "</a>")))
</#part>



Regards,



Rustom Mody <rustompmody@gmail.com> writes:
> I tried validating this at http://validator.w3.org/
> and its not valid XHTML.
>
> Dont know more HTML to comment :-)
>
>
> On Mon, Jan 19, 2009 at 8:43 PM, Sebastian Rose <sebastian_rose@gmx.de> wrote:
>> Hi Rustom,
>>
>>
>> "Rustom Mody" <rustompmody@gmail.com> writes:
>>> On Mon, Jan 19, 2009 at 6:29 PM, Sebastian Rose <sebastian_rose@gmx.de> wrote:
>>>>
>>>> Hm - we do not provide a special stylesheet for printing. But since
>>> <snipped>
>>>>
>>>> Maybe we should add this line to the very top of the document:
>>>>
>>>> <?xml version="1.0" encoding="utf-8" ?>
>>>
>>> I tried adding this by hand (using emacs) it made no difference to the printout
>>> The boxes show the digits like this:
>>>
>>> 0 0
>>> 2 0
>>>
>>> Also I noticed that emacs shows (Unix) in the modeline but it shows
>>> ^Ms at EOLs in the buffer.
>>>
>>> I understand too little of unicode etc to even claim that this is
>>> 'not-as-it-should-be' -- just mentioning it in case it gives any
>>> clues...
>>
>>
>> Hmmm. In the modeline I have either an `U' (for utf-8) or `1' or
>> iso-8859-1 and other single byte encodings. OrgMode seems to set the
>> charset correctly on export here. If I do a `save file as' in Firefox
>> and open it in emacs, I see the encoding is exactly what's in the line
>> with the `charset'.  You should change the `utf-8' to what's in that line
>> with the `charset':
>>
>>   <meta http-equiv="Content-Type" content="text/html;charset=iso-8859-1"/>
>>
>> in case of
>> http://orgmode.org/worg/org-tutorials/org-custom-agenda-commands.php.
>>
>>
>> If you add the `<?xml....' line, make shure that
>>   a) the encoding is the same as the one in the `charset' line and
>>   b) the file is indeed written to disk using that encoding. See
>>      `C-h k C-x RET f' or ust do `C-x RET f TAB TAB'.
>>
>>
>>
>> Anyway, I believe it's a question of your browsers configuration since
>> no one else has that problem.
>>
>>
>>
>> The line endings have nothing to do with encoding. Their bit-wise
>> representation is the same for all single byte encodings and utf-8.
>>
>>
>>
>> Good luck,
>>
>>
>>
>> --
>> Sebastian Rose, EMMA STIL - mediendesign, Niemeyerstr.6, 30449 Hannover
>> Tel.:  +49 (0)511 - 36 58 472
>> Fax:   +49 (0)1805 - 233633 - 11044
>> mobil: +49 (0)173 - 83 93 417
>> Http:  www.emma-stil.de
>>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>

-- 
Sebastian Rose, EMMA STIL - mediendesign, Niemeyerstr.6, 30449 Hannover
Tel.:  +49 (0)511 - 36 58 472
Fax:   +49 (0)1805 - 233633 - 11044
mobil: +49 (0)173 - 83 93 417
Email: s.rose@emma-stil.de, sebastian_rose@gmx.de
Http:  www.emma-stil.de

[-- Attachment #3: Type: text/plain, Size: 204 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

  parent reply	other threads:[~2009-02-02  9:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-19 12:04 Some css issues in org-export Rustom Mody
2009-01-19 12:27 ` Giovanni Ridolfi
2009-01-19 12:59   ` Sebastian Rose
2009-01-19 13:57     ` Rustom Mody
2009-01-19 15:13       ` Sebastian Rose
2009-02-02  8:20         ` Rustom Mody
2009-02-02  9:15           ` Sebastian Rose
2009-02-02  9:33           ` Sebastian Rose [this message]
2009-02-02 10:02             ` Rustom Mody
2009-02-02 11:09               ` Sebastian Rose
2009-02-02 11:20             ` Carsten Dominik
2009-02-02 12:03               ` Sebastian Rose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=873aexnpyd.fsf@kassiopeya.MSHEIMNETZ \
    --to=sebastian_rose@gmx.de \
    --cc=emacs-orgmode@gnu.org \
    --cc=rustompmody@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).