From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Eric Schulte" Subject: Re: [babel] [PATCH] Date: Tue, 01 Mar 2011 10:06:33 -0700 Message-ID: <8739n668n6.fsf@gmail.com> References: <87y6548bqd.fsf@btinternet.com> <87mxlhyw4f.fsf@gmail.com> <8739n7j24f.fsf@btinternet.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from [140.186.70.92] (port=53907 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PuTny-0007ce-Qa for emacs-orgmode@gnu.org; Tue, 01 Mar 2011 12:56:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PuTnx-0001dJ-AB for emacs-orgmode@gnu.org; Tue, 01 Mar 2011 12:56:14 -0500 Received: from mail-gy0-f169.google.com ([209.85.160.169]:52051) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PuTnx-0001bO-6Y for emacs-orgmode@gnu.org; Tue, 01 Mar 2011 12:56:13 -0500 Received: by mail-gy0-f169.google.com with SMTP id 13so2608475gyb.0 for ; Tue, 01 Mar 2011 09:56:12 -0800 (PST) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Martyn Jago Cc: emacs-orgmode@gnu.org Martyn Jago writes: > "Eric Schulte" writes: > > Hi Eric > >> Hi Martyn, >> >> Thanks for this patch and for the very nice test file, I've just applied >> it along with a related patch in org-exp-blocks.el. >> >> Even with the patch applied I am still seeing undesirable behavior when >> exporting the test file. I believe this is due to upstream processing >> of the blocks by the rest of org-mode, as the buffer *after* org-mode >> processing looks like this [1] >> >> Thanks -- Eric >> > > Thanks. That works great. One thing - I'm not seeing any undesirable > behaviour that you mentioned - am I missing something? > I don't have time to test this out again right now, but if you see no smoke, I'm happy to call no fire. :) > >> git format-patch -o ~/Desktop/ HEAD~1 > > Thanks for the tip - also, apologies for the 'too short' title (hope I > didn't start anything ;) - I'm still getting used to gnus! > > One other thing, I've just been trying to get the tests running, and > most of them are, but the noweb test is failing and I don't understand > why. Has the noweb argument changed in any way... > > This doesn't expand on export to html and therefore fails the tests... > I don't believe that there have been any recent changes to the noweb syntax, and the example below should indeed expand---and does for me when interactively evaluated. I'm not sure what needs to be changed for the test to pass... Also, I'm really pleased that you are looking into the test suite. I do believe that a well maintained test suite would be a huge boon, both for Babel and for Org-mode at large, however, recently I have only had enough time to respond to issues raised on the mailing list, and haven't had the time needed to maintain the test suite---I know, I should be responding to mailing list issues by writing tests for all of the new development, but it hasn't yet integrated into my work flow. Best -- Eric > > > #+source: noweb-example > #+begin_src emacs-lisp > (message "expanded") > #+end_src > > #+begin_src emacs-lisp :noweb yes > ;; noweb-yes-start > <> > ;; noweb-yes-end > #+end_src > > > Regards > > Martyn > >> >> will output a patch file to your desktop holding your last committed >> change. This would allow me to more easily apply your patches, and will >> ensure that you get authorship credit in the git logs. >> >> Martyn Jago writes: >> >>> Hi Babel > > [...] > >>> _______________________________________________ >>> Emacs-orgmode mailing list >>> Please use `Reply All' to send replies to the list. >>> Emacs-orgmode@gnu.org >>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode >> >> Footnotes: >> [1] buffer *after* org-mode processing >> ,---- >> | ** new block regexp tests >> | *** Block 1 (Exports OK) >> | >> | #+BEGIN_SRC sh :tangle test-out >> | Block 1 >> | #+END_SRC >> | >> | *** Block 2 (Exports OK - double blank line no white-space in Block) >> | >> | #+BEGIN_SRC sh :tangle test-out >> | >> | >> | #+END_SRC >> | >> | *** Block 3 (Fails - single blank line no white-space in Block) >> | >> | #+BEGIN_SRC sh :tangle test-out >> | >> | #+END_SRC >> | >> | *** Block 4 (Gets consumed by previous Block) >> | >> | #+BEGIN_SRC sh :tangle test-out >> | Block 4 >> | #+END_SRC >> | >> | *** Block 5 (Fails - no lines in Block) >> | >> | #+BEGIN_SRC sh :tangle test-out >> | #+END_SRC >> | >> | *** Block 6 (Gets consumed by previous Block >> | >> | #+BEGIN_SRC sh :tangle test-out >> | Block 6 >> | #+END_SRC >> `---- > > > > --- > Org-mode version 7.4 (release_7.4.529.gb23d) > GNU Emacs 24.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.24.0) > of 2011-02-25