From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: Problems with (defvar foo) and Emacs 23 Date: Mon, 02 Apr 2012 08:27:36 +0200 Message-ID: <87398m642v.fsf@gnu.org> References: <87sjgngtzk.fsf@norang.ca> <87aa2vp5ri.fsf@Rainer.invalid> <87aa2vw5mq.fsf@gnu.org> <87y5qfp2wd.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([208.118.235.92]:59644) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEaie-0002aM-J4 for emacs-orgmode@gnu.org; Mon, 02 Apr 2012 02:26:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SEaic-0006zx-AL for emacs-orgmode@gnu.org; Mon, 02 Apr 2012 02:26:24 -0400 Received: from mail-we0-f169.google.com ([74.125.82.169]:49132) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEaic-0006zb-10 for emacs-orgmode@gnu.org; Mon, 02 Apr 2012 02:26:22 -0400 Received: by werj55 with SMTP id j55so1942526wer.0 for ; Sun, 01 Apr 2012 23:26:20 -0700 (PDT) In-Reply-To: <87y5qfp2wd.fsf@Rainer.invalid> (Achim Gratz's message of "Sun, 01 Apr 2012 23:18:10 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Achim Gratz Cc: emacs-orgmode@gnu.org Achim Gratz writes: > Bastien writes: >> Well -- I'll be pretty busy next week, so hopefully we can fix this >> soon... any help welcome! :) > > Ditto, but you do realize this will be horribly broken in Emacs 24? http://orgmode.org/w/?p=org-mode.git;a=commitdiff;h=08d9b466225fad7e4cacd593f5ec7d2a4cd878ff http://orgmode.org/w/?p=org-mode.git;a=commitdiff;h=c24fa194a62cbbc45fa1b58e39dac293a006a0c9 http://orgmode.org/w/?p=org-mode.git;a=commitdiff;h=fcf13e02aa4bd056316cb7476b94aecf80738b47 http://orgmode.org/w/?p=org-mode.git;a=commitdiff;h=9054ba39d085dc2910285a194ed2206b36875289 http://orgmode.org/w/?p=org-mode.git;a=commitdiff;h=b689cbfb6c4d287d839ac3b0727497e5114995d8 are fine. http://orgmode.org/w/?p=org-mode.git;a=commitdiff;h=b46fa17a97ee050b5aeccffaa7323201fe491371 was problematic, as reported by Bernt, and I think I fixed it. It leaves us with http://orgmode.org/w/?p=org-mode.git;a=commitdiff;h=6cbf1f417222321a47848a7368427ba8a22fe3a5 which should be carefully reviewed/tested/amended. > Anyway, for that single dynamic "state" variable: it is let-bound in > org.el/org-todo and then dynamically scoped in many, many places: > > contrib/lisp/{org-{checklist,choose},org2rem}.el > > /lisp/{org-{agenda,clock,icalendar,mouse,taskjuggler},org}.el The `state' dynamically scoped in these files is not necessarily the same `state' that is dynamically scoped in `org-todo'. For example in org-agenda.el there is `state' in `org-agenda-log-mode', but this is dynamically scoped in another function org-agenda.el that does not depend on org.el's definition for `state'... > So the correct prefixed name should probably be org-todo-state (there > are other such "state"s in other places, don't know yet if they are also > dynamically scoped into other functions). You need to also keep track > of which functions use "state" as a formal parameter name, since these > shadow the dynamic variable from the outside, but provide another > "state" for calls on the inside… Yep -- I guess we're good for a fun ride. > Haven't yet checked any of the other definitions that had their name > changed, gotta fetch some sleep before work. Please do! Let's do some heavy testing against current HEAD and let's carefully review code. But let's not panic -- Emacs is still in pretest, that's the whole purpose of a pretest. Thanks all for your help, -- Bastien