[BUG] babel call lines broken

[BUG] babel call lines broken

[Andreas Leha]

Hi all,

there seems to be a bug in evaluating #+call lines.

To reproduce, consider this file:
,----
| * Some Headline
| #+name: parameters
| #+BEGIN_SRC R
|   ttt <- 1
| #+END_SRC
| 
| * Some Other Headline
| #+call: parameters() :results silent :exports none
`----
and do C-c C-c on the #+call: line.

For me that results in:
,----
| Debugger entered--Lisp error: (wrong-type-argument stringp nil)
|   replace-match(nil nil nil nil 3)
|   org-babel-set-current-result-hash(nil)
|   org-babel-lob-execute(("parameters()" ":results silent :exports none" 0))
|   org-babel-lob-execute-maybe()
|   org-babel-execute-maybe()
|   org-babel-execute-safely-maybe()
|   run-hook-with-args-until-success(org-babel-execute-safely-maybe)
|   org-ctrl-c-ctrl-c(nil)
|   call-interactively(org-ctrl-c-ctrl-c nil nil)
`----

Regards,
Andreas

PS: I am on emacs24.2.50.1

Re: [BUG] babel call lines broken

[Eric Schulte]

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

This is a problem caused by my recent addition of hashing to call lines.
I've attached a patch which fixes this problem.  For some reason I am
currently unable to communicate with the Org-mode git server, so if
anyone else is able to apply this patch please do.

Thanks for catching this problem,


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-only-try-to-insert-extant-hashes.patch --]
[-- Type: text/x-patch, Size: 837 bytes --]

From 9e0e55e0ee2c933de476ca869910c3279df62675 Mon Sep 17 00:00:00 2001
From: Eric Schulte <eric.schulte@gmx.com>
Date: Thu, 5 Jul 2012 07:47:32 -0600
Subject: [PATCH] only try to insert extant hashes

* lisp/ob-lob.el (org-babel-lob-execute): Only try to insert extant
  hashes.
---
 lisp/ob-lob.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/ob-lob.el b/lisp/ob-lob.el
index 66b100c..b1efbbb 100644
--- a/lisp/ob-lob.el
+++ b/lisp/ob-lob.el
@@ -139,7 +139,7 @@ if so then run the appropriate source block from the Library."
 	  (prog1 (org-babel-execute-src-block
 		  nil (mkinfo (org-babel-process-params pre-params)))
 	    ;; update the hash
-	    (org-babel-set-current-result-hash new-hash))))))
+	    (when hash (org-babel-set-current-result-hash new-hash)))))))
 
 (provide 'ob-lob)
 
-- 
1.7.11.1


[-- Attachment #3: Type: text/plain, Size: 1033 bytes --]


Andreas Leha <andreas.leha@med.uni-goettingen.de> writes:

> Hi all,
>
> there seems to be a bug in evaluating #+call lines.
>
> To reproduce, consider this file:
> ,----
> | * Some Headline
> | #+name: parameters
> | #+BEGIN_SRC R
> |   ttt <- 1
> | #+END_SRC
> | 
> | * Some Other Headline
> | #+call: parameters() :results silent :exports none
> `----
> and do C-c C-c on the #+call: line.
>
> For me that results in:
> ,----
> | Debugger entered--Lisp error: (wrong-type-argument stringp nil)
> |   replace-match(nil nil nil nil 3)
> |   org-babel-set-current-result-hash(nil)
> |   org-babel-lob-execute(("parameters()" ":results silent :exports none" 0))
> |   org-babel-lob-execute-maybe()
> |   org-babel-execute-maybe()
> |   org-babel-execute-safely-maybe()
> |   run-hook-with-args-until-success(org-babel-execute-safely-maybe)
> |   org-ctrl-c-ctrl-c(nil)
> |   call-interactively(org-ctrl-c-ctrl-c nil nil)
> `----
>
> Regards,
> Andreas
>
> PS: I am on emacs24.2.50.1
>
>

-- 
Eric Schulte
http://cs.unm.edu/~eschulte

Re: [BUG] babel call lines broken

[Bastien]

Eric Schulte <eric.schulte@gmx.com> writes:

> For some reason I am
> currently unable to communicate with the Org-mode git server, so if
> anyone else is able to apply this patch please do.

Done - thanks for the patch!

-- 
 Bastien

Re: [BUG] babel call lines broken

[Andreas Leha]

Bastien <bzg@gnu.org> writes:

> Eric Schulte <eric.schulte@gmx.com> writes:
>
>> For some reason I am
>> currently unable to communicate with the Org-mode git server, so if
>> anyone else is able to apply this patch please do.
>
> Done - thanks for the patch!

Thanks for the patch and the check-in.  I can confirm, that the issue is
fixed for me.

Cheers,
Andreas