emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] ob-python: specify defcustom parameters
@ 2012-12-07 20:07 Achim Gratz
  2012-12-11 14:42 ` Eric Schulte
  0 siblings, 1 reply; 4+ messages in thread
From: Achim Gratz @ 2012-12-07 20:07 UTC (permalink / raw)
  To: emacs-orgmode


This avoids a byte-compiler warning and makes these customizations
easier to find.

--8<---------------cut here---------------start------------->8---
commit 9666909a8db4f8ba54c6cabde40f35cbf82a3b52 (HEAD, refs/heads/lth-mk)
Author: Achim Gratz <Stromeko@Stromeko.DE>
Date:   Fri Dec 7 21:05:52 2012 +0100

    ob-python: specify defcustom parameters
    
    * lisp/ob-python.el (org-babel-python-hline-to,
      org-babel-python-None-to): Specify customize group as 'org-babel and
      widget type as 'string.

	Modified   lisp/ob-python.el
diff --git a/lisp/ob-python.el b/lisp/ob-python.el
index 4d94ecf..e393d1d 100644
--- a/lisp/ob-python.el
+++ b/lisp/ob-python.el
@@ -53,10 +53,14 @@ (defvar org-babel-python-mode (if (featurep 'xemacs) 'python-mode 'python)
 (defvar org-src-preserve-indentation)
 
 (defcustom org-babel-python-hline-to "None"
-  "Replace hlines in incoming tables with this when translating to python.")
+  "Replace hlines in incoming tables with this when translating to python."
+  :group 'org-babel
+  :type 'string)
 
 (defcustom org-babel-python-None-to 'hline
-  "Replace 'None' in python tables with this before returning.")
+  "Replace 'None' in python tables with this before returning."
+  :group 'org-babel
+  :type 'string)
 
 (defun org-babel-execute:python (body params)
   "Execute a block of Python code with Babel.

--8<---------------cut here---------------end--------------->8---

Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf Q+, Q and microQ:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ob-python: specify defcustom parameters
  2012-12-07 20:07 [PATCH] ob-python: specify defcustom parameters Achim Gratz
@ 2012-12-11 14:42 ` Eric Schulte
  2012-12-11 18:43   ` Achim Gratz
  0 siblings, 1 reply; 4+ messages in thread
From: Eric Schulte @ 2012-12-11 14:42 UTC (permalink / raw)
  To: Achim Gratz; +Cc: emacs-orgmode

Achim Gratz <Stromeko@nexgo.de> writes:

> This avoids a byte-compiler warning and makes these customizations
> easier to find.
>

Again, could you send a git format-patch version of this patch?

Then I will apply it.

Thanks.

-- 
Eric Schulte
http://cs.unm.edu/~eschulte

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ob-python: specify defcustom parameters
  2012-12-11 14:42 ` Eric Schulte
@ 2012-12-11 18:43   ` Achim Gratz
  2012-12-12  0:26     ` Eric Schulte
  0 siblings, 1 reply; 4+ messages in thread
From: Achim Gratz @ 2012-12-11 18:43 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

Eric Schulte writes:
> Again, could you send a git format-patch version of this patch?

Sorry if this comes through twice, but it appears that Gmane has dropped
my first posting.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0002-ob-python-specify-defcustom-parameters.patch --]
[-- Type: text/x-patch, Size: 1271 bytes --]

From b759805cca39914843222c25a63854c7694d7e80 Mon Sep 17 00:00:00 2001
From: Achim Gratz <Stromeko@Stromeko.DE>
Date: Fri, 7 Dec 2012 21:05:52 +0100
Subject: [PATCH 2/4] ob-python: specify defcustom parameters

* lisp/ob-python.el (org-babel-python-hline-to,
  org-babel-python-None-to): Specify customize group as 'org-babel and
  widget type as 'string.
---
 lisp/ob-python.el | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/lisp/ob-python.el b/lisp/ob-python.el
index 4d94ecf..e393d1d 100644
--- a/lisp/ob-python.el
+++ b/lisp/ob-python.el
@@ -53,10 +53,14 @@ (defvar org-babel-python-mode (if (featurep 'xemacs) 'python-mode 'python)
 (defvar org-src-preserve-indentation)
 
 (defcustom org-babel-python-hline-to "None"
-  "Replace hlines in incoming tables with this when translating to python.")
+  "Replace hlines in incoming tables with this when translating to python."
+  :group 'org-babel
+  :type 'string)
 
 (defcustom org-babel-python-None-to 'hline
-  "Replace 'None' in python tables with this before returning.")
+  "Replace 'None' in python tables with this before returning."
+  :group 'org-babel
+  :type 'string)
 
 (defun org-babel-execute:python (body params)
   "Execute a block of Python code with Babel.
-- 
1.8.0.1


[-- Attachment #3: Type: text/plain, Size: 188 bytes --]



Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptation for Waldorf microQ V2.22R2:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ob-python: specify defcustom parameters
  2012-12-11 18:43   ` Achim Gratz
@ 2012-12-12  0:26     ` Eric Schulte
  0 siblings, 0 replies; 4+ messages in thread
From: Eric Schulte @ 2012-12-12  0:26 UTC (permalink / raw)
  To: Achim Gratz; +Cc: emacs-orgmode

Achim Gratz <Stromeko@nexgo.de> writes:

> Eric Schulte writes:
>> Again, could you send a git format-patch version of this patch?
>
> Sorry if this comes through twice, but it appears that Gmane has dropped
> my first posting.
>

I only got this once.

Thanks for re-sending, I'll apply this when next I push to the git repo.

-- 
Eric Schulte
http://cs.unm.edu/~eschulte

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-12-12  2:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-07 20:07 [PATCH] ob-python: specify defcustom parameters Achim Gratz
2012-12-11 14:42 ` Eric Schulte
2012-12-11 18:43   ` Achim Gratz
2012-12-12  0:26     ` Eric Schulte

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).