emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@altern.org>
To: "Abdó Roig-Maranges" <abdo.roig@gmail.com>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: Dramatic slowdown in org mode
Date: Wed, 19 Dec 2012 00:26:27 +0100	[thread overview]
Message-ID: <8738z3t00s.fsf@bzg.ath.cx> (raw)
In-Reply-To: <87sj73vxr7.fsf@gmail.com> ("Abdó Roig-Maranges"'s message of "Tue, 18 Dec 2012 22:47:08 +0100")

Hi Abdó,

Abdó Roig-Maranges <abdo.roig@gmail.com> writes:

> I tracked it back to commit a7afe7d, but haven't had the time to
> investigate it further. On my case the slowdown is not as dramatic as
> Eric's, though.

Thanks for the investigation.

The problem was that org-agenda-skip, which is called many times 
during agenda generation, checks whether the point is in a code
source block.  The new org-in-src-block-p distinguish whether 
we are really within or "at" (which includes the #+begin_src
and #+end_src lines).  org-agenda-skip just needs to check
if we are _within_.  I fixed this.

-- 
 Bastien

  reply	other threads:[~2012-12-18 23:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-18 21:05 Dramatic slowdown in org mode Fraga, Eric
2012-12-18 21:47 ` Abdó Roig-Maranges
2012-12-18 23:26   ` Bastien [this message]
2012-12-18 21:53 ` Bastien
2012-12-18 22:52   ` Abdó Roig-Maranges
2012-12-18 22:54   ` Nick Dokos
2012-12-18 23:26 ` Bastien
2012-12-19  6:25   ` Fraga, Eric
2012-12-19  9:42     ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8738z3t00s.fsf@bzg.ath.cx \
    --to=bzg@altern.org \
    --cc=abdo.roig@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).