From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Schulte Subject: Re: [PATCH] ob-fortran.el, add matrix as input Date: Thu, 06 Jun 2013 10:17:43 -0600 Message-ID: <8738sv6wns.fsf@gmail.com> References: <5rvc5x211u.fsf@kana.aer.mw.tum.de> <87ip1ueanc.fsf@gmail.com> <8761xs1ecu.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58793) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ukcta-00039Q-VQ for emacs-orgmode@gnu.org; Thu, 06 Jun 2013 12:18:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UkctW-0003zf-DX for emacs-orgmode@gnu.org; Thu, 06 Jun 2013 12:18:38 -0400 Received: from mail-pd0-f182.google.com ([209.85.192.182]:61788) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkctW-0003xT-4l for emacs-orgmode@gnu.org; Thu, 06 Jun 2013 12:18:34 -0400 Received: by mail-pd0-f182.google.com with SMTP id g10so3567924pdj.13 for ; Thu, 06 Jun 2013 09:18:33 -0700 (PDT) In-Reply-To: <8761xs1ecu.fsf@Rainer.invalid> (Achim Gratz's message of "Wed, 05 Jun 2013 22:39:45 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Achim Gratz Cc: emacs-orgmode@gnu.org Achim Gratz writes: > Eric Schulte writes: >> Applied, Thanks! >> >> Litvinov Sergey writes: >> >>> I would like to propose a tiny patch which adds matrix as an input for >>> ob-fortran.el. See changes in testing/examples/ob-fortran-test.org for >>> the examples. > > I've not had time to test with anything, but this patch seems to make > the same faulty assumption about tables always being a list of lists > that I fixed just a few days ago someplace else. When dealing with > tables you have to expect hlines in place of a list with the row values > otherwise you will not correctly recognize them. > Agreed, I've just updated the matrix check in ob-fortran to be more strict so that tables with hlines will not be treated as matrices. A more sophisticated solution to correctly interpret hlines in a manner acceptable to Fortran would require more Fortran knowledge than I posses. Best, > > > Regards, > Achim. -- Eric Schulte http://cs.unm.edu/~eschulte