emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Jonas Hörsch" <coroa@online.de>
To: Nicolas Goaziou <n.goaziou@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Re: [BUG] org-cycle on hidden inline task makes also other inline tasks visible
Date: Tue, 29 Oct 2013 23:38:31 +0100	[thread overview]
Message-ID: <8738njd7o8.fsf@kafka.loc> (raw)
In-Reply-To: <87r4b3c0c8.fsf@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 255 bytes --]

Hej,

On Tue, Oct 29 2013, Nicolas Goaziou wrote:

> You need to detail which function is modified and how.
>
> Also, if you haven't signed FSF papers, you need to add TINYCHANGE at
> the end of the message.

thanks for bearing with me. is this alright?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-org-inlinetask-fix-inlinetask-unfolding.patch --]
[-- Type: text/x-patch, Size: 1010 bytes --]

From 1c6e67b06d0eb22c6d79387c8c6d07c23500f91d Mon Sep 17 00:00:00 2001
From: Jonas Hoersch <coroa@online.de>
Date: Tue, 29 Oct 2013 17:07:49 +0100
Subject: [PATCH] org-inlinetask: fix inlinetask unfolding

* lisp/org-inlinetask.el (org-inlinetask-toggle-visibility): Don't use
  `org-show-entry` as it cannot unfold an inlinetask properly.

TINYCHANGE
---
 lisp/org-inlinetask.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/org-inlinetask.el b/lisp/org-inlinetask.el
index 112d3df..ca7572b 100644
--- a/lisp/org-inlinetask.el
+++ b/lisp/org-inlinetask.el
@@ -315,7 +315,8 @@ If the task has an end part, also demote it."
      ((= end start))
      ;; Inlinetask was folded: expand it.
      ((get-char-property (1+ start) 'invisible)
-      (org-show-entry))
+      (outline-flag-region start end nil)
+      (org-cycle-hide-drawers 'children))
      (t (outline-flag-region start end t)))))
 
 (defun org-inlinetask-remove-END-maybe ()
-- 
1.8.4


[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

  reply	other threads:[~2013-10-29 22:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-05 11:33 [BUG] org-cycle on hidden inline task makes also other inline tasks visible Jonas Hörsch
2013-09-06  1:23 ` John Hendy
2013-10-29 16:46 ` [PATCH] " Jonas Hörsch
2013-10-29 20:02   ` Nicolas Goaziou
2013-10-29 22:38     ` Jonas Hörsch [this message]
2013-10-29 23:36       ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8738njd7o8.fsf@kafka.loc \
    --to=coroa@online.de \
    --cc=emacs-orgmode@gnu.org \
    --cc=n.goaziou@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).