[bug] Org-verbatim and org-code not converted into HTML tags

[bug] Org-verbatim and org-code not converted into HTML tags

[Sebastien Vauban]

Hello,

--8<---------------cut here---------------start------------->8---
When =:hlines yes=, strips horizontal lines from the input table.

When ~:hlines yes~, strips horizontal lines from the input table.
--8<---------------cut here---------------end--------------->8---

outputs the following HTML:

--8<---------------cut here---------------start------------->8---
<p>When =:hlines yes=, strips horizontal lines from the input
table.</p>

<p>When ~:hlines yes~, strips horizontal lines from the input
table.</p>
--8<---------------cut here---------------end--------------->8---

with Org-mode version 8.2.5h (release_8.2.5h-867-g25c591).

Test with minimal Emacs.

Best regards,
  Seb

-- 
Sebastien Vauban

Re: [bug] Org-verbatim and org-code not converted into HTML tags

[Nicolas Goaziou]

Hello,

Sebastien Vauban <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
writes:

> When =:hlines yes=, strips horizontal lines from the input table.
>
> When ~:hlines yes~, strips horizontal lines from the input table.
>
> outputs the following HTML:
>
> <p>When =:hlines yes=, strips horizontal lines from the input
> table.</p>
>
> <p>When ~:hlines yes~, strips horizontal lines from the input
> table.</p>
>
> with Org-mode version 8.2.5h (release_8.2.5h-867-g25c591).
>
> Test with minimal Emacs.

This should be fixed. Thank you.


Regards,

-- 
Nicolas Goaziou

Re: [bug] Org-verbatim and org-code not converted into HTML tags

[Sebastien Vauban]

Hello,

Nicolas Goaziou wrote:
> Sebastien Vauban writes:
>
>> When =:hlines yes=, strips horizontal lines from the input table.
>>
>> outputs the following HTML:
>>
>> <p>When =:hlines yes=, strips horizontal lines from the input
>> table.</p>
>>
>> with Org-mode version 8.2.5h (release_8.2.5h-867-g25c591).
>
> This should be fixed. Thank you.

This is:

--8<---------------cut here---------------start------------->8---
-            <li>during <b>weave</b> (code blocks with =:exports= set to
-            <code>results</code> or <code>both</code>)</li>
+            <li>during <b>weave</b> (code blocks with <code>:exports</code> set
+            to <code>results</code> or <code>both</code>)</li>
--8<---------------cut here---------------end--------------->8---

Thank you.

Though, there are extra diffs in my HTML output, about the style of the
org-block delimiter lines: they've lost their "under/over-line" feature,
and colors are not the same anymore.

See:

--8<---------------cut here---------------start------------->8---
               <div class="org-src-container">
                 <pre class="src src-org">
 <span style=
-"color: #555555; background-color: #E2E1D5; text-decoration: underline;">#+begin_src &lt;LANGUAGE&gt; &lt;HEADER-ARGS&gt;</span>
+"color: #008ED1; background-color: #EAEAFF;">#+begin_src &lt;LANGUAGE&gt; &lt;HEADER-ARGS&gt;</span>
 <span style="background-color: #FFFFE0;">&lt;BODY&gt;
 </span><span style=
-"color: #555555; background-color: #E2E1D5; text-decoration: overline;">#+end_src</span>
+"color: #008ED1; background-color: #EAEAFF;">#+end_src</span>
 </pre>
               </div>
--8<---------------cut here---------------end--------------->8---

In the previous version ("-" above), the `org-block-begin-line' (for
example) had well its underline and the colors did match their
definition in the color theme I use (Leuven, in current Emacs trunk, or
on MELPA):

--8<---------------cut here---------------start------------->8---
   `(org-block-begin-line ((,class (:underline "#A7A6AA" :foreground "#555555" :background "#E2E1D5"))))
   `(org-block-end-line ((,class (:overline "#A7A6AA" :foreground "#555555" :background "#E2E1D5"))))
--8<---------------cut here---------------end--------------->8---

This is not the case anymore. Any idea?

Best regards,
  Seb

-- 
Sebastien Vauban

Re: [bug] Org-verbatim and org-code not converted into HTML tags

[Bastien]

Hi Sébastien,

Sebastien Vauban <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
writes:

> Though, there are extra diffs in my HTML output, about the style of the
> org-block delimiter lines: they've lost their "under/over-line" feature,
> and colors are not the same anymore.

not sure how this would relate to the bug you reported and that
Nicolas fixed in this thread.

Can you bisect to spot the first bad commit, and tell exactly
what's bad here from an emacs -Q point of view?

Thanks!

-- 
 Bastien

Re: [bug] Org-verbatim and org-code not converted into HTML tags

[Sebastien Vauban]

Hi Bastien,

Bastien wrote:
> Sebastien Vauban writes:
>
>> Though, there are extra diffs in my HTML output, about the style of the
>> org-block delimiter lines: they've lost their "under/over-line" feature,
>> and colors are not the same anymore.
>
> Can you bisect to spot the first bad commit, and tell exactly
> what's bad here from an emacs -Q point of view?

It took me a while to understand what was going on.  But I did.

See http://screencast.com/t/1peLgaZ7.

The "styling" bug is present in all latest Emacs versions, and relates
to the Emacs bug #16440 ("Some colors of the theme aren't respected in
latest Emacs"):

  ╭──── From: Eli Zaretskii
  │ 
  │ This seems to be the consequence of the change described in NEWS like
  │ this:
  │ 
  │   *** Face specs set via Custom themes now replace the `defface' spec
  │   rather than inheriting from it (as do face specs set via Customize).
  │ 
  │ Org uses org-copy-face to define the faces that you show in your
  │ screencast, and org-copy-face assumes the face it inherits from
  │ already exists.  But loading a theme now doesn't create the faces, it
  │ only prepares the data for when the face will be created.  So :inherit
  │ in org-copy-face doesn't do what you expect.
  │ 
  │ I guess either some change is needed in how themes are handled, or
  │ org-copy-face needs to change to follow suit.  (CC to Bastien for
  │ that.)
  ╰────

See http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16440 for the whole
thread.

Best regards,
  Seb

-- 
Sebastien Vauban