[bug] Alignment bug in clock tables

[bug] Alignment bug in clock tables

[Francesco Pizzolante]

Hi,

I'm having an alignment issue in clock tables, both in the agenda and in
dynamic blocks.

By default, \emsp is displayed in clock tables for level 2 (or above) to
indent headings. To avoid that, I set the variable `org-pretty-entities'
to t, and in this case the alignment of the table is broken when you
regenerate it.

I currently see no solution if I want correct alignment in clock tables
without seeing \emsp.

Any idea how to achieve that?

Here's a small screen capture that shows the issue:
http://screencast.com/t/qpmxDV8R543G

Thanks.

 Francesco

Re: [bug] Alignment bug in clock tables

[Joost Helberg]

Francesco,

I reported this on September 2nd too. Hitting C-c C-c inside the table
fixes the formatting. Also moving to a position inside the table and
doing: M-x org-table-align fixes the formatting. Hence
I tried to create a new formatter function in order to re-align after
writing the table:

(defun my-formatter( ipos tables params )
  (progn
    (org-clocktable-write-default ipos tables params)
    (forward-line 2)
    (org-table-align)
    )
  )

and install this as the formatter, but it didn't help. If it would have
helped, I could have fixed the default table-writer by adding
(org-table-align). 

Anyone an idea?

regards,

Joost Helberg

>>>>> "Francesco" == Francesco Pizzolante <fpz@missioncriticalit.com> writes:
 > From: Francesco Pizzolante <fpz@missioncriticalit.com>
 > To: mailing-list-org-mode <emacs-orgmode@gnu.org>
 > Subject: [O] [bug] Alignment bug in clock tables
 > Date: 2014-10-02T17:41:07+0200

 > Hi,

 > I'm having an alignment issue in clock tables, both in the agenda and in
 > dynamic blocks.

 > By default, \emsp is displayed in clock tables for level 2 (or above) to
 > indent headings. To avoid that, I set the variable `org-pretty-entities'
 > to t, and in this case the alignment of the table is broken when you
 > regenerate it.

 > I currently see no solution if I want correct alignment in clock tables
 > without seeing \emsp.

 > Any idea how to achieve that?

 > Here's a small screen capture that shows the issue:
 > http://screencast.com/t/qpmxDV8R543G

 > Thanks.

 >  Francesco


-- 
Snow B.V.

Re: [bug] Alignment bug in clock tables

[Francesco Pizzolante]

Hi Joost,

> I reported this on September 2nd too. Hitting C-c C-c inside the table
> fixes the formatting. Also moving to a position inside the table and
> doing: M-x org-table-align fixes the formatting. Hence
> I tried to create a new formatter function in order to re-align after
> writing the table:
>
> (defun my-formatter( ipos tables params )
>   (progn
>     (org-clocktable-write-default ipos tables params)
>     (forward-line 2)
>     (org-table-align)
>     )
>   )
>
> and install this as the formatter, but it didn't help. If it would have
> helped, I could have fixed the default table-writer by adding
> (org-table-align). 
>
> Anyone an idea?

On my side, I tried another *workaround*: I call (org-table-align) in
a before-save-hook. This way, all tables are correctly aligned when
I save. I simply call:

(org-table-map-tables 'org-table-align t)

But this only works when you save and thus only for file buffers (and
you can still see the misalignment when you create/update the dynamic
blocks).

Currently I have no solution for agenda buffers when displaying clock
tables.

Any hint to fix this is welcome.

Regards,
 Francesco

Re: [bug] Alignment bug in clock tables

[Stormking]

Francesco Pizzolante <fpz@...> writes:

> 
> Hi Joost,
> 
> > I reported this on September 2nd too.

I'm having this problem, too. The code that aligns the clocktable
seems to count the "\emsp" entity as five characters. But with
pretty entities turned on, it's displayed as only one character.

The same is true for the code that shortens the headline if the
narrow option is used.

Ciao, Stormking

Re: [bug] Alignment bug in clock tables

[Stormking]

Stormking <stormking <at> web.de> writes:

> 
> Francesco Pizzolante <fpz <at> ...> writes:
> 
> > 
> > Hi Joost,
> > 
> > > I reported this on September 2nd too.
> 
> I'm having this problem, too. 

For now, I have added the following code to my init.el:

(eval-after-load "org-clock"
  '(defun org-clocktable-indent-string (level)
  (if (= level 1) ""
    (concat "\\" (let ((str " "))
      (dotimes (k (1- level) str)
	(setq str (concat "_" str))))))))

It redefines the function org-clocktable-indent-string to
what it was before the whole emsp thing.

Re: [bug] Alignment bug in clock tables

[Francesco Pizzolante]

Hi Stormking,

Sorry for my very late reply: I thank you very much for your workaround
which enables me to have well aligned clock tables.

I also take the opportunity to bump up this thread.

I think you correctly spotted the exact cause of our issue. Here's what
you say in a previous message:

> I'm having this problem, too. The code that aligns the clocktable
> seems to count the "\emsp" entity as five characters. But with
> pretty entities turned on, it's displayed as only one character.

To make it short: the alignment code counts "\emsp" as 5 chars, while it
is displayed as one.

I recall the small screencast here: http://screencast.com/t/qpmxDV8R543G

Anyone to fix this in the code?

Thanks.

Regards,
 Francesco

Re: [bug] Alignment bug in clock tables

[Stormking]

Francesco Pizzolante <fpz@...> writes:

> 
> Hi Stormking,
> 
> Sorry for my very late reply: I thank you very much for your workaround
> which enables me to have well aligned clock tables.
> 
> I also take the opportunity to bump up this thread.

Without any effect, it seems. I wonder if anybody actually uses these
features.

Ciao, Stormking

Re: [bug] Alignment bug in clock tables

[Nicolas Goaziou]

Hello,

Stormking <stormking@web.de> writes:

> Without any effect, it seems. I wonder if anybody actually uses these
> features.

What character do you suggest to use instead of \emph?

"*" is not possible due to a collision with bold syntax (i.e. "***" is
parsed as a bold star).


Regards,

-- 
Nicolas Goaziou

Re: [bug] Alignment bug in clock tables

[Stormking]

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> 
> Hello,
> 
> Stormking <stormking <at> web.de> writes:
> 
> > Without any effect, it seems. I wonder if anybody actually uses these
> > features.
> 
> What character do you suggest to use instead of \emph?

Wouldn't it be better to fix the alignment code so it works with
pretty entities? Because that's the real problem here.

Re: [bug] Alignment bug in clock tables

[Nicolas Goaziou]

Stormking <stormking@web.de> writes:

> Wouldn't it be better to fix the alignment code so it works with
> pretty entities? Because that's the real problem here.

There are two problems here.

One is obviously due to misalignment when using overlays.

The other one is that \emph is not easily readable when
`org-pretty-entities' is nil.

Patches welcome.


Regards,

Re: [bug] Alignment bug in clock tables

[Stormking]

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> 
> Stormking <stormking <at> web.de> writes:
> 
> > Wouldn't it be better to fix the alignment code so it works with
> > pretty entities? Because that's the real problem here.
> 
> There are two problems here.
> 
> One is obviously due to misalignment when using overlays.
> 
> The other one is that \emph is not easily readable when
> `org-pretty-entities' is nil.

You are right but I always have pretty entities turned on, so
it doesn't bother me that much. Wasn't it changed to \emsp
(m-dash) so it would look better in exported HTML or LaTeX?

Otherwise, I would suggest something like \-- or \__

I just tested the alignment in a generic table. I have set \emsp
to be displayed as as dash ("-"). An explicit re-align of a table
containing this entity works, but the auto-alignment that
happens while you type does not.

Ciao, Stormking

Re: [bug] Alignment bug in clock tables

[Stormking]

Stormking <stormking <at> web.de> writes:

> Wasn't it changed to \emsp
> (m-dash) so it would look better in exported HTML or LaTeX?

I have to correct myself on this one, \emsp ist a m-space, not a m-dash

Re: [bug] Alignment bug in clock tables

[Nicolas Goaziou]

Stormking <stormking@web.de> writes:

> You are right but I always have pretty entities turned on, so
> it doesn't bother me that much. Wasn't it changed to \emsp
> (m-dash) so it would look better in exported HTML or LaTeX?

It was.

> Otherwise, I would suggest something like \-- or \__

See above.

> I just tested the alignment in a generic table. I have set \emsp
> to be displayed as as dash ("-"). An explicit re-align of a table
> containing this entity works,

Same as displaying "-".

> but the auto-alignment that happens while you type does not.

Ditto.

Regards,