emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Matthew Gidden <gidden@wisc.edu>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Adding a BEAMER_HEADER_EXTRA tag, allows short titles, etc.
Date: Tue, 10 Mar 2015 16:44:33 +0100	[thread overview]
Message-ID: <87385c3li6.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAHRdPFxaCLFDQfaL_hd8Nr9tydP6juWaE7vJjJTCFkzqMFOMjw@mail.gmail.com> (Matthew Gidden's message of "Tue, 10 Mar 2015 10:15:43 -0500")

Matthew Gidden <gidden@wisc.edu> writes:

> Updated patch with updated commit message attached.

Thank you.

> Subject: [PATCH] org-beamer.el: Enable custom beamer input before
>  \begin{document}

"ox-beamer". Also the summary is too long.

> * lisp/ox-beamer.el (`beamer-header'): Move BEAMER_HEADER injection to
>   final part of preamble (after themes, title, etc.). Allows for
>   custom short titles, etc., with #+BEAMER_HEADER: \title[Short]{Long}.
>
> Previously, TITLE was being injected after BEAMER_HEADER, so short
> titles (and related) could not be added. BEAMER_HEADER now serves as a
> final preamble injection point.

Two spaces are required after sentences.

Otherwise, the patch looks good.

Could you add a footnote about this change at (info "(org) Beamer
export"), close to #+BEAMER_HEADER reference, in "org.texi"?


Regards,

  reply	other threads:[~2015-03-10 15:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-09 21:56 [PATCH] Adding a BEAMER_HEADER_EXTRA tag, allows short titles, etc Matthew Gidden
2015-03-09 23:19 ` Nicolas Goaziou
2015-03-09 23:46   ` Matthew Gidden
2015-03-10 14:44     ` Nicolas Goaziou
2015-03-10 14:45       ` Matthew Gidden
2015-03-10 15:15         ` Matthew Gidden
2015-03-10 15:44           ` Nicolas Goaziou [this message]
2015-03-10 16:10             ` Matthew Gidden
2015-03-10 20:22               ` Nicolas Goaziou
2015-03-09 23:50 ` Rasmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87385c3li6.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=gidden@wisc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).