From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Michael Brand <michael.ch.brand@gmail.com>
Cc: Org Mode <emacs-orgmode@gnu.org>,
Julien Cubizolles <j.cubizolles@free.fr>
Subject: Re: org-pdfview-open doesn't work anymore
Date: Sat, 06 Feb 2016 17:41:23 +0100 [thread overview]
Message-ID: <8737t5pz9o.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CALn3zoh3y+gFW_fDrmNRtwJZfpP2srx6cxcVAU6KWRha_wdCeQ@mail.gmail.com> (Michael Brand's message of "Sat, 6 Feb 2016 09:08:37 +0100")
Hello,
Michael Brand <michael.ch.brand@gmail.com> writes:
> I just notice that in our case at least in case of wrong-type-argument the
> `cmd' is missing, so I suggest
>
> ((wrong-number-of-arguments wrong-type-argument invalid-function)
> (user-error "Please see Org News for version 9.0 about \
> `org-file-apps'--Lisp error: The function %S leads to %S" cmd err))
>
> for the attached intermediate patch version. For the above example of
> (zerop nil) it would not only report "wrong-type-argument" and
> "numberp" together with "nil" but also "zerop" which in our case is
> the registered application, the source of the problem where the user
> needs to look.
IMO, notifying user that there's something rotten in the state of
`org-file-apps' is enough. There's no need to go into the gory details
of the problem.
Anyway, if you feel strongly about it, your patch looks good and you can
push it.
Thank you.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2016-02-06 16:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 5:46 org-pdfview-open doesn't work anymore Julien Cubizolles
2016-02-05 8:33 ` Michael Brand
2016-02-05 13:36 ` Nicolas Goaziou
2016-02-10 12:55 ` Julien Cubizolles
2016-02-05 13:45 ` Michael Brand
2016-02-05 17:22 ` Nicolas Goaziou
2016-02-05 18:47 ` Michael Brand
2016-02-05 22:43 ` Nicolas Goaziou
2016-02-06 8:08 ` Michael Brand
2016-02-06 16:41 ` Nicolas Goaziou [this message]
2016-02-07 10:13 ` Michael Brand
2016-02-07 11:06 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737t5pz9o.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=j.cubizolles@free.fr \
--cc=michael.ch.brand@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).