From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcin Borkowski Subject: Re: A proposed enhancement in entering timestamps (was: A small fix in `org-read-date-analyze') Date: Tue, 22 Mar 2016 21:28:49 +0100 Message-ID: <8737ri1cla.fsf@mbork.pl> References: <8760wlgw2t.fsf@mbork.pl> <874mc5gvnj.fsf@mbork.pl> <87fuvon48l.fsf@nicolasgoaziou.fr> <87twk4fiob.fsf@mbork.pl> <874mc3ewp4.fsf@nicolasgoaziou.fr> <87pourg252.fsf@mbork.pl> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiSvH-00022Q-G2 for emacs-orgmode@gnu.org; Tue, 22 Mar 2016 16:29:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aiSvD-0006po-Fn for emacs-orgmode@gnu.org; Tue, 22 Mar 2016 16:29:03 -0400 Received: from mail.mojserwer.eu ([2a01:5e00:2:52::8]:57428) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiSvD-0006oP-87 for emacs-orgmode@gnu.org; Tue, 22 Mar 2016 16:28:59 -0400 In-reply-to: <87pourg252.fsf@mbork.pl> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: Org-Mode mailing list On 2016-03-18, at 17:51, Marcin Borkowski wrote: > I'm now reading org-read-date-analyze to be able to enable US military > format for hours (e.g., 2100 instead of 21:00). This is potentially > very useful (at least for me), since I'll be able to enter the hour with > one hand (colon is on shift-semicolon on my keyboard). Another idea > would be to enable 21.00 (this notation is sometimes used in Poland). > Would there be demand for such a feature? Hi all, and thanks Eric and Sam for positive feedback. It seems that it is harder than I thought. `org-read-date-analyze' relies on `parse-time-string'. It is relatively easy to make the latter function accept both 21.00 and 2100, but the way `org-read-date-analyze' uses `parse-time-string' makes things a bit difficult. So, it will take me a couple of days, I guess. One thing that would tremendously help is tests. I think these functions are rather fragile, in the sense that it's very easy to break something (`parse-time-string' is a total mess, for example - it is "clever", yes, but proving that it actually works seems next to impossible), so without an extensive test suite I wouldn't touch these functions. Does anyone have - or can make - a set of valid (in `org-read-date' sense) strings to make tests first and then modify these functions? (I could make it myself, but I might forget about some cases - and there are a lot of them! And it's even nontrivial to test the coverage, since large part of the `parse-time-string' /logic/ is hidden in the /variable/ `parse-time-rules', which btw has a 1-line docstring...) > Best, Best, -- Marcin Borkowski http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski Faculty of Mathematics and Computer Science Adam Mickiewicz University