emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Michael Strey <mstrey@strey.biz>
To: emacs-orgmode@gnu.org
Subject: [PATCH] org.el: Fix bug from switch to lexical binding
Date: Fri, 08 Apr 2016 14:47:06 +0200	[thread overview]
Message-ID: <8737qwi7xx.fsf@strey.biz> (raw)

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]


Please check carefully before applying!  I do not understand what I have
done here but it worked for me without side effects.

-- 
Michael Strey
_
mailto:mstrey@strey.biz
http://www.strey.biz * https://twitter.com/michaelstrey


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Patch --]
[-- Type: text/x-diff, Size: 1331 bytes --]

From b76d6ef5975e1ba0b5ad4317246e1084d43ff446 Mon Sep 17 00:00:00 2001
From: Michael Strey <mstrey@strey.biz>
Date: Fri, 8 Apr 2016 14:03:30 +0200
Subject: [PATCH] org.el: Fix bug from switch to lexical binding

* lisp/org.el (org-check-dates-range): Fix a bug introduces with the
  switch to lexical binding in commit
  1f49e9fdfd8b527377b5592bd65ad3be6abb9e6a.

This change fixed the following bug:  C-c \ D leads to error message "Symbol's value as variable is void: start-date".

TINYCHANGE
---
 lisp/org.el | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index 4f60c7f..b6d1c2d 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -17489,12 +17489,12 @@ both scheduled and deadline timestamps."
   (let ((case-fold-search nil)
 	(regexp (org-re-timestamp org-ts-type))
 	(callback
-	 `(lambda ()
+	 (lambda ()
 	    (let ((match (match-string 1)))
 	      (and
-	       ,(if (memq org-ts-type '(active inactive all))
-		    '(eq (org-element-type (org-element-context)) 'timestamp)
-		  '(org-at-planning-p))
+	       (if (memq org-ts-type '(active inactive all))
+		    (eq (org-element-type (org-element-context)) 'timestamp)
+		  (org-at-planning-p))
 	       (not (time-less-p
 		     (org-time-string-to-time match)
 		     (org-time-string-to-time start-date)))
-- 
2.7.3


             reply	other threads:[~2016-04-08 12:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-08 12:47 Michael Strey [this message]
2016-04-08 21:13 ` [PATCH] org.el: Fix bug from switch to lexical binding Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8737qwi7xx.fsf@strey.biz \
    --to=mstrey@strey.biz \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).