From: Phil Hudson <phil.hudson@iname.com>
To: emacs-orgmode@gnu.org
Subject: [PATCH 1/2] org-agenda.el: Fix `org-agenda-bulk-custom-functions' supported Customize type
Date: Wed, 11 May 2016 23:00:22 +0100 [thread overview]
Message-ID: <8737po5k7d.fsf@quiz.hudson-it.ddns.net> (raw)
From 256cf1f854e902de392a325ec4b9c8204fb84a21 Mon Sep 17 00:00:00 2001
From: Phil Hudson <phil.hudson@iname.com>
Date: Wed, 11 May 2016 15:34:12 +0100
Subject: [PATCH 1/2] org-agenda.el: Fix `org-agenda-bulk-custom-functions'
supported Customize type
* org-agenda.el (`org-agenda-bulk-custom-functions'): Change the defcustom
template to recognize that the code expects this alist's elements to be
two-element lists like (?a b), not conses like (?a . b). The Customize UI
previously incorrectly presented the latter. When saved, this led to the
agenda bulk-commands menu correctly presenting the accelerator key 'a' but
then erroring when it tried to execute the associated command 'b'.
---
lisp/org-agenda.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index ef41678..ab280fb 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -2008,7 +2008,7 @@ For example, this value makes those two functions available:
With selected entries in an agenda buffer, `B R' will call
the custom function `set-category' on the selected entries.
Note that functions in this alist don't need to be quoted."
- :type 'alist
+ :type '(alist :key-type character :value-type (group function))
:version "24.1"
:group 'org-agenda)
--
2.8.0.rc3
--
Phil Hudson http://hudson-it.ddns.net
@UWascalWabbit PGP/GnuPG ID: 0x887DCA63
next reply other threads:[~2016-05-11 21:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 22:00 Phil Hudson [this message]
2016-05-13 16:03 ` [PATCH 1/2] org-agenda.el: Fix `org-agenda-bulk-custom-functions' supported Customize type Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737po5k7d.fsf@quiz.hudson-it.ddns.net \
--to=phil.hudson@iname.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).