From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hendrik Tews <hendrik@askra.de>
Subject: Re: Bug: right-alignment fails in column view [9.0.7
 (release_9.0.7-439-g2906e5 @ /home/tews/src/org-mode/lisp/)]
Date: Mon, 22 May 2017 14:49:11 +0200
Message-ID: <8737bxjbug.fsf@cert.kernkonzept.com>
References: <877f1e9tw5.fsf@cert.kernkonzept.com>
	<87inkvi8vn.fsf@nicolasgoaziou.fr>
	<87o9uljowp.fsf@cert.kernkonzept.com>
	<87pof1f6a7.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34906)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hendrik@askra.de>) id 1dCmm0-0006Ly-VA
	for emacs-orgmode@gnu.org; Mon, 22 May 2017 08:49:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hendrik@askra.de>) id 1dCmlx-0002Pa-U2
	for emacs-orgmode@gnu.org; Mon, 22 May 2017 08:49:21 -0400
Received: from askra.de ([81.169.225.145]:33636)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <hendrik@askra.de>) id 1dCmlx-0002PL-NW
	for emacs-orgmode@gnu.org; Mon, 22 May 2017 08:49:17 -0400
Received: from ipb218494e.dynamic.kabel-deutschland.de ([178.24.73.78]
	helo=cert)
	by askra.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.84_2) (envelope-from <hendrik@askra.de>) id 1dCmlr-00078W-S4
	for emacs-orgmode@gnu.org; Mon, 22 May 2017 14:49:13 +0200
Received: from localhost ([::1] helo=cert.kernkonzept.com)
	by cert with esmtp (Exim 4.89) (envelope-from <hendrik@askra.de>)
	id 1dCmlr-0005dr-BK
	for emacs-orgmode@gnu.org; Mon, 22 May 2017 14:49:11 +0200
In-Reply-To: <87pof1f6a7.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of
	"Mon, 22 May 2017 14:02:56 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: emacs-orgmode@gnu.org

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> The intent of the check is to warn the user that a columns contains
> invalid values. Applying `string-to-number' unconditionally could give
> strange results for example, with {mean,%.2f}.

I do see your point here. I don't use mean, but it is probably
good to warn users about invalid values for such summary types.
If you intend to warn the user, why don't you use display-warning
or something similar?

However, for {+} the default return value of string-to-number
fits pretty well. Aborting with a user-error here seems a bit
over the top for me. Especially, because there is no indication
what entry caused the error.

> There is no point to have a "TODO" or a "XXX" value in a column
> that is summarized with {+;%.2f}.

I believe it makes a lot of sense to have

  :PROPERTIES:
  :Effort: TODO
  :END:

and the old behavior of treating TODO as 0 in such cases seems
perfect to me.

I believe you should also permit users to make {+} summaries,
when they are not yet finished with annotating all items.
Currently also a missing property cases an error. 

Hendrik