emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Alex Branham <branham@utexas.edu>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] allow users to customize string in org-agenda-time-grid
Date: Mon, 10 Jul 2017 15:39:20 +0200	[thread overview]
Message-ID: <8737a4wgvr.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87a84gir1r.fsf@utexas.edu> (Alex Branham's message of "Fri, 07 Jul 2017 10:34:24 +0200")

Hello,

Alex Branham <branham@utexas.edu> writes:

> Sure, that's possible. Patch attached. 

Thank you.

> Note that this way, users who have set org-agenda-time-grid to a list
> with three elements will see a slightly different agenda now (the
> default "......" will get dropped).

I think this is acceptable if we properly announce it in ORG-NEWS.

> The order of the items in the list is also a bit weird --- they get
> displayed in the order 3, 4, 2. I've updated the docstring to try to
> make this a bit clearer.

True. While we're at making an incompatible change on the variable, do
you think it makes sense to change the order of the parameters?

If so, would you want to update your patch accordingly?

>
> From 12e5561b1df1d86a45e7c418dd7dd44763e52423 Mon Sep 17 00:00:00 2001
> From: Alex Branham <branham@utexas.edu>
> Date: Fri, 7 Jul 2017 10:29:28 +0200
> Subject: [PATCH] org-agenda.el: Allow users to customize string after
>  time-grid
>
> * org-agenda.el: Users may now customize the string to display after

You need to specify the variable being changed, i.e.,

  * lisp/org-agenda.el (org-agenda-time-grid): ...
  
Could you provide an ORG-NEWS entry, too?


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2017-07-10 13:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-07  6:37 [PATCH] allow users to customize string in org-agenda-time-grid Alex Branham
2017-07-07  7:32 ` Nicolas Goaziou
2017-07-07  8:34   ` Alex Branham
2017-07-10 13:39     ` Nicolas Goaziou [this message]
2017-07-11  6:21       ` Alex Branham
2017-07-11  8:05         ` Nicolas Goaziou
2017-07-10 20:02 ` Samuel Wales
2017-07-11  6:16   ` Alex Branham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8737a4wgvr.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=branham@utexas.edu \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).