From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH 3/4] ob-clojure.el: Use :ns flag in org-src-edit
Date: Mon, 23 Apr 2018 11:26:49 +0200
Message-ID: <8736zm6zom.fsf@nicolasgoaziou.fr>
References: <20180422205003.87836-1-roberthambrock@gmail.com>
	<20180422205003.87836-4-roberthambrock@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35800)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1fAXkQ-00017v-HF
	for emacs-orgmode@gnu.org; Mon, 23 Apr 2018 05:26:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1fAXkL-0005Mt-Hm
	for emacs-orgmode@gnu.org; Mon, 23 Apr 2018 05:26:58 -0400
Received: from relay1-d.mail.gandi.net ([217.70.183.193]:54881)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1fAXkL-0005KR-BA
	for emacs-orgmode@gnu.org; Mon, 23 Apr 2018 05:26:53 -0400
In-Reply-To: <20180422205003.87836-4-roberthambrock@gmail.com>
	(roberthambrock@gmail.com's message of "Sun, 22 Apr 2018 22:50:02
	+0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: roberthambrock@gmail.com
Cc: emacs-orgmode@gnu.org

Hello,

roberthambrock@gmail.com writes:

> * lisp/ob-clojure.el (org-babel-edit-prep:clojure): New function that
> sets the buffer's namespace to the value of :ns, if provided.
> (org-babel-edit-prep:clojurescript): Alias for
> org-babel-edit-prep:clojure.

Thank you.

> +(defun org-babel-edit-prep:clojure (babel-info)
> +  (if-let* ((namespace (cdr (assq :ns (nth 2 babel-info)))))
> +      (setq-local cider-buffer-ns namespace)))

Missing docstring. Also, please avoid `if-let*', which is non-standard,
AFAIK. You can use `pcase' however.

Regards,

-- 
Nicolas Goaziou