Re: Link "bracket-types"

[Nicolas Goaziou <mail@nicolasgoaziou.fr>]

[-- Attachment #1: Type: text/plain, Size: 1047 bytes --]

Michael Brand <michael.ch.brand@gmail.com> writes:

> Do you mean here attached and updated as of today?

I meant to attach it, but apparently forgot. I attach it here for other feedback.

> Currently we disagree in that you suggest one bracket where I prefer
> none for descriptive links and you suggest one bracket where I prefer
> two for the other cases, see rendering examples and my reasons for raw
> plain text in non-Org tools above.

Indeed, we disagree. I find your suggestion not predictable enough.
Sometimes square brackets appear, sometimes not... Besides, it doesn't
solve the issue my suggestion was initially trying to solve.

> If there would be an option to show 0 (current behavior), 1 (your
> suggestion) or 2 brackets (new) everywhere I could use 2 as
> a compromise. If the option 0, 1 or 2 would be individual for case
> 1 and for case 3/4 that would of course be perfect at least for me.

It's a matter of taste. Showing 2 square brackets doesn't bring much
value, IMO.

Anyway, we might need more feedback on the topic.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: partial link visibility --]
[-- Type: text/x-diff, Size: 1347 bytes --]

From 9e49be14b86a359cd4ea834763c697349eba0d2f Mon Sep 17 00:00:00 2001
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Date: Fri, 11 May 2018 14:59:33 +0200
Subject: [PATCH] Add `partial' to `org-descriptive-link'

* lisp/org.el (org-activate-links): Handle `partial' value.
---
 lisp/org.el | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index 2cfe46697..bf1e19f36 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -5914,8 +5914,17 @@ This includes angle, plain, and bracket links."
 			       ,(or (org-link-get-parameter type :display)
 				    'org-link))
 			     properties))
-		    (visible-start (or (match-beginning 4) (match-beginning 2)))
-		    (visible-end (or (match-end 4) (match-end 2))))
+		    (visible-start
+		     (pcase org-descriptive-links
+		       (`nil start)
+		       (`partial (or (match-beginning 3)
+				     (1- (match-beginning 2))))
+		       (_ (or (match-beginning 4) (match-beginning 2)))))
+		    (visible-end
+		     (pcase org-descriptive-links
+		       (`nil end)
+		       (`partial (or (match-end 3) (1+ (match-end 2))))
+		       (_ (or (match-end 4) (match-end 2))))))
 		(add-text-properties start visible-start hidden)
 		(add-text-properties visible-start visible-end properties)
 		(add-text-properties visible-end end hidden)
-- 
2.17.0