* Bug: javascript license not recognized by librejs [9.2.6 (9.2.6-elpa @ /home/arne/.guix-profile/share/emacs/site-lisp/guix.d/org-9.2.6/)]
@ 2019-11-02 22:08 Arne Babenhauserheide
2019-11-03 21:21 ` Nicolas Goaziou
2020-02-11 8:47 ` Bastien
0 siblings, 2 replies; 4+ messages in thread
From: Arne Babenhauserheide @ 2019-11-02 22:08 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 3554 bytes --]
Remember to cover the basics, that is, what you expected to happen and
what in fact did happen. You don't know how to make a good report? See
https://orgmode.org/manual/Feedback.html#Feedback
Your bug report will be posted to the Org mailing list.
------------------------------------------------------------------------
The javascript license notice by org-mode is not recognized by librejs.
example:
/*
@licstart The following is the entire license notice for the
JavaScript code in this tag.
Copyright (C) 2012-2019 Free Software Foundation, Inc.
The JavaScript code in this tag is free software: you can
redistribute it and/or modify it under the terms of the GNU
General Public License (GNU GPL) as published by the Free Software
Foundation, either version 3 of the License, or (at your option)
any later version. The code is distributed WITHOUT ANY WARRANTY;
without even the implied warranty of MERCHANTABILITY or FITNESS
FOR A PARTICULAR PURPOSE. See the GNU GPL for more details.
As additional permission under GNU GPL version 3 section 7, you
may distribute non-source (e.g., minimized or compacted) forms of
that code without the copy of the GNU GPL normally required by
section 4, provided you include this license notice and a URL
through which recipients can access the Corresponding Source.
@licend The above is the entire license notice
for the JavaScript code in this tag.
*/
<!--/*--><![CDATA[/*><!--*/
function CodeHighlightOn(elem, id)
{
var target = document.getElementById(id);
if(null != target) {
elem.cacheClassElem = elem.className;
elem.cacheClassTarget = target.className;
target.className = "code-highlighted";
elem.className = "code-highlighted";
}
}
function CodeHighlightOff(elem, id)
{
var target = document.getElementById(id);
if(elem.cacheClassElem)
elem.className = elem.cacheClassElem;
if(elem.cacheClassTarget)
target.className = elem.cacheClassTarget;
}
/*]]>*///-->
To get this recognized, it could use magnet-style license definition:
// @license magnet:?xt=urn:btih:1f739d935676111cfff4b4693e3816e664797050&dn=gpl-3.0.txt GPL-v3-or-Later
<!--/*--><![CDATA[/*><!--*/
function CodeHighlightOn(elem, id)
{
var target = document.getElementById(id);
if(null != target) {
elem.cacheClassElem = elem.className;
elem.cacheClassTarget = target.className;
target.className = "code-highlighted";
elem.className = "code-highlighted";
}
}
function CodeHighlightOff(elem, id)
{
var target = document.getElementById(id);
if(elem.cacheClassElem)
elem.className = elem.cacheClassElem;
if(elem.cacheClassTarget)
target.className = elem.cacheClassTarget;
}
/*]]>*///-->
// @license-end
This would also have the advantage of being shorter.
See https://www.gnu.org/software/librejs/free-your-javascript.html#magnet-link-license
Best wishes,
Arne
Emacs : GNU Emacs 26.1 (build 1, x86_64-unknown-linux-gnu, GTK+ Version 3.24.0)
of 2019-01-22
Package: Org mode version 9.2.6 (9.2.6-elpa @ /home/arne/.guix-profile/share/emacs/site-lisp/guix.d/org-9.2.6/)
--
Unpolitisch sein
heißt politisch sein
ohne es zu merken
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 1076 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Bug: javascript license not recognized by librejs [9.2.6 (9.2.6-elpa @ /home/arne/.guix-profile/share/emacs/site-lisp/guix.d/org-9.2.6/)]
2019-11-02 22:08 Bug: javascript license not recognized by librejs [9.2.6 (9.2.6-elpa @ /home/arne/.guix-profile/share/emacs/site-lisp/guix.d/org-9.2.6/)] Arne Babenhauserheide
@ 2019-11-03 21:21 ` Nicolas Goaziou
2020-02-11 8:47 ` Bastien
1 sibling, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2019-11-03 21:21 UTC (permalink / raw)
To: Arne Babenhauserheide; +Cc: emacs-orgmode
Hello,
Arne Babenhauserheide <arne_bab@web.de> writes:
> The javascript license notice by org-mode is not recognized by
> librejs.
Would you want to provide a patch for that?
Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Bug: javascript license not recognized by librejs [9.2.6 (9.2.6-elpa @ /home/arne/.guix-profile/share/emacs/site-lisp/guix.d/org-9.2.6/)]
2019-11-02 22:08 Bug: javascript license not recognized by librejs [9.2.6 (9.2.6-elpa @ /home/arne/.guix-profile/share/emacs/site-lisp/guix.d/org-9.2.6/)] Arne Babenhauserheide
2019-11-03 21:21 ` Nicolas Goaziou
@ 2020-02-11 8:47 ` Bastien
2020-02-11 21:53 ` Arne Babenhauserheide
1 sibling, 1 reply; 4+ messages in thread
From: Bastien @ 2020-02-11 8:47 UTC (permalink / raw)
To: Arne Babenhauserheide; +Cc: emacs-orgmode
Hi Arne,
this is fixed in the master branch -- not in maint, as this is just
a (welcome) enhancement.
Thanks for suggesting this.
--
Bastien
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Bug: javascript license not recognized by librejs [9.2.6 (9.2.6-elpa @ /home/arne/.guix-profile/share/emacs/site-lisp/guix.d/org-9.2.6/)]
2020-02-11 8:47 ` Bastien
@ 2020-02-11 21:53 ` Arne Babenhauserheide
0 siblings, 0 replies; 4+ messages in thread
From: Arne Babenhauserheide @ 2020-02-11 21:53 UTC (permalink / raw)
To: Bastien; +Cc: emacs-orgmode
Hi Bastien,
Thank you very much!
Best wishes,
Arne
Bastien <bzg@gnu.org> writes:
> Hi Arne,
>
> this is fixed in the master branch -- not in maint, as this is just
> a (welcome) enhancement.
>
> Thanks for suggesting this.
--
Unpolitisch sein
heißt politisch sein
ohne es zu merken
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-11 21:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-02 22:08 Bug: javascript license not recognized by librejs [9.2.6 (9.2.6-elpa @ /home/arne/.guix-profile/share/emacs/site-lisp/guix.d/org-9.2.6/)] Arne Babenhauserheide
2019-11-03 21:21 ` Nicolas Goaziou
2020-02-11 8:47 ` Bastien
2020-02-11 21:53 ` Arne Babenhauserheide
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).