From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] Fix verbatim block fontification to end blocks on headlines Date: Sat, 14 Dec 2019 15:45:00 +0100 Message-ID: <8736dnq843.fsf@nicolasgoaziou.fr> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:40029) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1igElf-0001De-1a for emacs-orgmode@gnu.org; Sat, 14 Dec 2019 16:16:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1igEld-00039s-N7 for emacs-orgmode@gnu.org; Sat, 14 Dec 2019 16:16:02 -0500 Received: from mslow2.mail.gandi.net ([217.70.178.242]:55182) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1igEld-000363-H0 for emacs-orgmode@gnu.org; Sat, 14 Dec 2019 16:16:01 -0500 Received: from relay1-d.mail.gandi.net (unknown [217.70.183.193]) by mslow2.mail.gandi.net (Postfix) with ESMTP id E95D53B2A3E for ; Sat, 14 Dec 2019 14:45:28 +0000 (UTC) In-Reply-To: (Tom Gillespie's message of "Fri, 13 Dec 2019 15:25:17 -0800") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Tom Gillespie Cc: emacs-orgmode@gnu.org Hello, Tom Gillespie writes: > I've written some basic tests for this and I couldn't find any other > tests that seemed to deal with fontification at all. In order to get > fontification tests to work I added a call to `font-lock-ensure' inside > `org-test-with-temp-text' (see excerpted patch bit below). Given how > frequently `org-test-with-temp-text' is used, does it make sense to > create a separate version of that macro just for testing with > fontification? I have no idea what the performance impact would be, so > any guidance is appreciated. FWIW, I simply suggest not bothering writing tests for fontification. Regards, -- Nicolas Goaziou