emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: Kevin Foley <kevin@kevinjfoley.me>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix `org-babel-detangle' handling of false positives
Date: Sat, 01 Feb 2020 10:22:24 +0100	[thread overview]
Message-ID: <8736buek6n.fsf@gnu.org> (raw)
In-Reply-To: <m2k15bnpef.fsf@Kevins-MBP.home.lan> (Kevin Foley's message of "Tue, 28 Jan 2020 18:15:52 -0500")

Hi Kevin,

this looks good.  The patch is significant enough that we need you to
sign the FSF copyright assignment papers.  Here is the form:


Once you're done with this, we can push your commit.

Should you contribute more, we can give you push access.

Some comments below:

Foley <kevin@kevinjfoley.me> writes:

> This patch fixes the way `org-babel-detangle' handles false positive
> matches for links.  Without the patch it tries to use match data that
> may not be present in a false positive.  I've also included a regression
> test.
> This is my first contribution to Org Mode or Emacs and my first patch
> by mailing list so please let me know if I've overlooked anything.
> Also note I have not assigned copyright to FSF at this time, however I
> believe this change should be small enough to not require it.
> Kevin Foley
> From 82e2d108536101c5a5ff9f8a0009051e5a308a3a Mon Sep 17 00:00:00 2001
> From: "Kevin J. Foley" <kevin@kevinjfoley.me>
> Date: Tue, 28 Jan 2020 17:51:29 -0500
> Subject: [PATCH] Fix `org-babel-detangle' handling of false positives
> * lisp/ob-tangle.el (org-babel-detangle): Handle false positive
> matches of `org-link-bracket-re'
                                  There should be a "." at the end of
                                  sentences in changelog entries.

> * testing/examples/babel.el: New file for babel detangle false
> positive test
               Same here.

> * testing/examples/babel.org (detangle): Add detangle/false positive
> example
         And here.

> * testing/lisp/test-ob-tangle.el (ob-tangle/detangle-false-positive):
> Add test for detangle false positive
                                      ^ And here.

Well, there are more than 15 lines of changes.  Signing the FSF papers
will allow you to submit more changes later.



  reply	other threads:[~2020-02-01  9:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-28 23:15 [PATCH] Fix `org-babel-detangle' handling of false positives Kevin Foley
2020-02-01  9:22 ` Bastien [this message]
2020-02-09 16:24   ` Kevin Foley
2020-02-10  6:22     ` Bastien
2020-05-22 14:37       ` Kevin Foley
2020-05-22 15:36         ` Bastien
2020-05-24 12:30           ` Kevin Foley
2020-05-24 13:46             ` Bastien
2020-05-24 16:17               ` Kyle Meyer
2020-05-24 18:14                 ` Kevin Foley
2020-05-24 20:19                   ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8736buek6n.fsf@gnu.org \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=kevin@kevinjfoley.me \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).