emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: "Christoffer Stjernlöf" <a@xkqr.org>, mail@nicolasgoaziou.fr
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ox.el: Fix extra character deleted in org-export--update-included-link
Date: Tue, 11 Feb 2020 16:55:13 +0100	[thread overview]
Message-ID: <8736bhqftq.fsf@gnu.org> (raw)
In-Reply-To: <86tv7lm79g.fsf@xkqr.org> ("Christoffer Stjernlöf"'s message of "Sun, 03 Nov 2019 14:14:35 +0100")

Hi Christoffer and Nicolas,

thanks for your patch.

a@xkqr.org (Christoffer Stjernlöf) writes:

> * ox.el (org-export--update-included-link): Fix bug.
> (org-export--update-included-link): Delete region only until one less
> than (org-element-property :end link).

Nicolas, does it look good to you?  The patch passes all the test but
probably they don't cover edge cases about link insertion/updating.

Thanks,

-- 
 Bastien

  reply	other threads:[~2020-02-11 15:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-03 13:14 [PATCH] ox.el: Fix extra character deleted in org-export--update-included-link Christoffer Stjernlöf
2020-02-11 15:55 ` Bastien [this message]
2020-02-11 18:15   ` Nicolas Goaziou
2020-02-13  8:12     ` Bastien
2020-02-13 10:25       ` Nicolas Goaziou
2020-02-13 11:01         ` Bastien
2020-02-13 19:07           ` Adam Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8736bhqftq.fsf@gnu.org \
    --to=bzg@gnu.org \
    --cc=a@xkqr.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).