Bug: org-agenda-tag-filter-preset not respected [9.3.6 (9.3.6-19-gf360f9-elpaplus @ /home/jorge/.config/emacs/elpa/27.0/develop/org-plus-contrib-20200302/)]

Bug: org-agenda-tag-filter-preset not respected [9.3.6 (9.3.6-19-gf360f9-elpaplus @ /home/jorge/.config/emacs/elpa/27.0/develop/org-plus-contrib-20200302/)]

[Jorge P. de Morais Neto]

Hi.  Since version org-plus-contrib-20200302, my agenda is buggy.  The
bug did not occur in previous versions.  To reproduce the bug:

1. Move away your .emacs.d, so that Emacs starts with a pristine
   configuration.
2. Start Emacs and eval the following Elisp:
--8<---------------cut here---------------start------------->8---
(setq package-archives
      '(("org" . "https://orgmode.org/elpa/")
       ("gnu" . "https://elpa.gnu.org/packages/")))
(setq org-agenda-custom-commands
      '(("w" "Buggy"
	((tags "now" nil))
	((org-agenda-tag-filter-preset
	  '("+@w" "-dummy"))))))
(setq org-agenda-files '("~/unison/report_org-agenda_bug/report_org_bug.org"))
(setq org-tag-alist
 '(("now"     . ?n)
   ("dummy")
   ("@w"      . ?w)))
--8<---------------cut here---------------end--------------->8---

3. Install the latest org-plus-contrib package.
4. Write to ~/unison/report_org-agenda_bug/report_org_bug.org the
   following text:
--8<---------------cut here---------------start------------->8---
* This entry should not appear in the agenda                            :now:
--8<---------------cut here---------------end--------------->8---

5. Execute M-x org-agenda RET w
6. Note that the offending entry does appear in the agenda.  It should
   not appear, since it lacks the "@w" tag -- see the value of
   org-agenda-tag-filter-preset.

This occurred in an updated Emacs 27 snapshot (guix package emacs-next).

Regards

------------------------------------------------------------------------
Emacs  : GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.13)
Package: Org mode version 9.3.6 (9.3.6-19-gf360f9-elpaplus @ /home/jorge/.config/emacs/elpa/27.0/develop/org-plus-contrib-20200302/)
-- 
- <https://jorgemorais.gitlab.io/justice-for-rms/>
- I am Brazilian.  I hope my English is correct and I welcome feedback.
- Free Software Supporter:
  <https://www.fsf.org/free-software-supporter/subscribe>

Re: Bug: org-agenda-tag-filter-preset not respected [9.3.6 (9.3.6-19-gf360f9-elpaplus @ /home/jorge/.config/emacs/elpa/27.0/develop/org-plus-contrib-20200302/)]

[Jorge P. de Morais Neto]

Em [2020-03-06 sex 09:06:35-0300], Jorge P. de Morais Neto escreveu:

> Hi.  Since version org-plus-contrib-20200302, my agenda is buggy.  The
> bug did not occur in previous versions.

Actually, I realized the bug occurs since org-plus-contrib-20200224.

Regards.
-- 
- <https://jorgemorais.gitlab.io/justice-for-rms/>
- I am Brazilian.  I hope my English is correct and I welcome feedback.
- <https://www.defectivebydesign.org/>
- <https://www.gnu.org/>

Re: Bug: org-agenda-tag-filter-preset not respected [9.3.6 (9.3.6-19-gf360f9-elpaplus @ /home/jorge/.config/emacs/elpa/27.0/develop/org-plus-contrib-20200302/)]

[Jorge P. de Morais Neto]

Em [2020-03-09 seg 20:36:33-0300], Jorge P. de Morais Neto escreveu:

> Em [2020-03-06 sex 09:06:35-0300], Jorge P. de Morais Neto escreveu:
>
>> Hi.  Since version org-plus-contrib-20200302, my agenda is buggy.  The
>> bug did not occur in previous versions.
>
> Actually, I realized the bug occurs since org-plus-contrib-20200224.

Hi.  I am sorry for insisting, but this bug report is a month old and
has not been added to <https://orgmode.org/worg/org-issues.html>.  I
have just tested and reproduced it with Emacs 27 -- emacs-27
branch, snapshot from [2020-04-04 sáb] -- and org-plus-contrib 20200406.

In this situation, is it OK to remind you of the bug every month?  I
honestly do not know the netiquette about this.

Regards
-- 
- <https://jorgemorais.gitlab.io/justice-for-rms/>
- I am Brazilian.  I hope my English is correct and I welcome feedback.
- <https://www.defectivebydesign.org/>
- <https://www.gnu.org/>

Re: Bug: org-agenda-tag-filter-preset not respected [9.3.6 (9.3.6-19-gf360f9-elpaplus @ /home/jorge/.config/emacs/elpa/27.0/develop/org-plus-contrib-20200302/)]

[Nicolas Goaziou]

Hello,

Jorge P. de Morais Neto <jorge+list@disroot.org> writes:

> Hi.  I am sorry for insisting, but this bug report is a month old and
> has not been added to <https://orgmode.org/worg/org-issues.html>.

AFAIK, this file is not maintained anymore.

Note that it strength was not the HTML report, but the fact that you
could import the Org counterpart in your agenda files.

> I have just tested and reproduced it with Emacs 27 -- emacs-27 branch,
> snapshot from [2020-04-04 sáb] -- and org-plus-contrib 20200406.
>
> In this situation, is it OK to remind you of the bug every month?

Certainly. 

Unfortunately, no one volunteered to fix the issue so far. You may want
to have a look at it, you will certainly get help doing so. Otherwise,
you are welcome to bump the report from time to time.

Regards,

-- 
Nicolas Goaziou

Re: Bug: org-agenda-tag-filter-preset not respected [9.3.6 (9.3.6-19-gf360f9-elpaplus @ /home/jorge/.config/emacs/elpa/27.0/develop/org-plus-contrib-20200302/)]

[Kyle Meyer]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Unfortunately, no one volunteered to fix the issue so far. You may want
> to have a look at it, you will certainly get help doing so. Otherwise,
> you are welcome to bump the report from time to time.

This bisects to 7e52b7661 (org-agenda: Fix logic of
`org-agenda-filter-make-matcher', 2020-02-19).  Jorge, I tested the
patch below against the test case you provided, though of course
confirmation that it resolves the issue on your end would be
appreciated.

I'll apply it tomorrow unless there are objections.

-- >8 --
Subject: [PATCH] agenda: Fix regression in handling of non-caterory filters

* lisp/org-agenda.el (org-agenda-filter-make-matcher): Combine filter
forms with `and' unless multiple positive categories are given.

06cf532f4 (org-agenda.el: Fix bug when using category filters,
2020-01-20) modified org-agenda-filter-make-matcher to group the form
with `or' rather than `and' for category filters.  This logic was
tweaked again in a follow-up commit, 7e52b7661 (org-agenda: Fix logic
of `org-agenda-filter-make-matcher', 2020-02-19), which was supposed
to restrict the use of `or' to _multiple_ positive categories.
However, the follow-up commit incorrectly affected all filter types.
Avoid the check for non-category types.

Also, fix the regexp so that it matches whenever there are multiple
positive categories, not just a single one.
---

  * I'm tempted to drop the multi-pos-cats binding and move the
    expression in line.  I may do that before applying.

  * I'm not really sure what the behavior should be when there are
    multiple "+"s and at least one "-".  I doubt that there's much
    sensible to do here, or that it matters one way or the other.

 lisp/org-agenda.el | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index d89a3da7c..ffb892b0c 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -7948,8 +7948,10 @@ (defun org-agenda-filter-make-matcher (filter type &optional expand)
 argument EXPAND can be used for the TYPE tag and will expand the
 tags in the FILTER if any of the tags in FILTER are grouptags."
   (let ((multi-pos-cats
-	 (string-match-p "\++"
-	  (mapconcat (lambda (cat) (substring cat 0 1)) filter "")))
+	 (and (eq type 'category)
+	      (string-match-p "\\+.*\\+"
+			      (mapconcat (lambda (cat) (substring cat 0 1))
+					 filter ""))))
 	f f1)
     (cond
      ;; Tag filter
-- 
2.26.0

Re: Bug: org-agenda-tag-filter-preset not respected [9.3.6 (9.3.6-19-gf360f9-elpaplus @ /home/jorge/.config/emacs/elpa/27.0/develop/org-plus-contrib-20200302/)]

[Kyle Meyer]

Kyle Meyer <kyle@kyleam.com> writes:

> Subject: [PATCH] agenda: Fix regression in handling of non-caterory filters

Applied to maint (561e9efd0).

Re: Bug: org-agenda-tag-filter-preset not respected [9.3.6 (9.3.6-19-gf360f9-elpaplus @ /home/jorge/.config/emacs/elpa/27.0/develop/org-plus-contrib-20200302/)]

[Jorge P. de Morais Neto]

Hi.

Em [2020-04-07 ter 03:33:33+0000], Kyle Meyer escreveu:

> This bisects to 7e52b7661 (org-agenda: Fix logic of
> `org-agenda-filter-make-matcher', 2020-02-19).  Jorge, I tested the
> patch below against the test case you provided, though of course
> confirmation that it resolves the issue on your end would be
> appreciated.

The patch seems to have solved the issue here.  My agenda looks OK with
the latest Org (plus the patch) again.

Thank you!
-- 
- <https://jorgemorais.gitlab.io/justice-for-rms/>
- I am Brazilian.  I hope my English is correct and I welcome feedback.
- Free Software Supporter:
  <https://www.fsf.org/free-software-supporter/subscribe>

Re: Bug: org-agenda-tag-filter-preset not respected [9.3.6 (9.3.6-19-gf360f9-elpaplus @ /home/jorge/.config/emacs/elpa/27.0/develop/org-plus-contrib-20200302/)]

[Jorge P. de Morais Neto]

Hi.  

Em [2020-04-06 seg 18:20:43+0200], Nicolas Goaziou escreveu:

> AFAIK, this file is not maintained anymore.
>
> Note that it strength was not the HTML report, but the fact that you
> could import the Org counterpart in your agenda files.
> [...]
> You may want to have a look at it, you will certainly get help doing
> so.  Otherwise, you are welcome to bump the report from time to time.

Thank you for the clarification Nicolas.

Regards
-- 
- <https://jorgemorais.gitlab.io/justice-for-rms/>
- I am Brazilian.  I hope my English is correct and I welcome feedback.
- Please adopt free/libre formats like PDF, ODF, Org, LaTeX, Opus, WebM and 7z.
- Free/libre software for Replicant, LineageOS and Android: https://f-droid.org
- [[https://www.gnu.org/philosophy/free-sw.html][What is free software?]]

Re: Bug: org-agenda-tag-filter-preset not respected [9.3.6 (9.3.6-19-gf360f9-elpaplus @ /home/jorge/.config/emacs/elpa/27.0/develop/org-plus-contrib-20200302/)]

[Bastien]

Kyle Meyer <kyle@kyleam.com> writes:

> * lisp/org-agenda.el (org-agenda-filter-make-matcher): Combine filter
> forms with `and' unless multiple positive categories are given.

Thanks Jorge for reporting this and Kyle for fixing my mistakes here!

-- 
 Bastien