From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id +SS+Kkwnml9iJAAA0tVLHw (envelope-from ) for ; Thu, 29 Oct 2020 02:22:04 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id qNRrJkwnml88TwAA1q6Kng (envelope-from ) for ; Thu, 29 Oct 2020 02:22:04 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A63519401CD for ; Thu, 29 Oct 2020 02:22:03 +0000 (UTC) Received: from localhost ([::1]:47312 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXxZh-00030b-Uh for larch@yhetil.org; Wed, 28 Oct 2020 22:22:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36346) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXxZI-00030A-7l for emacs-orgmode@gnu.org; Wed, 28 Oct 2020 22:21:36 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:60188) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXxZD-0006Cu-OO for emacs-orgmode@gnu.org; Wed, 28 Oct 2020 22:21:35 -0400 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id C7080767FD; Wed, 28 Oct 2020 22:21:27 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=zKPgaj2KFuL2 NsTn/oh+d3FoX/k=; b=sbIRd+3bDqWymUyye0e5UuxP2rbOUPoHQ9sKqH+rmW6k CLHLhZheXsXF6tYDgFBQ8ULF+EbEX7WUFVcEQe/k1Vm3ko9G09w6Zd52tO4oKHOe uz5xNhB5O1E7w0dIE1dYe7Wnfm4CYVTTvccsThLe8dh+ewRzCGG91LITmQz2I5Y= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id BF733767FC; Wed, 28 Oct 2020 22:21:27 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type:content-transfer-encoding; s=mesmtp; bh=8hzGGAewN2XhWXNrg4UUQqAkkUD39sC67zMiuc3VfSk=; b=QIH6GVsxRQd3WmVjF4CUaWTAib++s8JHSGKb6WPMw7rMvYCUHuSORjChQhlrRLw111nIyp+M8i2DV3VGKY9OjbIGY0vJc6v+oIMrhaaisF+9DxnOHAr2xC36ch8MoxChrnNdr56xPR25QH4tNk/774SCApAdUbgIBejvgndojwk= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 43C9A767F9; Wed, 28 Oct 2020 22:21:27 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: =?utf-8?Q?Micha=C3=ABl?= Cadilhac Subject: Re: Proposal: do not align tags in Agenda In-Reply-To: References: <87lfgsq6l5.fsf@kyleam.com> Date: Wed, 28 Oct 2020 22:21:26 -0400 Message-ID: <87361xvkk9.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Pobox-Relay-ID: 72DA85C6-198D-11EB-9374-74DE23BA3BAF-24757444!pb-smtp2.pobox.com Received-SPF: pass client-ip=64.147.108.71; envelope-from=kyle@kyleam.com; helo=pb-smtp2.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/28 21:36:02 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Org-Mode mailing list , No Wayman Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=sbIRd+3b; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=QIH6GVsx; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: 44s/s9X6vjcm Micha=C3=ABl Cadilhac writes: > My problem wasn't at all, as you point out, that the tag would erase the = entry. > > It has to do with habits: The habit graph overwrites anything else. I > like having org-agenda-tags-column to a low value (wide screen), but > tags are crucial to my workflow, so them being overwritten is > problematic. > > My previous patch is completely overkill for that purpose (it's even > misguided since it does stem from a misunderstanding of tags > alignment). Here's a simpler patch. It may be a matter of taste, > though. I see (and sorry for the slow reply). I've never used habits, but that does sound good to avoid. Would you mind 1) wrapping the change below into a patch (see ) and 2) providing a minimal example like the one in my last reply so that reviewers have something to quickly test? No Wayman, I see that you replied [1] that your patch at would allow working around this issue [2], but do you still think the change below is a good idea? Thanks. [1] Note that it's detached from this thread because the References and In-Reply-To headers weren't preserved. [2] Sorry that that patch hasn't gotten any attention yet. > diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el > index e4a334dbd..a80123853 100644 > --- a/lisp/org-agenda.el > +++ b/lisp/org-agenda.el > @@ -9080,6 +9080,10 @@ current line." > (goto-char (match-beginning 1)) > (delete-region (save-excursion (skip-chars-backward " \t") (point)) > (point)) > + (when (get-text-property (point) 'org-habit-p) > + (setq c (max c (+ 1 org-habit-graph-column > + org-habit-preceding-days > + org-habit-following-days)))) I haven't applied this to check, but I suspect you'll need some amount of guarding (e.g. with boundp) to silence the byte-compiler here. > (insert (org-add-props > (make-string (max 1 (- c (current-column))) ?\s) > (plist-put (copy-sequence (text-properties-at (point)))