From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QHhlBUwmrl9rGAAA0tVLHw (envelope-from ) for ; Fri, 13 Nov 2020 06:23:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id yFkyAUwmrl8oGwAA1q6Kng (envelope-from ) for ; Fri, 13 Nov 2020 06:23:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 50B6394043A for ; Fri, 13 Nov 2020 06:23:07 +0000 (UTC) Received: from localhost ([::1]:43946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdSUD-00064t-Th for larch@yhetil.org; Fri, 13 Nov 2020 01:23:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41264) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdSTp-00064d-Iu for emacs-orgmode@gnu.org; Fri, 13 Nov 2020 01:22:41 -0500 Received: from pb-smtp2.pobox.com ([64.147.108.71]:55199) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdSTl-0004by-Qh; Fri, 13 Nov 2020 01:22:40 -0500 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id DA03EAE866; Fri, 13 Nov 2020 01:22:34 -0500 (EST) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=3fe/ve0IDVuU PwtmDBEYQukTLGY=; b=WZnUortzKHEsa2K53L2ikcDc3FAhqJG4J2YmlsVQP3Nb uFWQVxaHpIdZrFH/rYPk+58U0e07piaiMXNLgmfvh+tyq6TGrOhKMceTGEl+vs2b g2b5S0keGj2zd7Pj8PhlC5EHE8Kq6TpmUBfQu4iXwKU6ZpVo1GDuO7QSZYwKf7A= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id D2C98AE865; Fri, 13 Nov 2020 01:22:34 -0500 (EST) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type:content-transfer-encoding; s=mesmtp; bh=HRs6eJxg1vOvIXK0WpDflwBINDojJiaS/EHTfu18bNg=; b=q4WaxZt+SYbfmDAGo6yoJt1Cv0HabhHV42/gcWzaNun6HlQkGRhq7YrlXe2c+1/i8fe3CbKUQpABIcV9cZa12qOolehmL9+G085A9Ui/KFjEv7iEEbf21jNm13DFI5vOSC85EDG5jZxzarKYP/tGXl9+2tV6Xq0gi518+pPJXYI= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 59CF9AE864; Fri, 13 Nov 2020 01:22:34 -0500 (EST) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: James N V Cash Subject: Re: tags-todo agenda shoud not ignore DONE items In-Reply-To: <87tuvyaopv.fsf@gmail.com> References: <87tuvyaopv.fsf@gmail.com> Date: Fri, 13 Nov 2020 01:22:33 -0500 Message-ID: <87361d7p3q.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Pobox-Relay-ID: 9E1BB646-2578-11EB-ADB1-74DE23BA3BAF-24757444!pb-smtp2.pobox.com Received-SPF: pass client-ip=64.147.108.71; envelope-from=kyle@kyleam.com; helo=pb-smtp2.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/13 01:22:35 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastien , emacs-orgmode@gnu.org, stig@brautaset.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=WZnUortz; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=q4WaxZt+; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: ZDsquQXrW5y9 [ Sorry for the slow reply here, and thank you for looking into this. ] James N V Cash writes: > Bastien writes: > >> Confirming this as an issue, if someone wants to fix it. > > I've tried taking a shot at addressing this issue via the patch attached. > > As mentioned in the thread, might potentially cause issues by changing > how it matches -- should there be an option? Or is the idea just that > if you really do want to exclude done tags, you'd query like "/!DONE"? Yep, that's the idea, I think. It's mentioned in both 942b6267a (org-agenda: `tags-todo' command type includes DONE keywords, 2017-04-18) and 2fb129b5c (`org-scan-tags' retrieve all TODO keywords, not only not-done ones, 2017-08-17). > > diff --git a/lisp/org.el b/lisp/org.el > index 020cfc873..3db1add8b 100644 > --- a/lisp/org.el > +++ b/lisp/org.el > @@ -11691,7 +11691,7 @@ See also `org-scan-tags'." > `(and ,tagsmatcher ,todomatcher) > (or tagsmatcher todomatcher t)))) > (when org--matcher-tags-todo-only > - (setq matcher `(and (member todo org-not-done-keywords) ,matcher))) > + (setq matcher `(and (member todo org-todo-keywords-1) ,matcher))) > (cons match0 `(lambda (todo tags-list level) ,matcher))))) >=20=20 > (defun org--tags-expand-group (group tag-groups expanded) This does resolve the reported issue with the b tags-todo set reported in . However, it breaks the org-tags-view todo-only operation (agenda's M): it no longer filters out todos in a DONE state. This behavior is explicitly specified in the manual: Using =E2=80=98M-x org-agenda M=E2=80=99 or =E2=80=98/!=E2=80=99 does not= match TODO keywords in a DONE state. In , I asked, "shouldn't tags-todo consider only none-DONE todo items, in the same spirit as m versus M?" And, looking at this again, it's not only in spirit; the tags-todo agenda view and org-tags-view's todo-only are really directly linked: ((eq type 'tags-todo) (org-let lprops '(org-tags-view '(4) org-match))) After rereading the thread at m2ftazm3l1.fsf@brautaset.org, I'm still not convinced we should break that link.