emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Pierre Langlois <pierre.langlois@gmx.com>
Cc: Bastien <bzg@gnu.org>,
	emacs-orgmode@gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: Re: Bug: (org-release) returns empty string on Elpa [ ( @ /home/pierre/.guix-profile/share/emacs/site-lisp/)]
Date: Wed, 06 Jan 2021 03:59:14 GMT	[thread overview]
Message-ID: <8735zezpf2.fsf@kyleam.com> (raw)
In-Reply-To: <87y2hi9qev.fsf@gmx.com>

Pierre Langlois writes:

> Hello there!
>
> Since the latest update to 9.4.4, some of us in Guix have been
> experiencing issues with loading packages that depend on Org [0]. It
> seems the root of the problem is that (org-release) returns an empty
> string, you can see this manifesting in this email actually :-).
[...]
> We download the Org source code directly from ELPA [1], it would seemx
> the org-version.el wasn't correctly generated, right?

Thanks for reporting.

It looks like org-release is also an empty string for 9.4.3, while 9.4.2
looks okay:

  # https://elpa.gnu.org/packages/org-9.4.2.tar.lz
  # https://elpa.gnu.org/packages/org-9.4.3.tar.lz
  $ grep '(org-release' org-9.4.3/org-version.el
     (let ((org-release ""))
  $ grep '(org-release' org-9.4.2/org-version.el
     (let ((org-release "9.4.2")

In between those two releases, there seems to have been some
restructuring on ELPA's end, in particular ee03829f90 (Finalize the new
master branch, 2020-12-14).

Based on looking at Org's entry in the elpa-packages file

  ("org"
   :url "https://code.orgmode.org/bzg/org-mode"
   :lisp-dir "lisp"
   :release-branch "maint"
   :ignored-files ("etc/schema" "contrib" "mk" "testing" "lisp/org-install.el")
   :news "etc/ORG-NEWS"
   :shell-command "make autoloads info; mv doc/org org.info; mv doc/orgguide orgguide.info"
   :doc ("org.info" "orgguide.info")
   :auto-sync t)

my uneducated guess is that the make command is failing to generate the
version when executed from its elpa.git worktree because,
unsurprisingly, elpa.git doesn't (and shouldn't) pull in the Org repo's
tags.

Bastien and Stefan, does the above guess sound right?  Any thoughts on
how to address the issue?


  reply	other threads:[~2021-01-06  4:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-28 10:27 Bug: (org-release) returns empty string on Elpa [ ( @ /home/pierre/.guix-profile/share/emacs/site-lisp/)] Pierre Langlois
2021-01-06  3:59 ` Kyle Meyer [this message]
2021-01-06 15:36   ` Stefan Monnier
2021-02-05  6:24     ` Kyle Meyer
2021-02-05 15:37       ` Stefan Monnier
2021-02-06 11:51       ` Pierre Langlois

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735zezpf2.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=pierre.langlois@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).