From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +FIuE2lrKmHfTAAAgWs5BA (envelope-from ) for ; Sat, 28 Aug 2021 18:59:21 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id QP7pDmlrKmFDaQAA1q6Kng (envelope-from ) for ; Sat, 28 Aug 2021 16:59:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A641C5AB7 for ; Sat, 28 Aug 2021 18:59:20 +0200 (CEST) Received: from localhost ([::1]:45386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mK1fr-0002JV-Mh for larch@yhetil.org; Sat, 28 Aug 2021 12:59:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51520) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mK1fK-0002Hh-BL for emacs-orgmode@gnu.org; Sat, 28 Aug 2021 12:58:46 -0400 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]:41776) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mK1fJ-0006kQ-2V for emacs-orgmode@gnu.org; Sat, 28 Aug 2021 12:58:46 -0400 Received: by mail-pf1-x434.google.com with SMTP id 2so8581364pfo.8 for ; Sat, 28 Aug 2021 09:58:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=40/HVgHg48+Ed3FbZOohmxpsyDzPh9V9l9FbU4MmJFk=; b=OuEpYg6NVRNhvhIdH3f0l/VPm2a0xoIvf+Xg8Wos++3IZKIpmlrk2H1UiyhAv0RTA7 TrIeKdzWdBTdB5Oe7uklQ+CS8YQ8cJT1C6OdAjAUS3sVgKjtnoUmJt6PLNDmQGw/Btty H5KsIflJFIL3dvEPTX+Yjonx/o3X2l7L+Ufs9fBuhusyA+srpC0awn1tXOZypOO+9qi4 LZLDwcg46L0/LFDoA2ZlxThNdklXlHbd+AT4ypckNjuoHH+p2oXexs50Aqg0FnUaapyG 3gGDWmfpvv7rgmCisK3TJS1RPeaPMQX5yoI6k8nvMuwgrh13JfKGtvFHCzqWiqJI/jTY 0iuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=40/HVgHg48+Ed3FbZOohmxpsyDzPh9V9l9FbU4MmJFk=; b=hnG9LZ8Yz0fO9AR+hEteMRiLKoFnPnEOfe7+FP12oHVNMYcleqhhENjAhsD08d93YF qVbqSFgUXk7Ahp7pn/dukmItFT+uOQpZcVb4GBiQ847Xu/axy+NKnT6qZVUvPCJHZnQ2 E7S9lJDEKoVZvovEAXpz8fRHzSwV7PgTt6rKV3vlkiOcUSXj+BbRyrIn/xQv2WilWcEa UAuB7VtNUrw/pfFITD3jeKGbJTsSJj464uZ5njraLddE28Kzpvo+JPydBnKe+TklERen KJjDKNTgEodvIPOePbQUVEPNebdsf3c4ptIC3V0yJFTWLaoe2Ay64fC1YWAJAj8flY05 Ftvg== X-Gm-Message-State: AOAM531ZTUpYq66llXF3Fe32l3pFczvDWdgS6emmZgSEHQ+xn1jnSJp1 ApEr3nAYgxo/Q4bkP3dnvTo= X-Google-Smtp-Source: ABdhPJxvdhmxiDn2MyF9hwrASQ5UXcqucs0PsM0h4PrtSrw9yDS/w1WgyfG8Y8LDt34VP4ohXI3xyQ== X-Received: by 2002:a63:d64f:: with SMTP id d15mr13242723pgj.9.1630169922936; Sat, 28 Aug 2021 09:58:42 -0700 (PDT) Received: from localhost (211-75-42-136.HINET-IP.hinet.net. [211.75.42.136]) by smtp.gmail.com with ESMTPSA id n14sm4114873pgd.48.2021.08.28.09.58.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Aug 2021 09:58:42 -0700 (PDT) From: Ihor Radchenko To: Colin Baxter Subject: Re: [PATCH] Re: org-bibtex does not recognise @Comment In-Reply-To: <87eead34ol.fsf@yandex.com> References: <874kd3288n.fsf@yandex.com> <878s0lu23z.fsf@localhost> <87eead34ol.fsf@yandex.com> Date: Sun, 29 Aug 2021 00:59:32 +0800 Message-ID: <8735qttsi3.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::434; envelope-from=yantar92@gmail.com; helo=mail-pf1-x434.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630169960; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=40/HVgHg48+Ed3FbZOohmxpsyDzPh9V9l9FbU4MmJFk=; b=JlUVZv832baT7aO72ZQwLQg3TWdS/DVYo1L3XymEOlck/jX1FRvUso4fQQPrlKPKbHVXIh ZifFhAfjfSgeYNBQU1ItvcDXeQZvtxfYHFZ1aOAyBvdN6iVAtDzr9mjIf+4R1OVLQYk0OD xRc2AK1mBO1x3MIvbVWeo2RrOOw1M+F8PhuFFCl5x21twVhVAXG1mVo6ocq/pND4WV+nXf qh4g69Ki0X4Iriy4qP07NnR8LXTvr6x3TUQwPKtfpz21HXbj1ZDs9/mfQ27Invg64MvXZg Oq+PJOnY1QZrFILMbsNdWxol+Y/vAKZbtNnbFhNGXX1aD84QqnTzkB8cKh8hJg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630169960; a=rsa-sha256; cv=none; b=X9Ca/cm217oOd7+wwoGxEkr+aDh+TIbB6HJ2BHi6wo60H86p2mwtmsdMBaLaZL5TDftyIR +9g3PxDei/98B1DcaJgtTLfmf+/bA1A6rJfkXHso9vbtsmMW/lL6k+0RAly4za+G2AnPz0 ZM0aSl07cRsR7qdFkiuw6Q31DOf5f3BoOdy+jXYLa+KWqlpAa3hNlI1HQ8bmSf+fVe0onO i46uuoUbwqacSzFiluvi0f8xw4wP/lmnVqxnj1/oDfAhrhYa8zXyq98+L30xSZK2k2wdEO 5DtzuyHSZsn/5VoPUlzVHzxhVVSWfUfetHOq3qFR3fnG7eeeKY7VTYdAsF5edA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=OuEpYg6N; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.63 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=OuEpYg6N; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: A641C5AB7 X-Spam-Score: -2.63 X-Migadu-Scanner: scn0.migadu.com X-TUID: lh6xxNm7rd81 Colin Baxter writes: > > Well. It will import the files. However, org-bibtex-write will > > indeed fail. If I got it wrong, please provide more details. > > > Confirmed > > > The fix is attached. > > I've applied your patch to my local git branch of org-mode and it works > very nicely. I can live with the write fail you mentioned. Let me clarify. On my side, org-bibtex-read-file did not throw any error on a .bib file with comment. Is it any different for you? The patch is supposed to fix org-bibtex-write -- the only problem I was able to see following your email. > Will you apply it to the master branch of org-mode? Nope. We need to wait for the maintainers with write access to apply it. Best, Ihor