From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id sB1MNuIcS2JHAgAAgWs5BA (envelope-from ) for ; Mon, 04 Apr 2022 18:29:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 4DTHMuIcS2Lx5QAAauVa8A (envelope-from ) for ; Mon, 04 Apr 2022 18:29:22 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1141F7379 for ; Mon, 4 Apr 2022 18:29:22 +0200 (CEST) Received: from localhost ([::1]:34978 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nbPZx-0002Wu-6d for larch@yhetil.org; Mon, 04 Apr 2022 12:29:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51764) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbPRC-0005Gz-2K for emacs-orgmode@gnu.org; Mon, 04 Apr 2022 12:20:20 -0400 Received: from sanpietro.red-bean.com ([45.79.25.59]:54606) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbPR9-0005kq-MZ for emacs-orgmode@gnu.org; Mon, 04 Apr 2022 12:20:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=red-bean.com; s=202005newsp; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:Reply-To:References:Subject:Cc:To:From:Sender: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0A4I7bfo0/Kiq1WKghRgBczojAHUOMZX1PMh7olUoS8=; t=1649089214; x=1650298814; b=TpjGgmkdmdGnbCfFMXrC1ZjupWmXMowlpkCnq47wrO/CKBFnJGnr1g1bDRuVfSJO9PyKGHWCdsJ F7jvq/bR3KJw61Emo8QP83SnhwP2kJBIV5SOTgHA8ldeT8hTHEIJi3cUWEHxd0gqj37cvD/Q9Bjox a9z9aJGQ3AmSkZ6FlgSBL3s73W13J2xeQsP+DJaNiXoeDvSVYeKF6J7+kwBhXSPIFNASlLRlAoLpm qPQo9+B551xR9KvZCRmGW50OcAWH1ufVW9RKAKo047aYKWEfMdAsyTAwKQlQCXumuV4s0eVqlV10S o8N5vKCe0FG6+VJP4PnSIZGuwwSy4REUoa/A==; Received: from [12.106.183.66] (port=59746 helo=hummy) by sanpietro.red-bean.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nbPR6-001xPs-Jz; Mon, 04 Apr 2022 16:20:13 +0000 From: Karl Fogel To: Ihor Radchenko Subject: Re: Removing obsolete function `org-truely-invisible-p'. References: <87czmcccrp.fsf@red-bean.com> <87h7b5rm6f.fsf@localhost> <87fsmx8x62.fsf@red-bean.com> <87v8vpf4fl.fsf@localhost> Date: Mon, 04 Apr 2022 11:20:13 -0500 In-Reply-To: <87v8vpf4fl.fsf@localhost> (Ihor Radchenko's message of "Mon, 04 Apr 2022 19:55:58 +0800") Message-ID: <8735iskegy.fsf@red-bean.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; format=flowed Received-SPF: pass client-ip=45.79.25.59; envelope-from=kfogel@red-bean.com; helo=sanpietro.red-bean.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Karl Fogel Cc: Org Mode Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1649089762; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=0A4I7bfo0/Kiq1WKghRgBczojAHUOMZX1PMh7olUoS8=; b=oSX7vfARh0u8K7gfxWkD0p37b1bUvB3ZDt73L0enC8BawhsoL+0NGjDxDndBKz+UJ1uVHH gYJGXyoCqiO6r6BnnIFNHWHrwAkGW8Oc53OvH/Jh94aimkwO/VnDc2UgNIULHR/F+0szm3 2woJIf4Kqb2qnCXCSqsL1uPiqlL5w+NcQkaLs/2VciTo52RfDeyCCx04cnE2B3b+f/sTJg s91mHefYLOXzIcoCCiZQiy4su3+1XSb7aTIfqq3aERFN2FsraFNQwjt90Qnpi9dG2RnPYt zv1Jq6GwnojLTdFGpyFdMaJgb9dIuiYKIPh83kEvOtE8U3jf0gi/y5ibHk57Ig== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1649089762; a=rsa-sha256; cv=none; b=DYscEP1vsEY4bbEXx4p6mhPPeBfIqU7UMWOxJfwcy5l1hGibdjl9MdhhlUKRBhiLFNDZs8 u/UhLh7Ryq/N6j7RSoSNfv0D2f21OuSkkFIf8ha+mnCHZdEYJhZPUZ4vPay+20mengpsrc j3CCjUFS9QHOtTmAPioBV+BMox7n+KnOk0lHPsdGCySfTEuijuOvO2GY0iBcPF7NCxRNUG iKqGQTng19hf44w/hPQP8zgHv0Nvh1oV1m5nMZ/afNVjnYZNYki0FAFiPXtujT4ikD/7Qo XQvy9rd3Jow+UpNi8vHs1xh/Sp1DoFQr96Kj27v8lhY8BN2D806Bwqm962AfhA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=red-bean.com header.s=202005newsp header.b=TpjGgmkd; dmarc=fail reason="SPF not aligned (relaxed)" header.from=red-bean.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.12 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=red-bean.com header.s=202005newsp header.b=TpjGgmkd; dmarc=fail reason="SPF not aligned (relaxed)" header.from=red-bean.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 1141F7379 X-Spam-Score: 6.12 X-Migadu-Scanner: scn1.migadu.com X-TUID: Sr2ntL4eDRte On 04 Apr 2022, Ihor Radchenko wrote: >> From bb229b4f8f78ae52962d7bc90c8b1d4993af8263 Mon Sep 17 >> 00:00:00 2001 >> From: Karl Fogel >> Date: Thu, 31 Mar 2022 19:02:38 -0500 >> Subject: [PATCH] Mark function obsolete & fix spelling of its >> name > >This commit message is a bit confusing. I would mention the >function >name: "Mark `org-truely-invisible-p' obsolete and fix spelling of >its >name" > >> * lisp/org-macs.el (org-truely-invisible-p): Move to... >> * lisp/org-compat.el (org-truly-invisible-p): ...here, and >> add... >> (org-truely-invisible-p): ...this compatibility alias. It does mention both names :-). But I'm happy to rewrite in the style you suggest above; I was just trying to follow the CONTRIBUTE guidelines. >It is too much. >We can either >1. Obsolete org-truely-invisible-p. Then, there is not much point > renaming it. >2. Rename it without obsoletion. Then, there is not much point >moving > the function definition to org-compat. Hmm. From the prior conversation in this thread, I thought we'd decided to do both. There are two separate issues here: 1) The function is no longer used in Org Mode or Emacs. 2) Unrelatedly, the function's name has a misspelling. (1) suggests that the function should be moved to 'org-compat.el' (if I understand correctly what that file is for). (2) is usually fixed with a rename and a compatibility alias -- i.e., this is what we would do for any function, whether used or unused. In your message 87h7b5rm6f.fsf@localhost of 19 Dec 2021, you wrote: >I feel slightly reluctant about removal. If nothing, this >function can >be a reminder about visible-mode and keeping it has little >downside. >Though if others think that removing would be better, I would >also be >fine with it. > >Renaming sounds reasonable. Just need to define obsolete alias >for the >old name in org-compat.el. My patch was based on the above, and on the fact that obsolete (i.e., unused) functions apparently get moved to org-compat.el, at least based on what I see already in that file. >> From: Ihor Radchenko >> Subject: Re: Removing obsolete function >> `org-truely-invisible-p'. >> To: Karl Fogel >> Cc: Org Mode >> Date: Sun, 19 Dec 2021 17:14:32 +0800 >> Message-ID: <87h7b5rm6f.fsf@localhost> > >I usually just leave an ML link in such cases: >https://orgmode.org/list/87h7b5rm6f.fsf@localhost As long as the ML link contains the Message-ID, as appears to be the case here, yeah. Mailing list archives can move, which causes links to suddenly stop working. But if the Message-ID is in the link, then (with a little extra work) one can always find the message in the new archive. (The reason I typically include more is to make things as easy as possible for those who are searching in a local archive using their regular mailreader. But I can switch to the above way if you'd prefer.) Best regards, -Karl