From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id +P+vEVP6YmITWwAAbAwnHQ (envelope-from ) for ; Fri, 22 Apr 2022 20:56:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id oBjXEFP6YmI38AAAG6o9tA (envelope-from ) for ; Fri, 22 Apr 2022 20:56:19 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 55ED33A114 for ; Fri, 22 Apr 2022 20:56:17 +0200 (CEST) Received: from localhost ([::1]:50252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nhyRz-0001Hy-8v for larch@yhetil.org; Fri, 22 Apr 2022 14:56:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44562) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhyQh-0001CO-6j for emacs-orgmode@gnu.org; Fri, 22 Apr 2022 14:54:55 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:42890) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nhyQf-0000CK-9Q for emacs-orgmode@gnu.org; Fri, 22 Apr 2022 14:54:54 -0400 Received: by mail-wr1-x42e.google.com with SMTP id bv16so12278901wrb.9 for ; Fri, 22 Apr 2022 11:54:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=EQO7Jk9GznFGnNjgOmKNduw/7OKdTOGs5wGHvvLb2MM=; b=RIdRBJs1vHPo0ANX/IGtQaKLzniP13TJ/GJ5EQXo2q73OQSkiL65sfXvKxUGfL438f h3SWmKTI+KkehZJhUD52spgBY1YHArgy9ZD9HxuCJ668UBYo+QNOlWkU4tql3AzT7Py2 OaBzvYVWNsUYhllb2UoBz4yN5RLkKlk44ojIonRVRnYoVImoTlvoB8n1LrW7EruTx6iw iJXtpFB56rpoLNi9UrNovOcm6p5gQJ3lrXdJ8WSv7lBcAvn+p2S23/6mOL8hNLPrpSIZ G+/jwyU18tvoFccU+/rWhnFcrrUy6UdL3XB8lpUVSd6kBUgsAKv6XAVQ1qwDsHhpCKAb 4m4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=EQO7Jk9GznFGnNjgOmKNduw/7OKdTOGs5wGHvvLb2MM=; b=Mzk06tIyuw9J8h/tt8Gb3cIinZUwMGk2uiOMRhhbEA1HaapWvXyXvovVoltKsm+VU5 3tHaQPYGAkqfzQoqE6FqdWlt36N85NRWFLpk/ZcatYwH0FFDCE0egPQx9ez4Wdu4CNQs SYNYxFV1fztGoms1E/4Wh/LKZI/knnvaoivHPW/wRZeXtmarogP/xa74bpqTE7L5oY/P Eh0eHYUSMlDxjp222Mv+grdayV+aaYDN7tJmyYsvAmA21kJMt3EEpl/uSSrPp+mb6rS2 2NUDi9mG5mUPWF71JA4J4AdaSQunfCxhSDQQmNojYQnvvQxF/ub+38FaHLDHvuf6U50k fh9w== X-Gm-Message-State: AOAM531H23CztQj562fVy0VmTmnivX2zHUp9apOu8UBFaac0Gt7LxCuJ 7x/FEqTWCS/MSmFK1sdZ6NprgrPmEJ0= X-Google-Smtp-Source: ABdhPJzr3jTP6TwiycTZ1kW5JVp2jhjnF0cfU9CoBge29R9kPNHk5/ZQ4R1mR2xiL/97nk0w4mQIRA== X-Received: by 2002:a5d:59a9:0:b0:20a:9047:24ac with SMTP id p9-20020a5d59a9000000b0020a904724acmr5109834wrr.396.1650653691039; Fri, 22 Apr 2022 11:54:51 -0700 (PDT) Received: from hirondell (2a01cb040b3a3800520faa2f5792037c.ipv6.abo.wanadoo.fr. [2a01:cb04:b3a:3800:520f:aa2f:5792:37c]) by smtp.gmail.com with ESMTPSA id bu17-20020a056000079100b00207a3124b1dsm2194480wrb.65.2022.04.22.11.54.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 11:54:50 -0700 (PDT) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Ihor Radchenko Subject: Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch References: <87a6f84edg.fsf@localhost> Date: Fri, 22 Apr 2022 20:54:48 +0200 In-Reply-To: (Ihor Radchenko's message of "Wed, 20 Apr 2022 21:23:41 +0800") Message-ID: <8735i5gd8n.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=kevin.legouguec@gmail.com; helo=mail-wr1-x42e.google.com X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URI_NOVOWEL=0.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1650653777; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=EQO7Jk9GznFGnNjgOmKNduw/7OKdTOGs5wGHvvLb2MM=; b=jUN/qirVewKe91up5YNAJlA25nyOdv1mPOhjgvtxYFEgT5RUCOFO/pr6aKapy1DQ4ZJjcl DZZEP1N1LI5GCCnC1kDNEtEoofnA+XGIQpCMAdI6WFUGe/ujlFK6OTBYuHeTYnAKBgQlAj yD1zlufnPuQ5/VGLQ5Q5hprMz0ilGti61fiiVSPBX06lS63xNeF4leHZSxmbcOfoELf0mC kfNfTcrMHn0yy+nCtvwnCugeCTlVOfBb98SUojeDeNwTdBm5tq9mdJDeCSd2YW9m1xZpP/ lsv/+Ev/tFMjB9/ENE39NbmwbcMPZxPdQlpSEjBuRA0D8irKQkc+EBxvukjHkQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1650653777; a=rsa-sha256; cv=none; b=hyAHByMj8r/X3PIB55HwDp6l20XkCPu3x6F9Sg8l/Eyiu8byAkVi40XYUcf2KH/Swsi+PM XaAmYz/evWHIwdvK2/JK9ovoQL87m5O1sobeY45wffYccYvkWleI1BMRtgGUips3nUJ8Az LXiCyTdOBTZntoddvWjrsw9XpTUD0Wysfrh58HTS33M0Mz6bWpwVPoi0ZrsJyz8npGDGq5 h9icdyzVHD7jcjbVyx1aYePvSaMLIq8NbxsmlBaWGSBIQjhxZvl2YFFYOkkYgNdo8xbU53 MqVYmcKZKUQBL9IlXBAqOhMQuORMWy8ACcP5/p9n/DY+bOpx7toPxJHHQns6NA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=RIdRBJs1; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.02 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=RIdRBJs1; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 55ED33A114 X-Spam-Score: -4.02 X-Migadu-Scanner: scn1.migadu.com X-TUID: qqHyIn2bO2CH --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hey Ihor! Ihor Radchenko writes: > This is the final version of the patch. I am going to merge it this > weekend. If there are any comments, please send them ASAP. I've thrown a couple of LOGBOOK-heavy Org files at your branch; I'm observing something that I can't make sense of. I tried to condense one of these files into a small reproducer, see attached file; couldn't find the time to make it smaller, sorry! My recipe (based on commit f9dd109bc, Emacs 29.0.50 commit 864c8013fd): $ git switch feature/org-fold-universal-core-tidy $ make autoloads $ emacs -Q -L lisp -eval "(setq org-startup-folded t)" repro.org Restarting Emacs with the above between each step: (1) C-s abc =E2=87=92 no logbook is unfolded, (2) C-s def =E2=87=92 no logbook is unfolded, (3) C-s ghi =E2=87=92 some logbooks are unfolded. Assuming you can reproduce: is it expected that logbooks are expanded in case (3)? I don't see what's "conceptually" different in situation (3) vs. (1) and (2), so I'm puzzled to get different results. Also, a bit of idle curiosity: > (defun org-fold--isearch-reveal (&rest _) > "Reveal text at POS found by isearch." > (org-fold-show-set-visibility 'isearch)) org-fold-show-set-visibility calls either org-fold-show-set-visibility--overlays, or org-fold-show-set-visibility--text-properties, and AFAICT neither of these handle 'isearch as an argument=E2=80=A6 Is there a (cdr (assq 'isear= ch org-fold-show-context-detail)) missing? (This comes from a very cursory reading of the code; apologies if I've missed something) Other than this logbook oddity, I haven't found anything concerning. Thanks for your efforts! --=-=-= Content-Type: text/org; charset=utf-8 Content-Disposition: attachment; filename=repro.org Content-Transfer-Encoding: quoted-printable * xxxxxxxxxxx xxxx :LOGBOOK: CLOCK: [2021-11-02 Tue 17:18]--[2021-11-02 Tue 17:25] =3D> 0:07 :END: ** xxx xxx xxxxx *** xxxx [[xxxx:xxxxxxx/xxxxxxxxxx/xxxxxxxxxxxxxxxxx]] :LOGBOOK: CLOCK: [2021-11-03 Wed 13:51]--[2021-11-03 Wed 14:13] =3D> 0:22 CLOCK: [2021-11-03 Wed 11:52]--[2021-11-03 Wed 12:00] =3D> 0:08 CLOCK: [2021-11-03 Wed 11:27]--[2021-11-03 Wed 11:42] =3D> 0:15 CLOCK: [2021-11-03 Wed 09:06]--[2021-11-03 Wed 10:04] =3D> 0:58 CLOCK: [2021-11-02 Tue 18:11]--[2021-11-02 Tue 18:45] =3D> 0:34 CLOCK: [2021-11-02 Tue 17:36]--[2021-11-02 Tue 17:38] =3D> 0:02 CLOCK: [2021-11-02 Tue 17:25]--[2021-11-02 Tue 17:31] =3D> 0:06 :END: - [ ] xxxxx://xxxx.xx.xxxxxxx.xxx/xxxxxxx/xxxx xxxx? (xxxx.xx xxxxx xx xxxxxxx) - =F0=9F=99=8C - "xxxxxxx abc xxx xxxxxxxx xxxxxxxxxx" **** [[xxxxx://xxxxxxxx.xxxxxxx.xxx/xxx/#/xxxxxxxxxxx/][xxx xxxxxxx xxxx xx= xxxxxxxxx]] **** [[xxxxx://xxxx.xxxxxxx.xxx/xxxxxxx/xxxxxxxxxx/xxxxxxxxxxxxxxxxx#xxxxx-= xxx-xxxxxx-xxxxxx][xxxxx xxx xxxxxx xxxxxx]] **** [[xxxxx://xxxx.xxxxxxx.xxx/xxxxxxx/xxxxxxxxxx/xxxxxxxxxxxxxxxxx#xxxxxx= -xxxxxxxxxx][xxxxxx xxxxxxxxxx]] - def xxxxxxxxxx: - x (xxxxxxxx) - x (xxxxxxxx) **** [[xxxxx://xxxx.xxxxxxx.xxx/xxxxxxx/xxxxxxxxxx/xxxxxxxxxxxxxxxxx#xxxx-x= xxx-xxx-xxxxxxx-xxxxx][xxxxxxx xxxxxxxxxxx]] xxxxxx xx xxx xx xxxxxxxxxxx xxxxxxx? =E2=87=92 xxxxxxx-xxxxxxxxxxxx@xxxxxxx.xxx **** [[xxxx:xxxxxxxxxxxx]] xxxxxxxx: ~xxxxxxx.xxxx.xxx:/xxxxxxx/xxxx-xxxx~ *** xxxx [[xxxxx://xxxx.xxxxxx.xxx/xxxxxxxx/x/xxxxxxxxxxxxxxxxxxx-xxxxxxxxx= xxxxxxxxxxxxxxx/xxxx][xxxxxxxxxx xxxxxxx]] :LOGBOOK: CLOCK: [2021-11-03 Wed 15:13]--[2021-11-03 Wed 15:14] =3D> 0:01 CLOCK: [2021-11-03 Wed 14:55]--[2021-11-03 Wed 14:57] =3D> 0:02 :END: *** xxxx [[xxxxx://xxxx.xxxxxx.xxx/xxxxxxxx/x/xxxxxxxxxxxxxxxxxxxxxxxxxxxxx= xxxxxxxxxxxxxxx/xxxx][xxxx xxx xx xx xxx xxx]] :LOGBOOK: CLOCK: [2021-11-03 Wed 15:14]--[2021-11-03 Wed 15:17] =3D> 0:03 :END: *** xxxx [[xxxxx://xxxx.xxxxxx.xxx/xxxxxxxx/x/xxxxxxxxxxxxxxxxxxxxxxxxxx_xx= xxxxxxxxxxxxxxx/xxxx][xxxxxx xx xxxxxxx xxxxxxx]] :LOGBOOK: CLOCK: [2021-11-03 Wed 16:00]--[2021-11-03 Wed 16:30] =3D> 0:30 :END: *** xxxx [[xxxx:xxxxxxx/xxxxxxxxxxxx]] :LOGBOOK: CLOCK: [2021-11-05 Fri 11:02]--[2021-11-05 Fri 11:18] =3D> 0:16 CLOCK: [2021-11-05 Fri 09:42]--[2021-11-05 Fri 09:55] =3D> 0:13 CLOCK: [2021-11-04 Thu 18:30]--[2021-11-04 Thu 18:32] =3D> 0:02 CLOCK: [2021-11-04 Thu 12:07]--[2021-11-04 Thu 12:14] =3D> 0:07 CLOCK: [2021-11-04 Thu 11:10]--[2021-11-04 Thu 12:00] =3D> 0:50 CLOCK: [2021-11-03 Wed 18:11]--[2021-11-03 Wed 18:20] =3D> 0:09 :END: - xxxx :: xxxxxxx + xxxxxxxxxxxxxxxx - xxxxxx :: xxxx xxxxxxxx xx xxxxxxxx xxxxxxx - xxxxxxx xxx "xxxxxxxxxx": - xxxxx xx xx xxxxxxxxxxxxxxxx xxxx xxxxxxxxx - xxx xxxxxx xxx =E2=88=88 >x xxxxxxx - xxxx :: xxxxxx xxxxxx xxxxxxxx xxxxxxx + xxxxxxxxxxxxxxxx - xxxxxx xxxxxx xxxxxxxxx xxx xxxxxxxxx - xxxxxx xxxxxx xxxx xxxxxxxxxx - xxxxxxx :: xxxxx/xxxx/xxxxxx xxxxxxxxx - xxxxxxxx xxxxxxxx xxxxxx - =F0=9F=99=8C - [[xxxx:xxxxxxx/xxxxxxxxxxxx/xxxxxxxxxxx]] - "xxxx xxx xxxxxxxx: xx xxx xxxxx xxxxxxx xxxxxxxxxxx, xxxx xxxx xxxxxx xxxxx xxxxx xxxxxxxx" - "xx xxx xxxx xxxxxxxxxx xxxxx xxxx xx xxxx xxxxxxx" - [[xxxxx://xxxx.xxxxxx.xxx/xxxxxxxxxxxx/x/xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx= xxxxxxxxxxxxxx/xxxx#xxx=3Dxxxxxxxxx][xxxxxxx xxxxx xxxxxxxxxxx]] - "xxxx xxxxxxxxxxx xx xxxxxxxx xx xxxxxxxxx xxxxxxx xxxx xxxxxxxx xxxxx xxxxxxxxxxx" - [[xxxxx://xxx.xxxxxxx.xxx/xxxxxxx/xxxx-xx-xxxxxxx][xxxx xx xxxxxxx]] (xxxxx xxx ) *xxxxxxxx* : - xxxxx://xxxx.xxxxxxx.xxx/xxxxxxx/xxxxxxxxxxxx/x&x **** [[xxxxx://xxxx.xxxxxx.xxx/xxxxxxxx/x/xxxxxxxxxxxxxxxxxxxxxx-xxxxxxxxxx= x_xxxxxxxxx/xxxx#][xxxxxx =E2=80=94 xxxxxxxxxx xxx xxxxxxxxxxxx]] :LOGBOOK: CLOCK: [2021-11-05 Fri 09:55]--[2021-11-05 Fri 10:00] =3D> 0:05 :END: **** [[xxxx:xxxxxxx/xxxxxxxxxxxx/xxxxx/xx]] :LOGBOOK: CLOCK: [2021-11-08 Mon 13:20]--[2021-11-08 Mon 13:21] =3D> 0:01 CLOCK: [2021-11-05 Fri 11:02]--[2021-11-05 Fri 11:02] =3D> 0:00 CLOCK: [2021-11-05 Fri 10:29]--[2021-11-05 Fri 10:45] =3D> 0:16 CLOCK: [2021-11-05 Fri 10:00]--[2021-11-05 Fri 10:23] =3D> 0:23 :END: *** xxxx [[xxxx:xxxxxxx/xxxxxxxxxx/xxx/xxxxxxx_xxxx/xxxxxxxxxxxxx][xxx xxxx= xxxxxxx xxxxxx]] :LOGBOOK: CLOCK: [2021-11-05 Fri 15:25]--[2021-11-05 Fri 15:27] =3D> 0:02 CLOCK: [2021-11-05 Fri 14:30]--[2021-11-05 Fri 14:47] =3D> 0:17 CLOCK: [2021-11-05 Fri 13:47]--[2021-11-05 Fri 13:47] =3D> 0:00 CLOCK: [2021-11-05 Fri 11:35]--[2021-11-05 Fri 11:37] =3D> 0:02 CLOCK: [2021-11-05 Fri 11:18]--[2021-11-05 Fri 11:25] =3D> 0:07 :END: **** [[xxxx:xxxxxxx/xxxxxxxxxx/xxx/xxxxxxx_xxxx/xxxxxxxxxxxxxx][xxxx xxxxxx= xxxx]] :LOGBOOK: CLOCK: [2021-11-05 Fri 13:47]--[2021-11-05 Fri 14:30] =3D> 0:43 :END: - =F0=9F=A4=AF - [[xxxxx://xxxx.xxxxxx.xxx/xxxxxxxxxxxx/x/xxxxxxxxxxxxxxxxxxxxxxxx-xxxxx= xxxxxxxxxxxxxx/xxxx#xxx=3Dxxxxxxxxx][xxxxxxxxxxx xxxxxxxx & xxxx xxxxx]]: x= xxxx xxxx xx xxx xxxxxxxxxxxx **** [[xxxxx://xxxx.xxxxxxx.xxx/xxxxxxx/xxxxxxxxxx/xxx/xxxxxxx_xxxx/xxxxxxx= xxxxxxxxxx][xxxxxxx xxxxxxxxxx]] :LOGBOOK: CLOCK: [2021-11-05 Fri 14:47]--[2021-11-05 Fri 15:04] =3D> 0:17 :END: - =F0=9F=91=8D ghi xxxxxxxxxx & xxxxxxxxxx xxxx --=-=-=--