From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id OLirGF75Z2LccgEAbAwnHQ (envelope-from ) for ; Tue, 26 Apr 2022 15:53:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 6AaoGF75Z2L8HAEA9RJhRA (envelope-from ) for ; Tue, 26 Apr 2022 15:53:34 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 008D822D3E for ; Tue, 26 Apr 2022 15:53:33 +0200 (CEST) Received: from localhost ([::1]:40770 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njLdE-0005Gh-OQ for larch@yhetil.org; Tue, 26 Apr 2022 09:53:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59772) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njLbf-0005E8-3U for emacs-orgmode@gnu.org; Tue, 26 Apr 2022 09:51:58 -0400 Received: from mail-oi1-x22d.google.com ([2607:f8b0:4864:20::22d]:44713) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njLbd-0001ar-Kt for emacs-orgmode@gnu.org; Tue, 26 Apr 2022 09:51:54 -0400 Received: by mail-oi1-x22d.google.com with SMTP id m11so9928125oib.11 for ; Tue, 26 Apr 2022 06:51:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=aGBP6BVdndVkuR3PuxH+dqA7e30Pcge2ATpuy9mMNEw=; b=IANdMvbkFNmwJFA9tZPpMmYzsquQxb/Q1ENVcbsVlgF5fcVqr4p2AR+hZDy9YP4bil 8UE5wFzW4FsxAEnLcCuPpLjFWWzb+K1v2dAvoqKZEYyJKls/q7euRv8cndWDNwh50d1j DHcmK7Eelnq5LawPShGAAsOMdSYXdm8l0xzqdG1JRrupRGL9P1NpIBenjP5sejwvWKEG 9URfGwndi4uejwlotbnIFz5uUnTQYvn57fh1eQPMc9uMn2i+Z2/J40kV7k8pdl5RewAx k9y7UVTXFfuOmgGuEAjBzt+7XWzA3rZYzfpM3YkwKw9a85fzCXuq8wmAgzKp/E4knAN2 +HOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=aGBP6BVdndVkuR3PuxH+dqA7e30Pcge2ATpuy9mMNEw=; b=mbtSdV34l4uB0OUP5mCn2xe/aQfXIMU6ZnZNBZKxHEHxD5d3p9FDDTDWEPZ2qBRKlA GQoEhon8r4VRJxDK7Laq7xXMeu1aqGRH/i5ud1k2h4af6CCked2COmvv3A7Qsx6kD6Ua LbsMhvuLoGjyvBVTdfJRViymZgsrj9KpizQs8dXWZMJtpxVsRwYSzlrLIFIisSUm061p PloD/gHaGkDbt5H8NXfn0WqYiIHzy6LCbzgwJ+fYGZS/W6VjiGBdrLcqREX8cDpiWUqx R6VuBrLpR/HMWqFyA+X5Aany7jgWST5UWLgZv8U7FF4yjiPUbOs5f5q7Erp7BixqSGwu JxKQ== X-Gm-Message-State: AOAM530IQdi8bmHUQLFlMsmxXrSEqlMMILUJyXnBVZRxYHiBhcC3U53Z lYIzasvRqorPPGrHd+dSGWpZZCbZOTibTw== X-Google-Smtp-Source: ABdhPJwWrJilPBUy9df1b0xbFNN01mLu8IqhKmo3PHJzlkYN9BeewS4I7iuR/nS8KdLK2V7y5Obo8w== X-Received: by 2002:a54:470e:0:b0:322:5d24:a59f with SMTP id k14-20020a54470e000000b003225d24a59fmr10797041oik.76.1650981112255; Tue, 26 Apr 2022 06:51:52 -0700 (PDT) Received: from localhost ([104.223.98.2]) by smtp.gmail.com with ESMTPSA id u7-20020a056870440700b000e686d1387asm827613oah.20.2022.04.26.06.51.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 06:51:51 -0700 (PDT) From: Ihor Radchenko To: Ignacio Casso Subject: Re: [BUG] link abbreviations do not work inside property drawers [9.5.2 (release_9.5.2-38-g682ccd @ /home/ignacio/repos/emacs/lisp/org/)] In-Reply-To: References: <87y1zvlyj0.fsf@localhost> <878rrsut3o.fsf@localhost> Date: Tue, 26 Apr 2022 21:52:44 +0800 Message-ID: <8735i0vtn7.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::22d; envelope-from=yantar92@gmail.com; helo=mail-oi1-x22d.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1650981214; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=aGBP6BVdndVkuR3PuxH+dqA7e30Pcge2ATpuy9mMNEw=; b=Aq0mNWeOvBkd2y3yWZhDnvwhCQkaCcIIAkIIO7oZXqN5EMpJuinMJNM9u2QyqlhP4IijAF yQ+fBHoE+XCFxVmtgHer02er7t1A+4LZM7yMXr7PSOaSf0ht8WcMGpVZzb+vSXQ1u6N8gh Wkind5ILnJJxdShiTCg1kBxCXjV7OJKKDAEBZFU3xm5UDwJhey1tYmPwDiBkKSMT/CT5jW 8D1Gwlbf+QR2CzJQYyYibI79HSQMQSeSy7dNuO5dWBE/vUeg9S5LZwV0ZJ2a9IiCpNMvVa kHuhQn6ZA7o9mQYcaxhIkYY1+us7qHOpr8KKCOGOxe+UHsi9ah4y2uaPXCQW5g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1650981214; a=rsa-sha256; cv=none; b=bwQnF0C6pjzVN61h8zN2iGGssIwEG9tBzBVi3ffiZYa7ZdIOSNo2DmarKvvC1O+XUbJQUx fVMpOS3XiN4ZYQMqVWb0DpysQiDM496oNOKL/RP7AvqMPVIr/4pTsD87mybgMh5MwyPVFa qkbIBVUaw4/g5Xu3QivuNnBnqXNj/rhMD01QWmTEDmxSZNb+7a5BlrUiBBekX07CJ5RP5n 7c/ZeHL+w17tuYA99VVrInVZq9S+tKxbGPzBi8AAS7hQgoE4IbxNdtVNKalXaUbYkAT/F6 DA4upcsiAZ67B/MtJ3lfHsMpoOOp64nz2g3zE302U33wTlTi0vRAVzcBlOnp5w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=IANdMvbk; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.51 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=IANdMvbk; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 008D822D3E X-Spam-Score: -3.51 X-Migadu-Scanner: scn1.migadu.com X-TUID: q49mYWagHJax Ignacio Casso writes: > I agree that changing the current behavior of > `org-link-open-from-string' may be problematic, however I don't think > that it's worth to introduce the optional argument just for this > "bug". Makes sense. I am going ahead of what is currently on main. > (cond ((org-in-regexp org-link-any-re) > (let ((org-link-abbrev-alist > (append org-link-abbrev-alist org-link-abbrev-alist-local))) > (org-link-open-from-string (match-string-no-properties 0)))) > ...) > ... > What do you think? I do not like this idea. There is also org-link-abbrev-alist-local and potentially other variables to be introduced in future. We should not rely too much on internal workings of ol.el. A better approach could be using org-link-expand-abbrev. It is an API function and should be forward-compatible. Best, Ihor