From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id +G3ALkbDyGI+ogAAbAwnHQ (envelope-from ) for ; Sat, 09 Jul 2022 01:52:38 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id UEmhLkbDyGLeUgEAauVa8A (envelope-from ) for ; Sat, 09 Jul 2022 01:52:38 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7A7DD1DC7C for ; Sat, 9 Jul 2022 01:52:38 +0200 (CEST) Received: from localhost ([::1]:36238 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9xm0-0007W9-Qm for larch@yhetil.org; Fri, 08 Jul 2022 19:52:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52294) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9xk8-0006Pw-LX for emacs-orgmode@gnu.org; Fri, 08 Jul 2022 19:50:40 -0400 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]:39615) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o9xk7-0000T4-3N for emacs-orgmode@gnu.org; Fri, 08 Jul 2022 19:50:40 -0400 Received: by mail-pl1-x62a.google.com with SMTP id c13so69138pla.6 for ; Fri, 08 Jul 2022 16:50:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=Vs58vaC4W4akokN6j3mf4340rQ4mcRZwBWPOR2z9z/g=; b=S4ndd9J8ZiwzdEygBDwpwEZUpkbQKMe4T9Gzj3A3lpp3pgw1IJ65l+yZOtQfLni8pu 5hSz8E7GuPQNHjYvoSMT/EoLUqy32Ts8Q7oxBloWTwkC1lAkDnoAOKHL76It6rwVMqxz G+zIRSWHCqx0ghC+t4pcRIkMfUKIR8+bGAOYoA953qTvkfBcdSPMEArNmgWLfmpS6NfP qdAnLQ9+F51ksHnazuJKYi9tEaOkNSHgA/6M/dBGEYamC2WQi9dpI59cRzRPF277hLWK EU/Y0OJUb+qmWMbbwqpAMgXUCZJ8f4uL1ReP2bYZWNN4S3a+X0aY7goYbevAvESOP1wx cb8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:cc:subject:in-reply-to:references :date:message-id:mime-version; bh=Vs58vaC4W4akokN6j3mf4340rQ4mcRZwBWPOR2z9z/g=; b=0ueLKhHPTkJAmieA4wsmDb19rIZx31yLcHY336lVkMlueEh5oiVzF1T1Ur2DvEEPjy st83btCCmZkOSAgNpvq/zd6vGtincm+cnEnrkVeiG/rrWVtEI05urbdILMrKGWH2WgK3 /EJKz+Et0XFe8wJ+wG9wbrY3c1G76fynUOdKGV42rWA+EE9xEcd2+RllcJ9P2b/svA4f yzZUdbeAXSDp/QF2+ujAD+y65BlghVUnA9xyaOkHj3vOMUWvo//mLTn0FLaBCIAMlrkO v9/4++P2vzMLBFvhTsY9CRv55WJjaYuCwx4R1vq1BU0dFyVzTwquP+zcpS/v+I34+BTx OI8g== X-Gm-Message-State: AJIora/VoOy29gkaoSqtR1TqlXI1FaunAIwEeHAlChe76VMhPr3ulENZ mKjlEkAfis+aPHSF/D1YeOYE/0EVg/U= X-Google-Smtp-Source: AGRyM1uQQtOMwDq7D+jsJz0u7EQrrZVoFOPcziD1bMtq9qqlMZeuu7ON+yU2l4PQUrx5+bfNvat2nA== X-Received: by 2002:a17:902:ce0f:b0:16b:d99c:ecee with SMTP id k15-20020a170902ce0f00b0016bd99ceceemr6113836plg.84.1657324236954; Fri, 08 Jul 2022 16:50:36 -0700 (PDT) Received: from ryzen3950 (c-208-82-98-189.rev.sailinternet.net. [208.82.98.189]) by smtp.gmail.com with ESMTPSA id c2-20020a17090a8d0200b001ef82e5f5aesm2169306pjo.47.2022.07.08.16.50.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jul 2022 16:50:36 -0700 (PDT) From: Matt Huszagh To: Ihor Radchenko Cc: Emacs-Orgmode Cc: Subject: Re: [PATCH] Remove additional newline at end of results block In-Reply-To: <87zghsi3ki.fsf@localhost> References: <87zghsi3ki.fsf@localhost> Date: Fri, 08 Jul 2022 16:50:35 -0700 Message-ID: <8735fb6u5w.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::62a; envelope-from=huszaghmatt@gmail.com; helo=mail-pl1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1657324358; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Vs58vaC4W4akokN6j3mf4340rQ4mcRZwBWPOR2z9z/g=; b=ImAA9O+0avTd9e9fedQdBWxiP1xpdPB0Wtx/2ZTPvryULf/eAUOW9D1eDKuV3DROtOFqVn iW5lnjvB5VqcgxHnLiP3ho0KpkHP7bLD4U3ZR79oLkbiJl/rgKmqmfdmCv5jMc9v4qF0AS +WcC5hxv1v3QAiqFosVHVI1sSzCTQpQIICnIVum+GczwhXvmJ0OQBy+yJW9texvyhYArCh Jev+BMhFUZv/+ViZ2ScdBQ0iZZyJj4vV7ctXEX1kzwnXi2nh8FMMXtDmlPzBNSJcBkagED BPA8VuxGGDu0IuunqyWxd2D2FHfVDMwLGTz22ne9mjJ8oO1bSrVg6eSTeqxJmA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1657324358; a=rsa-sha256; cv=none; b=b+ktv/tvTwtPZ0k+V6y9WW+L00hoiEe2fP1/xz856wmODuufazF7RLLO9svPQvwOD+ce6K hqvYq9BngGBxbNb2+LWnWudZSn1d8OfuwslNU1p4To+r6VmumqK6ksU3jnjtuFRNnennea dytnUcclw/bZEh2mLxl0O9gspL7s9w5MWVCH8Nv612HfNLiPJeT0v6ZNJrNoG92yc7UKxz PKKkRs/0wD2i8e6s3GsnGfDn+rty+CvpqbwuOawJpzwkIvvfT6QbRX/hmc07OEjv1/wgrm bbKYNsjEVHw30/jCD6yOGk0N+jNZivXNBupJuGxYu1RKlEW+PCdaN9JjUt/jMA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=S4ndd9J8; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.65 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=S4ndd9J8; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7A7DD1DC7C X-Spam-Score: 6.65 X-Migadu-Scanner: scn0.migadu.com X-TUID: xvJArx+MS4ER Ihor Radchenko writes: > Thanks for the patch! And sorry for the late reply. No worries for the delay - I know you have a lot of these. Thanks for the review. > Your explanation is quite confusing, but I think I managed to understand > what you referred to: > > ------ > We can write the simplest equation as > #+begin_src latex :exports results > \begin{equation} > 1 + 1 = 2, > \end{equation} > #+end_src > the paragraph should continue here. > -------- > > will be exported as > > ------ > We can write the simplest equation as > \begin{equation} > 1 + 1 = 2, > \end{equation} > > the paragraph should continue here. > ------ > > Note the extra empty line below equation environment. > > However, I am not confident if the proposed change is going to be safe > for other uses of src blocks. > > I'd like to request other people who use export and source blocks > extensively to try the patch and see if it breaks anything. > > Meanwhile, could you please reword the commit message and make it more > concise and clear? Can you clarify what you find to be unclear? Rereading my own commit message, my only problem with it is how it starts: I'd add one sentence to contextualize it a bit. For instance, The previous behavior always ensured the presence of an empty line between the results block of a source block and the subsequent text. However, inserting this newline prevents a valid use-case and protects against an edge-case that is completely avoidable without the additional guarantee it provides. ... (the rest remains unchanged) Oh and I also made a typo. A sentence further down should read "...generate an SVG image...". This commit message isn't short, but I think it's very clear. It describes the previous behavior, explains the rationale for that behavior, and then illustrates (with a complete example) how this prevents a valid use case. It also explains why the new change does not prohibit any behavior that was previously possible. As someone who frequently uses git log, I'd much rather see a commit message like this than the typical (usually) unhelpful one or two sentences that fail to provide the motivation for a change. There's no downside to a long commit message, and this one is structured such that it proceeds from more general to more specific information - not everyone has to read the entire thing. I'm not trying to be difficult :) but I do care about the quality of this codebase (as I know do you), so I'm reluctant to change something in a way I feel is inferior. But, if you have specific parts etc you feel are unclear I'm more than happy to address those. Matt